{"id":813729,"url":"http://patchwork.ozlabs.org/api/patches/813729/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-9-git-send-email-peterx@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505375436-28439-9-git-send-email-peterx@redhat.com>","list_archive_url":null,"date":"2017-09-14T07:50:29","name":"[RFC,08/15] monitor: create IO thread","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"82b1ed237efccdf48881d5898134ef1b14a1bec3","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-9-git-send-email-peterx@redhat.com/mbox/","series":[{"id":3043,"url":"http://patchwork.ozlabs.org/api/series/3043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3043","date":"2017-09-14T07:50:21","name":"QMP: out-of-band (OOB) execution support","version":1,"mbox":"http://patchwork.ozlabs.org/series/3043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813729/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813729/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9pZ0dpHz9sRm\n\tfor ;\n\tThu, 14 Sep 2017 17:56:38 +1000 (AEST)","from localhost ([::1]:46206 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsP0m-0002x6-4I\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 03:56:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52160)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsOw5-0006n8-Mw\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsOw2-0007Fe-Ih\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:45 -0400","from mx1.redhat.com ([209.132.183.28]:33128)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsOw2-0007F0-AG\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:42 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 448EF155E2;\n\tThu, 14 Sep 2017 07:51:41 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 85AC3619BE;\n\tThu, 14 Sep 2017 07:51:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 448EF155E2","From":"Peter Xu ","To":"qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 15:50:29 +0800","Message-Id":"<1505375436-28439-9-git-send-email-peterx@redhat.com>","In-Reply-To":"<1505375436-28439-1-git-send-email-peterx@redhat.com>","References":"<1505375436-28439-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 14 Sep 2017 07:51:41 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC 08/15] monitor: create IO thread","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Fam Zheng , Juan\n\tQuintela , Markus Armbruster ,\n\tpeterx@redhat.com, mdroth@linux.vnet.ibm.com,\n\tStefan Hajnoczi , =?utf-8?q?Marc-Andr=C3=A9_Lure?=\n\t=?utf-8?q?au?= ,\n\tPaolo Bonzini , \"Dr . David Alan Gilbert\"\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Create one IO thread for the monitors, prepared to handle all the\ninput/output IOs. Only adding the thread, loop and context, but doing\nnothing else yet.\n\nSigned-off-by: Peter Xu \n---\n monitor.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 49 insertions(+)","diff":"diff --git a/monitor.c b/monitor.c\nindex 7bd2e90..9e9a32e 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -208,6 +208,14 @@ struct Monitor {\n QLIST_ENTRY(Monitor) entry;\n };\n \n+struct MonitorGlobal {\n+ QemuThread mon_io_thread;\n+ GMainContext *mon_context;\n+ GMainLoop *mon_loop;\n+};\n+\n+static struct MonitorGlobal mon_global;\n+\n /* QMP checker flags */\n #define QMP_ACCEPT_UNKNOWNS 1\n \n@@ -4043,12 +4051,32 @@ static void sortcmdlist(void)\n qsort((void *)info_cmds, array_num, elem_size, compare_mon_cmd);\n }\n \n+static void *monitor_io_thread(void *data)\n+{\n+ rcu_register_thread();\n+\n+ g_main_loop_run(mon_global.mon_loop);\n+\n+ rcu_unregister_thread();\n+\n+ return NULL;\n+}\n+\n+static void monitor_io_thread_init(void)\n+{\n+ mon_global.mon_context = g_main_context_new();\n+ mon_global.mon_loop = g_main_loop_new(mon_global.mon_context, TRUE);\n+ qemu_thread_create(&mon_global.mon_io_thread, \"mon-io-thr\",\n+ monitor_io_thread, NULL, QEMU_THREAD_JOINABLE);\n+}\n+\n void monitor_init_globals(void)\n {\n monitor_init_qmp_commands();\n monitor_qapi_event_init();\n sortcmdlist();\n qemu_mutex_init(&monitor_lock);\n+ monitor_io_thread_init();\n }\n \n /* These functions just adapt the readline interface in a typesafe way. We\n@@ -4122,6 +4150,25 @@ void monitor_init(Chardev *chr, int flags)\n qemu_mutex_unlock(&monitor_lock);\n }\n \n+static void monitor_io_thread_destroy(void)\n+{\n+ /* Notify the monitor IO thread to quit. */\n+ g_main_loop_quit(mon_global.mon_loop);\n+ /*\n+ * Make sure the context will get the quit message since it's in\n+ * another thread. Without this, it may not be able to respond to\n+ * the quit message immediately.\n+ */\n+ g_main_context_wakeup(mon_global.mon_context);\n+ qemu_thread_join(&mon_global.mon_io_thread);\n+\n+ g_main_loop_unref(mon_global.mon_loop);\n+ mon_global.mon_loop = NULL;\n+\n+ g_main_context_unref(mon_global.mon_context);\n+ mon_global.mon_context = NULL;\n+}\n+\n void monitor_cleanup(void)\n {\n Monitor *mon, *next;\n@@ -4133,6 +4180,8 @@ void monitor_cleanup(void)\n g_free(mon);\n }\n qemu_mutex_unlock(&monitor_lock);\n+\n+ monitor_io_thread_destroy();\n }\n \n QemuOptsList qemu_mon_opts = {\n","prefixes":["RFC","08/15"]}