{"id":813726,"url":"http://patchwork.ozlabs.org/api/patches/813726/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-5-git-send-email-peterx@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505375436-28439-5-git-send-email-peterx@redhat.com>","list_archive_url":null,"date":"2017-09-14T07:50:25","name":"[RFC,04/15] monitor: move skip_flush into monitor_data_init","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"823183760677e3782a2179054fc862602f650578","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/?format=json","name":"Peter Xu","email":"peterx@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505375436-28439-5-git-send-email-peterx@redhat.com/mbox/","series":[{"id":3043,"url":"http://patchwork.ozlabs.org/api/series/3043/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3043","date":"2017-09-14T07:50:21","name":"QMP: out-of-band (OOB) execution support","version":1,"mbox":"http://patchwork.ozlabs.org/series/3043/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813726/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813726/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9m55zQRz9sRm\n\tfor ;\n\tThu, 14 Sep 2017 17:54:29 +1000 (AEST)","from localhost ([::1]:46194 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsOyh-0000gW-QF\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 03:54:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51855)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsOvd-0006N0-J0\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsOvc-0006pO-SW\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:17 -0400","from mx1.redhat.com ([209.132.183.28]:39544)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsOvc-0006of-Ld\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 03:51:16 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A8998883BC;\n\tThu, 14 Sep 2017 07:51:15 +0000 (UTC)","from pxdev.xzpeter.org.com (dhcp-15-224.nay.redhat.com\n\t[10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 91F9E619B8;\n\tThu, 14 Sep 2017 07:51:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A8998883BC","From":"Peter Xu ","To":"qemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 15:50:25 +0800","Message-Id":"<1505375436-28439-5-git-send-email-peterx@redhat.com>","In-Reply-To":"<1505375436-28439-1-git-send-email-peterx@redhat.com>","References":"<1505375436-28439-1-git-send-email-peterx@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 14 Sep 2017 07:51:15 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [RFC 04/15] monitor: move skip_flush into\n\tmonitor_data_init","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Fam Zheng , Juan\n\tQuintela , Markus Armbruster ,\n\tpeterx@redhat.com, mdroth@linux.vnet.ibm.com,\n\tStefan Hajnoczi , =?utf-8?q?Marc-Andr=C3=A9_Lure?=\n\t=?utf-8?q?au?= ,\n\tPaolo Bonzini , \"Dr . David Alan Gilbert\"\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"It's part of the data init. Collect it.\n\nReviewed-by: Dr. David Alan Gilbert \nSigned-off-by: Peter Xu \n---\n monitor.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/monitor.c b/monitor.c\nindex 9239f7a..8b32519 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -568,13 +568,14 @@ static void monitor_qapi_event_init(void)\n \n static void handle_hmp_command(Monitor *mon, const char *cmdline);\n \n-static void monitor_data_init(Monitor *mon)\n+static void monitor_data_init(Monitor *mon, bool skip_flush)\n {\n memset(mon, 0, sizeof(Monitor));\n qemu_mutex_init(&mon->out_lock);\n mon->outbuf = qstring_new();\n /* Use *mon_cmds by default. */\n mon->cmd_table = mon_cmds;\n+ mon->skip_flush = skip_flush;\n }\n \n static void monitor_data_destroy(Monitor *mon)\n@@ -594,8 +595,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index,\n char *output = NULL;\n Monitor *old_mon, hmp;\n \n- monitor_data_init(&hmp);\n- hmp.skip_flush = true;\n+ monitor_data_init(&hmp, true);\n \n old_mon = cur_mon;\n cur_mon = &hmp;\n@@ -4098,7 +4098,7 @@ void monitor_init(Chardev *chr, int flags)\n }\n \n mon = g_malloc(sizeof(*mon));\n- monitor_data_init(mon);\n+ monitor_data_init(mon, false);\n \n qemu_chr_fe_init(&mon->chr, chr, &error_abort);\n mon->flags = flags;\n","prefixes":["RFC","04/15"]}