{"id":813657,"url":"http://patchwork.ozlabs.org/api/patches/813657/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170913220546.19560-14-robdclark@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913220546.19560-14-robdclark@gmail.com>","list_archive_url":null,"date":"2017-09-13T22:05:36","name":"[U-Boot,v3,13/21] efi_loader: make pool allocations cacheline aligned","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d3dca99e9c2fa790c1593c4cacefc927543933c9","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/?format=json","name":"Rob Clark","email":"robdclark@gmail.com"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170913220546.19560-14-robdclark@gmail.com/mbox/","series":[{"id":2990,"url":"http://patchwork.ozlabs.org/api/series/2990/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=2990","date":"2017-09-13T22:05:23","name":"efi_loader: enough UEFI for standard distro boot","version":3,"mbox":"http://patchwork.ozlabs.org/series/2990/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813657/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813657/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hxw4xxlj\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsx1X3zRXz9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 08:20:16 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 458B8C22743; Wed, 13 Sep 2017 22:10:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A2880C22615;\n\tWed, 13 Sep 2017 22:08:22 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3E512C2259E; Wed, 13 Sep 2017 22:06:36 +0000 (UTC)","from mail-qk0-f195.google.com (mail-qk0-f195.google.com\n\t[209.85.220.195])\n\tby lists.denx.de (Postfix) with ESMTPS id 9DD22C224BA\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 22:06:32 +0000 (UTC)","by mail-qk0-f195.google.com with SMTP id o77so945925qke.2\n\tfor <u-boot@lists.denx.de>; Wed, 13 Sep 2017 15:06:32 -0700 (PDT)","from localhost ([2601:184:4780:aac0:25f8:dd96:a084:785a])\n\tby smtp.gmail.com with ESMTPSA id\n\td42sm10355596qta.17.2017.09.13.15.06.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Sep 2017 15:06:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=rRpS4m7+k9Kgg68zb96oaEj5ZZmnh1UimVhSWh7Vh34=;\n\tb=hxw4xxljTkg940TVv2ZZ3+y6wt1DaUfzgDWTXj220EU8mTgT3F0OSDi8s6pOcpLGCf\n\tX38pzjVVXLWL/vyVN3oaOQmMva08u4ONR1VdpLKJm8deHEwLsw9UhMPK2vHDiFrhP1IS\n\tMdXrvLZ+fWjYJHoQHt59tqLGpRiRGmfqTn+X5CnQl4RDwt5a1/c4u28KFwvESPOMI4hB\n\tVlryONh9tN/tmPelDQ6CElYorR4AR2ysoeb21eFbqOmR8CqDzJtE5qxlqmvdVRPFgr3R\n\tC1xC0UFuHDPY8m+belEFqlqXX8m7HC/44OxAzQJepjdZJX1zSxhkX5wPqJOFnlyG0Rgv\n\t8HZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=rRpS4m7+k9Kgg68zb96oaEj5ZZmnh1UimVhSWh7Vh34=;\n\tb=Sl+aLImgiVPIlutbwpBriMFL6vtk7bRUSYhn2E0h919aUselYZtOXvGM1ISwoJpZI4\n\tqZeT6nTvtTTgdvTVsgzrCpnsX/MJod8sBGf98Ns36bQji0GhAdAareG4Es4dNJrEGHNq\n\tXj9+nPDQc3wY8EM1wboGGVHkc0ZuwexycdcYUIkWIzuJwOxrW14Oz30WRABjMKcwqnBL\n\tI1f7M/8+qw5vDMq+RcNALl3xy6EoqJHcfb2mfGb3Z2tfkQAPkgegaKR3rRx3ocJieBct\n\t8Gsh1GEerg22or4BgrMneNOXc50haWt0SBQ/0yFfzj6jW2zt6dsYEBDWBaligz8vm35p\n\tIuEg==","X-Gm-Message-State":"AHPjjUizqGnClUma2qRdQKR89YtD95OJhETNtMz350iBlBCUCWgStiFY\n\tEJH3x8zVpIjJ9TQV//A=","X-Google-Smtp-Source":"AOwi7QDMwpDESRcxWivvO7MTRHpaeS6YLTDiFHq97PeC0/yVEex9CCKlIMNwCyhOznGF500SGyqBLA==","X-Received":"by 10.55.209.16 with SMTP id s16mr32586qki.46.1505340391356;\n\tWed, 13 Sep 2017 15:06:31 -0700 (PDT)","From":"Rob Clark <robdclark@gmail.com>","To":"U-Boot Mailing List <u-boot@lists.denx.de>","Date":"Wed, 13 Sep 2017 18:05:36 -0400","Message-Id":"<20170913220546.19560-14-robdclark@gmail.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170913220546.19560-1-robdclark@gmail.com>","References":"<20170913220546.19560-1-robdclark@gmail.com>","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"[U-Boot] [PATCH v3 13/21] efi_loader: make pool allocations\n\tcacheline aligned","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"This avoids printf() spam about file reads (such as loading an image)\ninto unaligned buffers (and the associated memcpy()).  And generally\nseems like a good idea.\n\nSigned-off-by: Rob Clark <robdclark@gmail.com>\n---\n lib/efi_loader/efi_memory.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\nindex 9e079f1fa3..1f0b9d0449 100644\n--- a/lib/efi_loader/efi_memory.c\n+++ b/lib/efi_loader/efi_memory.c\n@@ -43,7 +43,7 @@ void *efi_bounce_buffer;\n  */\n struct efi_pool_allocation {\n \tu64 num_pages;\n-\tchar data[];\n+\tchar data[] __attribute__((aligned(ARCH_DMA_MINALIGN)));\n };\n \n /*\n@@ -356,7 +356,8 @@ efi_status_t efi_allocate_pool(int pool_type, unsigned long size,\n {\n \tefi_status_t r;\n \tefi_physical_addr_t t;\n-\tu64 num_pages = (size + sizeof(u64) + EFI_PAGE_MASK) >> EFI_PAGE_SHIFT;\n+\tu64 num_pages = (size + sizeof(struct efi_pool_allocation) +\n+\t\t\t EFI_PAGE_MASK) >> EFI_PAGE_SHIFT;\n \n \tif (size == 0) {\n \t\t*buffer = NULL;\n","prefixes":["U-Boot","v3","13/21"]}