{"id":813548,"url":"http://patchwork.ozlabs.org/api/patches/813548/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913172941.5470-1-cohuck@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913172941.5470-1-cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T17:29:41","name":"[v2] accel: default to an actually available accelerator","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e6365face775df196405c22196797e4b9f54b056","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/?format=json","name":"Cornelia Huck","email":"cohuck@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913172941.5470-1-cohuck@redhat.com/mbox/","series":[{"id":2955,"url":"http://patchwork.ozlabs.org/api/series/2955/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2955","date":"2017-09-13T17:29:41","name":"[v2] accel: default to an actually available accelerator","version":2,"mbox":"http://patchwork.ozlabs.org/series/2955/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813548/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813548/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xspZq0JPNz9sNV\n\tfor ;\n\tThu, 14 Sep 2017 03:30:11 +1000 (AEST)","from localhost ([::1]:43823 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsBUH-0007r3-7F\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 13:30:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41318)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsBTx-0007qh-KT\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:29:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsBTu-0002jG-89\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:29:49 -0400","from mx1.redhat.com ([209.132.183.28]:45716)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsBTu-0002hM-0Z\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:29:46 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 032EF85542;\n\tWed, 13 Sep 2017 17:29:45 +0000 (UTC)","from localhost (ovpn-117-3.ams2.redhat.com [10.36.117.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5EDEB4DA65;\n\tWed, 13 Sep 2017 17:29:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 032EF85542","From":"Cornelia Huck ","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 19:29:41 +0200","Message-Id":"<20170913172941.5470-1-cohuck@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 17:29:45 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2] accel: default to an actually available\n\taccelerator","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lvivier@redhat.com, kwolf@redhat.com, thuth@redhat.com,\n\tpeter.maydell@linaro.org, Cornelia Huck ,\n\trichard.henderson@linaro.org, mreitz@redhat.com, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"configure_accelerator() falls back to tcg if no accelerator has\nbeen specified. Formerly, we could be sure that tcg is always\navailable; however, with --disable-tcg, this is not longer true,\nand you are not able to start qemu without explicitly specifying\nanother accelerator on those builds.\n\nInstead, choose an accelerator in the order tcg->kvm->hax.\n\nSigned-off-by: Cornelia Huck \n---\nRFC->v2:\n- drop xen from the list of fallbacks\n- use comma-delimited list of accelerators (much easier)\n- changed one place in qemu-options.hx that had been missed\n---\n accel/accel.c | 3 +--\n qemu-options.hx | 8 +++++---\n 2 files changed, 6 insertions(+), 5 deletions(-)","diff":"diff --git a/accel/accel.c b/accel/accel.c\nindex 8ae40e1e13..e8a3121d06 100644\n--- a/accel/accel.c\n+++ b/accel/accel.c\n@@ -79,8 +79,7 @@ void configure_accelerator(MachineState *ms)\n \n accel = qemu_opt_get(qemu_get_machine_opts(), \"accel\");\n if (accel == NULL) {\n- /* Use the default \"accelerator\", tcg */\n- accel = \"tcg\";\n+ accel = \"tcg:kvm:hax\";\n }\n \n p = accel;\ndiff --git a/qemu-options.hx b/qemu-options.hx\nindex 9f6e2adfff..2ff88389e0 100644\n--- a/qemu-options.hx\n+++ b/qemu-options.hx\n@@ -31,7 +31,7 @@ DEF(\"machine\", HAS_ARG, QEMU_OPTION_machine, \\\n \"-machine [type=]name[,prop[=value][,...]]\\n\"\n \" selects emulated machine ('-machine help' for list)\\n\"\n \" property accel=accel1[:accel2[:...]] selects accelerator\\n\"\n- \" supported accelerators are kvm, xen, hax or tcg (default: tcg)\\n\"\n+ \" supported accelerators are kvm, xen, hax or tcg (default: tcg:kvm:hax)\\n\"\n \" kernel_irqchip=on|off|split controls accelerated irqchip support (default=off)\\n\"\n \" vmport=on|off|auto controls emulation of vmport (default: auto)\\n\"\n \" kvm_shadow_mem=size of KVM shadow MMU in bytes\\n\"\n@@ -66,7 +66,8 @@ Supported machine properties are:\n @table @option\n @item accel=@var{accels1}[:@var{accels2}[:...]]\n This is used to enable an accelerator. Depending on the target architecture,\n-kvm, xen, hax or tcg can be available. By default, tcg is used. If there is\n+kvm, xen, hax or tcg can be available. By default, the first one available\n+out of tcg, kvm, hax (in that order) is used. If there is\n more than one accelerator specified, the next one is used if the previous one\n fails to initialize.\n @item kernel_irqchip=on|off\n@@ -126,7 +127,8 @@ STEXI\n @item -accel @var{name}[,prop=@var{value}[,...]]\n @findex -accel\n This is used to enable an accelerator. Depending on the target architecture,\n-kvm, xen, hax or tcg can be available. By default, tcg is used. If there is\n+kvm, xen, hax or tcg can be available. By default, the first one available\n+out of tcg, kvm, hax (in that order) is used. If there is\n more than one accelerator specified, the next one is used if the previous one\n fails to initialize.\n @table @option\n","prefixes":["v2"]}