{"id":813527,"url":"http://patchwork.ozlabs.org/api/patches/813527/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913160333.23622-23-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913160333.23622-23-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-13T16:03:32","name":"[v4,22/23] block: Relax bdrv_aligned_preadv() assertion","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"34fd6b81e0a09520ec28f6fb6e9f28ec28468640","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913160333.23622-23-eblake@redhat.com/mbox/","series":[{"id":2944,"url":"http://patchwork.ozlabs.org/api/series/2944/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2944","date":"2017-09-13T16:03:10","name":"make bdrv_get_block_status byte-based","version":4,"mbox":"http://patchwork.ozlabs.org/series/2944/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813527/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813527/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsn4D45R5z9s7M\n\tfor ;\n\tThu, 14 Sep 2017 02:22:04 +1000 (AEST)","from localhost ([::1]:43444 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsAQM-0003Ha-DJ\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 12:22:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46797)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsAB1-0003cs-9P\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:06:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsAAv-0007GA-GM\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:06:11 -0400","from mx1.redhat.com ([209.132.183.28]:46450)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsAAq-0007Ck-2W; Wed, 13 Sep 2017 12:06:00 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2B240EEACD;\n\tWed, 13 Sep 2017 16:05:59 +0000 (UTC)","from red.redhat.com (ovpn-120-201.rdu2.redhat.com [10.10.120.201])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3CAEC69FAE;\n\tWed, 13 Sep 2017 16:05:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2B240EEACD","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 11:03:32 -0500","Message-Id":"<20170913160333.23622-23-eblake@redhat.com>","In-Reply-To":"<20170913160333.23622-1-eblake@redhat.com>","References":"<20170913160333.23622-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 13 Sep 2017 16:05:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v4 22/23] block: Relax bdrv_aligned_preadv()\n\tassertion","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tMax Reitz ,\n\tStefan Hajnoczi , jsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Now that bdrv_is_allocated accepts non-aligned inputs, we can\nremove the TODO added in commit d6a644bb.\n\nSigned-off-by: Eric Blake \n\n---\nv3: new patch [Kevin]\n---\n block/io.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)","diff":"diff --git a/block/io.c b/block/io.c\nindex c78201b8eb..e0f9bca7e2 100644\n--- a/block/io.c\n+++ b/block/io.c\n@@ -1055,18 +1055,14 @@ static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child,\n }\n\n if (flags & BDRV_REQ_COPY_ON_READ) {\n- /* TODO: Simplify further once bdrv_is_allocated no longer\n- * requires sector alignment */\n- int64_t start = QEMU_ALIGN_DOWN(offset, BDRV_SECTOR_SIZE);\n- int64_t end = QEMU_ALIGN_UP(offset + bytes, BDRV_SECTOR_SIZE);\n int64_t pnum;\n\n- ret = bdrv_is_allocated(bs, start, end - start, &pnum);\n+ ret = bdrv_is_allocated(bs, offset, bytes, &pnum);\n if (ret < 0) {\n goto out;\n }\n\n- if (!ret || pnum != end - start) {\n+ if (!ret || pnum != bytes) {\n ret = bdrv_co_do_copy_on_readv(child, offset, bytes, qiov);\n goto out;\n }\n","prefixes":["v4","22/23"]}