{"id":813445,"url":"http://patchwork.ozlabs.org/api/patches/813445/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-17-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913132417.24384-17-david@redhat.com>","list_archive_url":null,"date":"2017-09-13T13:24:11","name":"[v5,16/22] s390x: allow cpu hotplug via device_add","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f759c76a92525656dfd457c25e419486e3596668","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-17-david@redhat.com/mbox/","series":[{"id":2916,"url":"http://patchwork.ozlabs.org/api/series/2916/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2916","date":"2017-09-13T13:23:55","name":"s390x cleanups and CPU hotplug via device_add","version":5,"mbox":"http://patchwork.ozlabs.org/series/2916/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813445/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813445/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjNY0MsWz9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 23:35:56 +1000 (AEST)","from localhost ([::1]:42570 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7pZ-0007R1-Lm\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:35:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39456)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds7fm-0005vs-Dd\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds7fj-0003N4-E3\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:46 -0400","from mx1.redhat.com ([209.132.183.28]:47582)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1ds7fi-0003L9-TK\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:43 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EE1DBC04B310;\n\tWed, 13 Sep 2017 13:25:41 +0000 (UTC)","from t460s.redhat.com (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 097545C6D2;\n\tWed, 13 Sep 2017 13:25:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EE1DBC04B310","From":"David Hildenbrand <david@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 15:24:11 +0200","Message-Id":"<20170913132417.24384-17-david@redhat.com>","In-Reply-To":"<20170913132417.24384-1-david@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 13:25:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via\n\tdevice_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tIgor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"E.g. the following now works:\n    device_add host-s390-cpu,id=cpu1,core-id=1\n\nThe system will perform the same checks as when using cpu_add:\n- If the core_id is already in use\n- If the next sequential core_id isn't used\n- If core-id >= max_cpu is specified\n\nIn addition, mixed CPU models are checked. E.g. if starting with\n-cpu host and trying to hotplug \"qemu-s390-cpu\":\n    \"Mixed CPU models are not supported on s390x.\"\n\nReviewed-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/cpu.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex 8c1c644057..5724dffb88 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -467,6 +467,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)\n     scc->parent_realize = dc->realize;\n     dc->realize = s390_cpu_realizefn;\n     dc->props = s390x_cpu_properties;\n+    dc->user_creatable = true;\n \n     scc->parent_reset = cc->reset;\n #if !defined(CONFIG_USER_ONLY)\n","prefixes":["v5","16/22"]}