{"id":813444,"url":"http://patchwork.ozlabs.org/api/patches/813444/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-23-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913132417.24384-23-david@redhat.com>","list_archive_url":null,"date":"2017-09-13T13:24:17","name":"[v5,22/22] s390x: allow CPU hotplug in random core-id order","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0a4a46491fbcbf899dc790dbaefca38881a1f9a6","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-23-david@redhat.com/mbox/","series":[{"id":2916,"url":"http://patchwork.ozlabs.org/api/series/2916/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2916","date":"2017-09-13T13:23:55","name":"s390x cleanups and CPU hotplug via device_add","version":5,"mbox":"http://patchwork.ozlabs.org/series/2916/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813444/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813444/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjM216bNz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 23:34:38 +1000 (AEST)","from localhost ([::1]:42558 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds7oK-000608-6g\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:34:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39647)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds7gD-0006Nz-BE\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:26:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds7g7-0003cq-F2\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:26:13 -0400","from mx1.redhat.com ([209.132.183.28]:45128)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds7g7-0003bB-96\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:26:07 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 595CD4E341;\n\tWed, 13 Sep 2017 13:26:06 +0000 (UTC)","from t460s.redhat.com (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3E67A69FB6;\n\tWed, 13 Sep 2017 13:26:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 595CD4E341","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 15:24:17 +0200","Message-Id":"<20170913132417.24384-23-david@redhat.com>","In-Reply-To":"<20170913132417.24384-1-david@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 13:26:06 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v5 22/22] s390x: allow CPU hotplug in random\n\tcore-id order","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tIgor Mammedov , Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"SCLP correctly indicates the core-id aka. CPU address for each available\nCPU.\n\nAs the core-id corresponds to cpu_index, also a newly created kvm vcpu\ngets assigned this core-id as vcpu id. So SIGP in the kernel works\ncorrectly (it uses the vcpu id to lookup the correct CPU).\n\nSo there should be nothing hindering us from hotplugging CPUs in random\ncore-id order.\n\nThis now makes sure that the output from \"query-hotpluggable-cpus\"\nis completely true. Until now, a specific order is implicit. Performance\nvice, hotplugging CPUs in non-sequential order might not be the best thing\nto do, as VCPU lookup inside KVM might be a little slower. But that\ndoesn't hinder us from supporting it.\n\nnext_core_id is now used by linux user only.\n\nSigned-off-by: David Hildenbrand \n---\n target/s390x/cpu.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\nindex 5724dffb88..34538c3ab9 100644\n--- a/target/s390x/cpu.c\n+++ b/target/s390x/cpu.c\n@@ -199,6 +199,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n #else\n /* implicitly set for linux-user only */\n cpu->env.core_id = scc->next_core_id;\n+ scc->next_core_id++;\n #endif\n \n if (cpu_exists(cpu->env.core_id)) {\n@@ -206,12 +207,6 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n \", it already exists\", cpu->env.core_id);\n goto out;\n }\n- if (cpu->env.core_id != scc->next_core_id) {\n- error_setg(&err, \"Unable to add CPU with core-id: %\" PRIu32\n- \", the next available core-id is %\" PRIu32, cpu->env.core_id,\n- scc->next_core_id);\n- goto out;\n- }\n \n /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */\n cs->cpu_index = env->core_id;\n@@ -219,7 +214,6 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n if (err != NULL) {\n goto out;\n }\n- scc->next_core_id++;\n \n #if !defined(CONFIG_USER_ONLY)\n qemu_register_reset(s390_cpu_machine_reset_cb, cpu);\n","prefixes":["v5","22/22"]}