{"id":813435,"url":"http://patchwork.ozlabs.org/api/patches/813435/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-9-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913132417.24384-9-david@redhat.com>","list_archive_url":null,"date":"2017-09-13T13:24:03","name":"[v5,08/22] s390x: move sclp_service_call() to sclp.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e1f1bfa3f97259bb324acd31264b96c0c7217538","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913132417.24384-9-david@redhat.com/mbox/","series":[{"id":2916,"url":"http://patchwork.ozlabs.org/api/series/2916/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2916","date":"2017-09-13T13:23:55","name":"s390x cleanups and CPU hotplug via device_add","version":5,"mbox":"http://patchwork.ozlabs.org/series/2916/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813435/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813435/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjCT1gXLz9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 23:28:05 +1000 (AEST)","from localhost ([::1]:42530 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds7hz-0007bs-7x\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 09:28:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39086)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds7fI-0005Qq-Qn\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1ds7fE-0002re-QQ\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:16 -0400","from mx1.redhat.com ([209.132.183.28]:43024)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1ds7fE-0002qx-K5\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:25:12 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A80354E4F3;\n\tWed, 13 Sep 2017 13:25:11 +0000 (UTC)","from t460s.redhat.com (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C8CAB69FB6;\n\tWed, 13 Sep 2017 13:25:08 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A80354E4F3","From":"David Hildenbrand <david@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 15:24:03 +0200","Message-Id":"<20170913132417.24384-9-david@redhat.com>","In-Reply-To":"<20170913132417.24384-1-david@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 13:25:11 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call() to\n\tsclp.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tIgor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Implemented in sclp.c, so let's move it to the right include file.\nFix up one include. Do a forward declaration of struct CPUS390XState to\nfix the two sclp consoles complaining.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n include/hw/s390x/sclp.h    | 2 ++\n target/s390x/cpu.h         | 1 -\n target/s390x/misc_helper.c | 1 +\n 3 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h\nindex a72d096081..847ff32f85 100644\n--- a/include/hw/s390x/sclp.h\n+++ b/include/hw/s390x/sclp.h\n@@ -16,6 +16,7 @@\n \n #include \"hw/sysbus.h\"\n #include \"hw/qdev.h\"\n+#include \"target/s390x/cpu-qom.h\"\n \n #define SCLP_CMD_CODE_MASK                      0xffff00ff\n \n@@ -242,5 +243,6 @@ sclpMemoryHotplugDev *init_sclp_memory_hotplug_dev(void);\n sclpMemoryHotplugDev *get_sclp_memory_hotplug_dev(void);\n void sclp_service_interrupt(uint32_t sccb);\n void raise_irq_cpu_hotplug(void);\n+int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n \n #endif\ndiff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\nindex 4a0a59dfbc..5295bd3c66 100644\n--- a/target/s390x/cpu.h\n+++ b/target/s390x/cpu.h\n@@ -722,6 +722,5 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,\n \n /* outside of target/s390x/ */\n S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);\n-int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n \n #endif\ndiff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\nindex b142db71c6..8b07535b02 100644\n--- a/target/s390x/misc_helper.c\n+++ b/target/s390x/misc_helper.c\n@@ -35,6 +35,7 @@\n #include \"sysemu/sysemu.h\"\n #include \"hw/s390x/ebcdic.h\"\n #include \"hw/s390x/s390-virtio-hcall.h\"\n+#include \"hw/s390x/sclp.h\"\n #endif\n \n /* #define DEBUG_HELPER */\n","prefixes":["v5","08/22"]}