{"id":813354,"url":"http://patchwork.ozlabs.org/api/patches/813354/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-4-quintela@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170913105953.13760-4-quintela@redhat.com>","list_archive_url":null,"date":"2017-09-13T10:59:36","name":"[v8,03/20] migration: Add comments to channel functions","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8ec7c88a625f4393408b94920c4fb9b146090afe","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/?format=json","name":"Juan Quintela","email":"quintela@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170913105953.13760-4-quintela@redhat.com/mbox/","series":[{"id":2885,"url":"http://patchwork.ozlabs.org/api/series/2885/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2885","date":"2017-09-13T10:59:33","name":"Multifd","version":8,"mbox":"http://patchwork.ozlabs.org/series/2885/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813354/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813354/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsf282VcLz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 21:04:48 +1000 (AEST)","from localhost ([::1]:41564 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds5TK-00016T-DM\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:04:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41884)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5Ov-00067n-Mk\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1ds5Oq-0006Dy-5e\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:13 -0400","from mx1.redhat.com ([209.132.183.28]:38386)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1ds5Oq-0006Bf-0o\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:00:08 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0629CC058EAF\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 11:00:07 +0000 (UTC)","from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5DC605191B;\n\tWed, 13 Sep 2017 11:00:01 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0629CC058EAF","From":"Juan Quintela <quintela@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Wed, 13 Sep 2017 12:59:36 +0200","Message-Id":"<20170913105953.13760-4-quintela@redhat.com>","In-Reply-To":"<20170913105953.13760-1-quintela@redhat.com>","References":"<20170913105953.13760-1-quintela@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 13 Sep 2017 11:00:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v8 03/20] migration: Add comments to channel\n\tfunctions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Signed-off-by: Juan Quintela <quintela@redhat.com>\nReviewed-by: Daniel P. Berrange <berrange@redhat.com>\n---\n migration/channel.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)","diff":"diff --git a/migration/channel.c b/migration/channel.c\nindex edceebdb7b..70ec7ea3b7 100644\n--- a/migration/channel.c\n+++ b/migration/channel.c\n@@ -19,6 +19,14 @@\n #include \"qapi/error.h\"\n #include \"io/channel-tls.h\"\n \n+/**\n+ * @migration_channel_process_incoming - Create new incoming migration channel\n+ *\n+ * Notice that TLS is special.  For it we listen in a listener socket,\n+ * and then create a new client socket from the TLS library.\n+ *\n+ * @ioc: Channel to which we are connecting\n+ */\n void migration_channel_process_incoming(QIOChannel *ioc)\n {\n     MigrationState *s = migrate_get_current();\n@@ -41,6 +49,13 @@ void migration_channel_process_incoming(QIOChannel *ioc)\n }\n \n \n+/**\n+ * @migration_channel_connect - Create new outgoing migration channel\n+ *\n+ * @s: Current migration state\n+ * @ioc: Channel to which we are connecting\n+ * @hostname: Where we want to connect\n+ */\n void migration_channel_connect(MigrationState *s,\n                                QIOChannel *ioc,\n                                const char *hostname)\n","prefixes":["v8","03/20"]}