{"id":813027,"url":"http://patchwork.ozlabs.org/api/patches/813027/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505245749-3402-1-git-send-email-azhou@ovn.org/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","list_archive_url":null,"date":"2017-09-12T19:49:03","name":"[ovs-dev,merge,native,tunneling,and,port,1/7] ofproto-dpif: Unfreeze within clone","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"01efb2ae62a7f42cb0c7d046e8e2a7e43d6ee33d","submitter":{"id":67699,"url":"http://patchwork.ozlabs.org/api/people/67699/?format=json","name":"Andy Zhou","email":"azhou@ovn.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505245749-3402-1-git-send-email-azhou@ovn.org/mbox/","series":[{"id":2760,"url":"http://patchwork.ozlabs.org/api/series/2760/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2760","date":"2017-09-12T19:49:03","name":"[ovs-dev,merge,native,tunneling,and,port,1/7] ofproto-dpif: Unfreeze within clone","version":1,"mbox":"http://patchwork.ozlabs.org/series/2760/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813027/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813027/checks/","tags":{},"related":[],"headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsFkh5rknz9sPm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 05:50:03 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 22309A6E;\n\tTue, 12 Sep 2017 19:50:00 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B611A8EE\n\tfor <dev@openvswitch.org>; Tue, 12 Sep 2017 19:49:58 +0000 (UTC)","from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5945B159\n\tfor <dev@openvswitch.org>; Tue, 12 Sep 2017 19:49:58 +0000 (UTC)","by mail-pf0-f193.google.com with SMTP id q76so6599617pfq.5\n\tfor <dev@openvswitch.org>; Tue, 12 Sep 2017 12:49:58 -0700 (PDT)","from centos.eng.vmware.com ([208.91.1.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tj13sm23739951pfk.107.2017.09.12.12.49.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 12:49:56 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id\n\t:content-transfer-encoding;\n\tbh=pbGCKlZzCM7kP2hmglhTVS/8MNKF/nLC3OXsVHaOEb0=;\n\tb=VwKD3CaN4e1V4R9FNXcjhF4cAt/P+lt0/kxw9zN5pe4dDIeTcPtNnVIntztq2Sga2b\n\tz7Sj36wUu4OwP+nmysTCPZHge2/3Eegby2pJMDcUCvtH0k3zKtLaj1M3VZRsTQT8BE8f\n\tOP5wNakgXjg7FmneSOgZXaXuRmssBcMUOAuK2iCeNlvl2wYIINq1GWviLeWrvmkoa6q6\n\t3SV9TRXPQ9jriejlLDSx9sAaMDR294NM5Xw3sZj42L1YR4ihEZnyOGvx6W+i90+Srnnx\n\tddc2ssJvWaSp0p0Oezr6pnPU+1fAMS4zPXN8jVx8QSFQnh04/6nUsvkZ02L0ndzIZzBF\n\tSzJQ==","X-Gm-Message-State":"AHPjjUj3fR+1DMxL/vl2wi1q8zUTjGSA2ACwp62HZz77Doj1753rDcJr\n\tNKK9lFoqQOlqYMWY","X-Google-Smtp-Source":"ADKCNb61l/7w0dJN0Bsm7P9GQjmCFH46PqR+mXj7uQEEYT47bnScwgv29GRlYfjGQp9u3m5rSOfsnA==","X-Received":"by 10.98.32.92 with SMTP id g89mr16061198pfg.285.1505245797804; \n\tTue, 12 Sep 2017 12:49:57 -0700 (PDT)","From":"Andy Zhou <azhou@ovn.org>","To":"dev@openvswitch.org","Date":"Tue, 12 Sep 2017 12:49:03 -0700","Message-Id":"<1505245749-3402-1-git-send-email-azhou@ovn.org>","X-Mailer":"git-send-email 1.8.3.1","X-Spam-Status":"No, score=0.5 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif:\n\tUnfreeze within clone","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"When translating actions within open flow clone, actions generated\nby finish_freezeing() should also be enclosed within the datapath\nclone netlink encoding.\n\nSigned-off-by: Andy Zhou <azhou@ovn.org>\n---\n ofproto/ofproto-dpif-xlate.c | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\nindex 9e1f837cb23e..e5ad832d7c47 100644\n--- a/ofproto/ofproto-dpif-xlate.c\n+++ b/ofproto/ofproto-dpif-xlate.c\n@@ -5353,6 +5353,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n     if (reversible_actions(oc->actions, oc_actions_len)) {\n         old_flow = ctx->xin->flow;\n         do_xlate_actions(oc->actions, oc_actions_len, ctx);\n+        if (ctx->freezing) {\n+            finish_freezing(ctx);\n+        }\n         goto xlate_done;\n     }\n \n@@ -5372,6 +5375,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n         offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);\n         ac_offset = ctx->odp_actions->size;\n         do_xlate_actions(oc->actions, oc_actions_len, ctx);\n+        if (ctx->freezing) {\n+            finish_freezing(ctx);\n+        }\n         nl_msg_end_non_empty_nested(ctx->odp_actions, offset);\n         goto dp_clone_done;\n     }\n@@ -5382,6 +5388,9 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n         ac_offset = nl_msg_start_nested(ctx->odp_actions,\n                                         OVS_SAMPLE_ATTR_ACTIONS);\n         do_xlate_actions(oc->actions, oc_actions_len, ctx);\n+        if (ctx->freezing) {\n+            finish_freezing(ctx);\n+        }\n         if (nl_msg_end_non_empty_nested(ctx->odp_actions, ac_offset)) {\n             nl_msg_cancel_nested(ctx->odp_actions, offset);\n         } else {\n","prefixes":["ovs-dev","merge","native","tunneling","and","port","1/7"]}