{"id":813008,"url":"http://patchwork.ozlabs.org/api/patches/813008/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505240705-28120-2-git-send-email-bhanuprakash.bodireddy@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505240705-28120-2-git-send-email-bhanuprakash.bodireddy@intel.com>","list_archive_url":null,"date":"2017-09-12T18:25:05","name":"[ovs-dev,2/2] dpif-netdev: Fix comments for pmd_load_cached_ports.","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2a96f2c9e7c7bc53e894a2e8322b7d0124098c56","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/?format=json","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"delegate":{"id":67810,"url":"http://patchwork.ozlabs.org/api/users/67810/?format=json","username":"darball1","first_name":"Darrell","last_name":"Ball","email":"dlu998@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505240705-28120-2-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/","series":[{"id":2755,"url":"http://patchwork.ozlabs.org/api/series/2755/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2755","date":"2017-09-12T18:25:04","name":"[ovs-dev,1/2] conntrack: Use DP_PACKET_BATCH_FOR_EACH macro.","version":1,"mbox":"http://patchwork.ozlabs.org/series/2755/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/813008/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/813008/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsD4Q2PwPz9s81\n\tfor ;\n\tWed, 13 Sep 2017 04:35:18 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 87292AAB;\n\tTue, 12 Sep 2017 18:34:46 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5837B9F0\n\tfor ; Tue, 12 Sep 2017 18:34:44 +0000 (UTC)","from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1AF7C101\n\tfor ; Tue, 12 Sep 2017 18:34:44 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Sep 2017 11:34:43 -0700","from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga006.fm.intel.com with ESMTP; 12 Sep 2017 11:34:43 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,383,1500966000\"; d=\"scan'208\";a=\"151050034\"","From":"Bhanuprakash Bodireddy ","To":"dev@openvswitch.org","Date":"Tue, 12 Sep 2017 19:25:05 +0100","Message-Id":"<1505240705-28120-2-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Mailer":"git-send-email 2.4.11","In-Reply-To":"<1505240705-28120-1-git-send-email-bhanuprakash.bodireddy@intel.com>","References":"<1505240705-28120-1-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 2/2] dpif-netdev: Fix comments for\n\tpmd_load_cached_ports.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Commit 57eebbb4c315 replaces thread local 'pmd->port_cache' with\n'pmd->tnl_port_cache' and 'pmd->send_port_cache' maps. Update the\ncomments accordingly.\n\nFixes: 57eebbb4c315 (\"Don't try to output on a device without txqs\")\nSigned-off-by: Bhanuprakash Bodireddy \n---\n lib/dpif-netdev.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex ca74df8..11d3ab4 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -3933,7 +3933,9 @@ pmd_free_cached_ports(struct dp_netdev_pmd_thread *pmd)\n }\n \n /* Copies ports from 'pmd->tx_ports' (shared with the main thread) to\n- * 'pmd->port_cache' (thread local) */\n+ * thread-local copies. Copy to 'pmd->tnl_port_cache' if it is a tunnel\n+ * device, otherwise to 'pmd->send_port_cache' if the port has atleast\n+ * one txq. */\n static void\n pmd_load_cached_ports(struct dp_netdev_pmd_thread *pmd)\n OVS_REQUIRES(pmd->port_mutex)\n","prefixes":["ovs-dev","2/2"]}