{"id":812953,"url":"http://patchwork.ozlabs.org/api/patches/812953/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170912162710.26215-1-kristian.evensen@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170912162710.26215-1-kristian.evensen@gmail.com>","list_archive_url":null,"date":"2017-09-12T16:27:10","name":"[LEDE-DEV] ramips: Fix D240 mini-PCIe power control GPIOs","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f4bdcef34df6f3954196ed3b9cc8bfee722c7d8b","submitter":{"id":34169,"url":"http://patchwork.ozlabs.org/api/people/34169/?format=json","name":"Kristian Evensen","email":"kristian.evensen@gmail.com"},"delegate":{"id":55824,"url":"http://patchwork.ozlabs.org/api/users/55824/?format=json","username":"mkresin","first_name":"Mathias","last_name":"Kresin","email":"openwrt@kresin.me"},"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170912162710.26215-1-kristian.evensen@gmail.com/mbox/","series":[{"id":2738,"url":"http://patchwork.ozlabs.org/api/series/2738/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/list/?series=2738","date":"2017-09-12T16:27:10","name":"[LEDE-DEV] ramips: Fix D240 mini-PCIe power control GPIOs","version":1,"mbox":"http://patchwork.ozlabs.org/series/2738/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812953/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812953/checks/","tags":{},"related":[],"headers":{"Return-Path":"<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"KiuoXv1b\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dfFdbz0E\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs9Fg3pStz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 02:28:07 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dro2K-0006CQ-OJ; Tue, 12 Sep 2017 16:27:44 +0000","from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dro2G-00069t-Su\n\tfor lede-dev@lists.infradead.org; Tue, 12 Sep 2017 16:27:42 +0000","by mail-lf0-x243.google.com with SMTP id c8so5589353lfe.2\n\tfor <lede-dev@lists.infradead.org>;\n\tTue, 12 Sep 2017 09:27:19 -0700 (PDT)","from localhost.localdomain ([193.213.155.210])\n\tby smtp.gmail.com with ESMTPSA id\n\tg84sm2170912lfl.74.2017.09.12.09.27.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 09:27:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=W/CsMFKisvGhqzubkMpUWbYUXIxTuznY2PL8uEqRUPU=;\n\tb=KiuoXv1bB5BP+5\n\twLXwLQgaf9EkV6K99x6FuNI0Q01TUyj1vgdKaLtOEztOaUUKhwRNiQWjZ1lPRkG36/qvF16Aq4P4p\n\tmaOdwakIwY/YjTTkB0bKr1N1x8A5igZaG8TT9hAHVpPvCX68w6eoHsrOWZud7GwQ0djoJfu/vnQ8f\n\tGhxaYkEcYxIdVGgqfhlSuawA912EdzZ1L/l4r/h385wwokr8v9rfjfkoUzsQApY9ymYa1g5TpbEE4\n\t9wGdiOvX37FOhbTwVzo4Q8iQ+Ayei33k38fxptScTkyS6c5+6QJduLXwFjwRbbQEhgJVOKYp/OHCK\n\tgxawq9IllzGUQY6GDbEQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=MZE+oJPGMPvcvbQHVvezDiH2jQbKoSeV4Lt+xnDjHjE=;\n\tb=dfFdbz0EoZB8nyFI0SeRl02A17UXGkGBEbLcCmuH6FKwLdBaSziTCEzVOvy9H532nG\n\tufpTJ5VDNulVzWE0BYDeiqx0cSGGV+EH+shCEdzrO+QtkvGCr8seUfxHPq2VHB9jH1aH\n\taN7g+gPa75qMi9edox9zYFO15nzjTJ7qXqpjXF56YzkwikEk1R+vx8dj4nuMitMnNClU\n\tQ652nKLAaPa/h6s37OhydME7rtHFAClAFiqgt7z2bWDSrRNNMAJFS6o+hYhRvfGGut1T\n\t1J8fasru+wpNPzB5RE6+Kiv9KDks15K1TSumGuVmBLmO7l4kN574tBg/qKnSBjm4afXp\n\tyInQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=MZE+oJPGMPvcvbQHVvezDiH2jQbKoSeV4Lt+xnDjHjE=;\n\tb=lQpRNDHhCh6PXp0PZo0FwI81brMP5SfaHAasgJIbEP2lXttRNb8GDzvT1WfhgbnJxi\n\tSr3vSY0fVb2INnF5/TmH/q/fwGYnsiHgGzSI+2ykz4QZxNp5JaM48QnQyPlIUGuiQLWC\n\tcoMPzjhHiIusX2YzCYhoUHx721fBGL5fxXfLZlHKeylhHuIl3kVD/7jQ0hJEdrQa8/+B\n\tG1cOmUl4Bqi66XJytyDfA5ayFDyjnAxBsJT/CjTZRsm2CR0M6kRq3a/uooQ99B2GRlLt\n\tRfEcNjjquzVMXv4pZQ5FDiUcGnCn3i4zJvmEgudy73V/JHFOt+2kS4JzmAu5pH8PucMv\n\tJfng==","X-Gm-Message-State":"AHPjjUjWuU4CPYUrF8xZM8F5PTCzPq5CINd5b3HbzHzLAiLCzXPNFfnT\n\tcu/gIqnjbGCL19qM","X-Google-Smtp-Source":"AOwi7QBAVTC3JraeuNw2uQTpdnIXUmtVIkQDnoNyKDoWkFo4mvI0Kj1MyLXTmhXvg5Wg3Crp/7tpNw==","X-Received":"by 10.46.1.72 with SMTP id 69mr4555582ljb.154.1505233638035;\n\tTue, 12 Sep 2017 09:27:18 -0700 (PDT)","From":"Kristian Evensen <kristian.evensen@gmail.com>","To":"lede-dev@lists.infradead.org","Date":"Tue, 12 Sep 2017 18:27:10 +0200","Message-Id":"<20170912162710.26215-1-kristian.evensen@gmail.com>","X-Mailer":"git-send-email 2.11.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_092741_150151_007329AF ","X-CRM114-Status":"UNSURE (   9.56  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:4010:c07:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (kristian.evensen[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH] ramips: Fix D240 mini-PCIe power control GPIOs","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<lede-dev.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/lede-dev/>","List-Post":"<mailto:lede-dev@lists.infradead.org>","List-Help":"<mailto:lede-dev-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>","Cc":"Kristian Evensen <kristian.evensen@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"In commit b11c51916cb9 (\"ramips: Improve Sanlinking D240 config\") I made\na mistake with regards GPIO numbering. And in addition to specifying the\nwrong GPIO for controling the power of one of the mini-PCIe, I recently\ndiscovered that the power of both slots can be controlled.\n\nThis patch specifies the correct GPIO for the left-most mini-PCIe slot\nof the D240 (labeled power_mpcie2 since the slot is attached to SIM2),\nand adds a GPIO that can be used to control the power of the other\nmini-PCIe slot (labeled power_mpcie1).\n\nSigned-off-by: Kristian Evensen <kristian.evensen@gmail.com>\n---\n target/linux/ramips/dts/D240.dts | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/target/linux/ramips/dts/D240.dts b/target/linux/ramips/dts/D240.dts\nindex 4f3da8d316..7ae2daa0b1 100644\n--- a/target/linux/ramips/dts/D240.dts\n+++ b/target/linux/ramips/dts/D240.dts\n@@ -53,8 +53,15 @@\n \t\tpower_mpcie2 {\n \t\t\tgpio-export,name = \"power_mpcie2\";\n \t\t\tgpio-export,output = <GPIO_ACTIVE_LOW>;\n-\t\t\tgpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;\n+\t\t\tgpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;\n \t\t};\n+\n+\t\tpower_mpcie1 {\n+\t\t\tgpio-export,name = \"power_mpcie1\";\n+\t\t\tgpio-export,output = <GPIO_ACTIVE_LOW>;\n+\t\t\tgpios = <&gpio2 6 GPIO_ACTIVE_HIGH>;\n+\t\t};\n+\n \t};\n \n \tgpio-leds {\n@@ -94,6 +101,10 @@\n \tstatus = \"okay\";\n };\n \n+&gpio2 {\n+\tstatus = \"okay\";\n+};\n+\n &gpio3 {\n \tstatus = \"okay\";\n };\n@@ -157,7 +168,7 @@\n &pinctrl {\n \tstate_default: pinctrl0 {\n \t\tdefault {\n-\t\t\tralink,group = \"i2c\", \"uartf\", \"wled\", \"spi refclk\", \"pa\";\n+\t\t\tralink,group = \"i2c\", \"uartf\", \"wled\", \"spi refclk\", \"pa\", \"nd_sd\";\n \t\t\tralink,function = \"gpio\";\n \t\t};\n \t};\n","prefixes":["LEDE-DEV"]}