{"id":812945,"url":"http://patchwork.ozlabs.org/api/patches/812945/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505232834-20890-1-git-send-email-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505232834-20890-1-git-send-email-peter.maydell@linaro.org>","list_archive_url":null,"date":"2017-09-12T16:13:54","name":"mps2-an511: Fix wiring of UART overflow interrupt lines","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d06ee4bd345c4143e49d57d4c1962e22b30d8c37","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1505232834-20890-1-git-send-email-peter.maydell@linaro.org/mbox/","series":[{"id":2736,"url":"http://patchwork.ozlabs.org/api/series/2736/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2736","date":"2017-09-12T16:13:54","name":"mps2-an511: Fix wiring of UART overflow interrupt lines","version":1,"mbox":"http://patchwork.ozlabs.org/series/2736/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812945/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812945/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs8xl5Cvhz9s7f\n\tfor ;\n\tWed, 13 Sep 2017 02:14:19 +1000 (AEST)","from localhost ([::1]:36835 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drnpJ-0002Np-OP\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 12:14:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33660)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drnof-0002La-Pn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:13:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drnoe-0001ZC-ME\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:13:37 -0400","from orth.archaic.org.uk ([2001:8b0:1d0::2]:37270)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drnoe-0001VB-DR\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 12:13:36 -0400","from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from )\n\tid 1drnoW-0000w5-3e; Tue, 12 Sep 2017 17:13:28 +0100"],"From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Date":"Tue, 12 Sep 2017 17:13:54 +0100","Message-Id":"<1505232834-20890-1-git-send-email-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.7.4","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:8b0:1d0::2","Subject":"[Qemu-devel] [PATCH] mps2-an511: Fix wiring of UART overflow\n\tinterrupt lines","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-stable@nongnu.org, patches@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Fix an error that meant we were wiring every UART's overflow\ninterrupts into the same inputs 0 and 1 of the OR gate,\nrather than giving each its own input.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Peter Maydell \n---\n hw/arm/mps2.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c\nindex abb0ab6..769cff8 100644\n--- a/hw/arm/mps2.c\n+++ b/hw/arm/mps2.c\n@@ -287,8 +287,8 @@ static void mps2_common_init(MachineState *machine)\n cmsdk_apb_uart_create(uartbase[i],\n qdev_get_gpio_in(txrx_orgate_dev, 0),\n qdev_get_gpio_in(txrx_orgate_dev, 1),\n- qdev_get_gpio_in(orgate_dev, 0),\n- qdev_get_gpio_in(orgate_dev, 1),\n+ qdev_get_gpio_in(orgate_dev, i * 2),\n+ qdev_get_gpio_in(orgate_dev, i * 2 + 1),\n NULL,\n uartchr, SYSCLK_FRQ);\n }\n","prefixes":[]}