{"id":812885,"url":"http://patchwork.ozlabs.org/api/patches/812885/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1505227539-17560-3-git-send-email-jjhiblot@ti.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505227539-17560-3-git-send-email-jjhiblot@ti.com>","list_archive_url":null,"date":"2017-09-12T14:45:31","name":"[U-Boot,v5,02/10] fit: use 'const' for the input of fdt_offset() and locate_dtb_in_fit()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6107acb0d874332352d974db07f034a79d03335f","submitter":{"id":70508,"url":"http://patchwork.ozlabs.org/api/people/70508/?format=json","name":"Jean-Jacques Hiblot","email":"jjhiblot@ti.com"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1505227539-17560-3-git-send-email-jjhiblot@ti.com/mbox/","series":[{"id":2721,"url":"http://patchwork.ozlabs.org/api/series/2721/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=2721","date":"2017-09-12T14:45:29","name":"spl: dm: Make it possible for the SPL to pick its own DTB from a FIT","version":5,"mbox":"http://patchwork.ozlabs.org/series/2721/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812885/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812885/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"vQri2BnN\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs72j6T6yz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 00:48:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 92BE9C22100; Tue, 12 Sep 2017 14:46:32 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 89386C220F6;\n\tTue, 12 Sep 2017 14:45:58 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4E571C22021; Tue, 12 Sep 2017 14:45:47 +0000 (UTC)","from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80])\n\tby lists.denx.de (Postfix) with ESMTPS id 7C3C1C21DC4\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 14:45:44 +0000 (UTC)","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8CEjfVl024379; \n\tTue, 12 Sep 2017 09:45:41 -0500","from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8CEjfn1012363; \n\tTue, 12 Sep 2017 09:45:41 -0500","from DLEE111.ent.ti.com (157.170.170.22) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tTue, 12 Sep 2017 09:45:41 -0500","from dlep32.itg.ti.com (157.170.170.100) by DLEE111.ent.ti.com\n\t(157.170.170.22) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Tue, 12 Sep 2017 09:45:41 -0500","from localhost (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8CEjeep015528;\n\tTue, 12 Sep 2017 09:45:40 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505227541;\n\tbh=WwPyDkFXPXu5yctfQUe8tM0+fhUIoD4yuFXcujJqJzQ=;\n\th=From:To:CC:Subject:Date:In-Reply-To:References;\n\tb=vQri2BnN6Wmu+ZcoT8DvMkjFEHusIObm7cDIZtVnMULECA1lPyRAUJ5CWI8R3a0EW\n\tzjXSKhxBakxhOyDm1RrHTz/tqbJngcZdw8LtA2Y5oBpI77l0XKlzFt5nSYaQFhGWgv\n\tRJzpZewqKMBM4EaQKqq3kA1JT/+4I/s6c22F2Ics=","From":"Jean-Jacques Hiblot <jjhiblot@ti.com>","To":"<trini@konsulko.com>, <lokeshvutla@ti.com>, <sjg@chromium.org>,\n\t<fcooper@ti.com>","Date":"Tue, 12 Sep 2017 16:45:31 +0200","Message-ID":"<1505227539-17560-3-git-send-email-jjhiblot@ti.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1505227539-17560-1-git-send-email-jjhiblot@ti.com>","References":"<1505227539-17560-1-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Cc":"u-boot@lists.denx.de","Subject":"[U-Boot] [PATCH v5 02/10] fit: use 'const' for the input of\n\tfdt_offset() and locate_dtb_in_fit()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"Those 2 functions don't modify their input, we can mark it const.\nThis prevents compilation warnings when they are provided const input.\n\nSigned-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>\nReviewed-by: Tom Rini <trini@konsulko.com>\nReviewed-by: Simon Glass <sjg@chromium.org>\n---\n common/boot_fit.c  | 4 ++--\n include/boot_fit.h | 9 +++++++--\n 2 files changed, 9 insertions(+), 4 deletions(-)","diff":"diff --git a/common/boot_fit.c b/common/boot_fit.c\nindex 0a72315..ce42931 100644\n--- a/common/boot_fit.c\n+++ b/common/boot_fit.c\n@@ -13,7 +13,7 @@\n #include <image.h>\n #include <libfdt.h>\n \n-int fdt_offset(void *fit)\n+static int fdt_offset(const void *fit)\n {\n \tint images, node, fdt_len, fdt_node, fdt_offset;\n \tconst char *fdt_name;\n@@ -55,7 +55,7 @@ int fdt_offset(void *fit)\n \treturn fdt_offset;\n }\n \n-void *locate_dtb_in_fit(void *fit)\n+void *locate_dtb_in_fit(const void *fit)\n {\n \tstruct image_header *header;\n \tint size;\ndiff --git a/include/boot_fit.h b/include/boot_fit.h\nindex b7d2462..e16ae5b 100644\n--- a/include/boot_fit.h\n+++ b/include/boot_fit.h\n@@ -5,5 +5,10 @@\n  * SPDX-License-Identifier:     GPL-2.0+\n  */\n \n-int fdt_offset(void *fit);\n-void *locate_dtb_in_fit(void *fit);\n+/**\n+ * locate_dtb_in_fit - Find a DTB matching the board in a FIT image\n+ * @fit:\tpointer to the FIT image\n+ *\n+ * @return a pointer to a matching DTB blob if found, NULL otherwise\n+ */\n+void *locate_dtb_in_fit(const void *fit);\n","prefixes":["U-Boot","v5","02/10"]}