{"id":812843,"url":"http://patchwork.ozlabs.org/api/patches/812843/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912131847.27684-4-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170912131847.27684-4-berrange@redhat.com>","list_archive_url":null,"date":"2017-09-12T13:18:47","name":"[v4,3/3] io: use case insensitive check for Connection & Upgrade websock headers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5ff8317ddf70ffd4d2cdbc170d640efc249c4aae","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrange","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912131847.27684-4-berrange@redhat.com/mbox/","series":[{"id":2700,"url":"http://patchwork.ozlabs.org/api/series/2700/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2700","date":"2017-09-12T13:18:44","name":"Improve websock response / error handling","version":4,"mbox":"http://patchwork.ozlabs.org/series/2700/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812843/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812843/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs54F0pPVz9s3T\n\tfor ;\n\tTue, 12 Sep 2017 23:19:41 +1000 (AEST)","from localhost ([::1]:35814 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drl6J-0005Bs-84\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:19:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40090)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drl5h-0005Ak-HN\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:19:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drl5g-0001Ia-7b\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:19:01 -0400","from mx1.redhat.com ([209.132.183.28]:50614)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drl5g-0001Ht-2p\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:19:00 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 34B455F73A;\n\tTue, 12 Sep 2017 13:18:59 +0000 (UTC)","from localhost.localdomain.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3B68A66835;\n\tTue, 12 Sep 2017 13:18:58 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 34B455F73A","From":"\"Daniel P. Berrange\" ","To":"qemu-devel@nongnu.org","Date":"Tue, 12 Sep 2017 14:18:47 +0100","Message-Id":"<20170912131847.27684-4-berrange@redhat.com>","In-Reply-To":"<20170912131847.27684-1-berrange@redhat.com>","References":"<20170912131847.27684-1-berrange@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 13:18:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v4 3/3] io: use case insensitive check for\n\tConnection & Upgrade websock headers","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Brian Rak , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"When checking the value of the Connection and Upgrade HTTP headers\nthe websock RFC (6455) requires the comparison to be case insensitive.\nThe Connection value should be an exact match not a substring.\n\nReviewed-by: Eric Blake \nSigned-off-by: Daniel P. Berrange \n---\n io/channel-websock.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/io/channel-websock.c b/io/channel-websock.c\nindex 6ddcec1549..2258557a21 100644\n--- a/io/channel-websock.c\n+++ b/io/channel-websock.c\n@@ -431,12 +431,12 @@ static void qio_channel_websock_handshake_process(QIOChannelWebsock *ioc,\n goto bad_request;\n }\n \n- if (!g_strrstr(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE)) {\n+ if (strcasecmp(connection, QIO_CHANNEL_WEBSOCK_CONNECTION_UPGRADE) != 0) {\n error_setg(errp, \"No connection upgrade requested '%s'\", connection);\n goto bad_request;\n }\n \n- if (!g_str_equal(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET)) {\n+ if (strcasecmp(upgrade, QIO_CHANNEL_WEBSOCK_UPGRADE_WEBSOCKET) != 0) {\n error_setg(errp, \"Incorrect upgrade method '%s'\", upgrade);\n goto bad_request;\n }\n","prefixes":["v4","3/3"]}