{"id":812827,"url":"http://patchwork.ozlabs.org/api/patches/812827/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912123744.14730-5-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170912123744.14730-5-berrange@redhat.com>","list_archive_url":null,"date":"2017-09-12T12:37:36","name":"[v5,04/12] ui: don't export qemu_input_event_new_key","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b377afb2096cc7ccc8ebd07a185a23ea116149d0","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912123744.14730-5-berrange@redhat.com/mbox/","series":[{"id":2692,"url":"http://patchwork.ozlabs.org/api/series/2692/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2692","date":"2017-09-12T12:37:33","name":"Convert over to use keycodemapdb","version":5,"mbox":"http://patchwork.ozlabs.org/series/2692/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812827/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812827/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4RY3Rbfz9t86\n\tfor ;\n\tTue, 12 Sep 2017 22:49:57 +1000 (AEST)","from localhost ([::1]:35586 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkVO-0003Ew-NH\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 08:41:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48591)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkS5-0000hs-DO\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:38:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkRz-0003RD-I2\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:38:05 -0400","from mx1.redhat.com ([209.132.183.28]:59170)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkRz-0003Qk-Cu\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:37:59 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7988AC04B92C\n\tfor ; Tue, 12 Sep 2017 12:37:58 +0000 (UTC)","from localhost.localdomain.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8274077D65;\n\tTue, 12 Sep 2017 12:37:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7988AC04B92C","From":"\"Daniel P. Berrange\" ","To":"qemu-devel@nongnu.org","Date":"Tue, 12 Sep 2017 13:37:36 +0100","Message-Id":"<20170912123744.14730-5-berrange@redhat.com>","In-Reply-To":"<20170912123744.14730-1-berrange@redhat.com>","References":"<20170912123744.14730-1-berrange@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 12:37:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v5 04/12] ui: don't export\n\tqemu_input_event_new_key","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Gerd Hoffmann ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"All public code should use qemu_input_event_send_key* functions\ninstead of creating an event directly.\n\nSigned-off-by: Daniel P. Berrange \n---\n include/ui/input.h | 1 -\n ui/input.c | 2 +-\n 2 files changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/include/ui/input.h b/include/ui/input.h\nindex 479cc46cfc..f8cee43f65 100644\n--- a/include/ui/input.h\n+++ b/include/ui/input.h\n@@ -38,7 +38,6 @@ void qemu_input_event_send_impl(QemuConsole *src, InputEvent *evt);\n void qemu_input_event_sync(void);\n void qemu_input_event_sync_impl(void);\n \n-InputEvent *qemu_input_event_new_key(KeyValue *key, bool down);\n void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down);\n void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down);\n void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down);\ndiff --git a/ui/input.c b/ui/input.c\nindex 9914daf0b4..23f9f2c5e0 100644\n--- a/ui/input.c\n+++ b/ui/input.c\n@@ -374,7 +374,7 @@ void qemu_input_event_sync(void)\n replay_input_sync_event();\n }\n \n-InputEvent *qemu_input_event_new_key(KeyValue *key, bool down)\n+static InputEvent *qemu_input_event_new_key(KeyValue *key, bool down)\n {\n InputEvent *evt = g_new0(InputEvent, 1);\n evt->u.key.data = g_new0(InputKeyEvent, 1);\n","prefixes":["v5","04/12"]}