{"id":812823,"url":"http://patchwork.ozlabs.org/api/patches/812823/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912123744.14730-4-berrange@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170912123744.14730-4-berrange@redhat.com>","list_archive_url":null,"date":"2017-09-12T12:37:35","name":"[v5,03/12] ui: convert key events to QKeyCodes immediately","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7e1c3839b81c66fb0f1c8c927b6f6ef930824161","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/?format=json","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170912123744.14730-4-berrange@redhat.com/mbox/","series":[{"id":2692,"url":"http://patchwork.ozlabs.org/api/series/2692/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2692","date":"2017-09-12T12:37:33","name":"Convert over to use keycodemapdb","version":5,"mbox":"http://patchwork.ozlabs.org/series/2692/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812823/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812823/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4B00qPgz9t7p\n\tfor ;\n\tTue, 12 Sep 2017 22:39:23 +1000 (AEST)","from localhost ([::1]:35571 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkSh-0000e2-6z\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 08:38:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48524)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkRz-0000cx-6B\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:38:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkRy-0003QY-Ca\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:37:59 -0400","from mx1.redhat.com ([209.132.183.28]:60210)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkRy-0003QI-7E\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:37:58 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 49BD25D689\n\tfor ; Tue, 12 Sep 2017 12:37:57 +0000 (UTC)","from localhost.localdomain.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 77DF777D65;\n\tTue, 12 Sep 2017 12:37:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 49BD25D689","From":"\"Daniel P. Berrange\" ","To":"qemu-devel@nongnu.org","Date":"Tue, 12 Sep 2017 13:37:35 +0100","Message-Id":"<20170912123744.14730-4-berrange@redhat.com>","In-Reply-To":"<20170912123744.14730-1-berrange@redhat.com>","References":"<20170912123744.14730-1-berrange@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 12:37:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v5 03/12] ui: convert key events to QKeyCodes\n\timmediately","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Gerd Hoffmann ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Always use QKeyCode in the InputKeyEvent struct, by converting key\nnumbers to QKeyCode at the time the event is created.\n\nSigned-off-by: Daniel P. Berrange \n---\n ui/input.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/ui/input.c b/ui/input.c\nindex 3422d4a8ef..9914daf0b4 100644\n--- a/ui/input.c\n+++ b/ui/input.c\n@@ -400,10 +400,8 @@ void qemu_input_event_send_key(QemuConsole *src, KeyValue *key, bool down)\n \n void qemu_input_event_send_key_number(QemuConsole *src, int num, bool down)\n {\n- KeyValue *key = g_new0(KeyValue, 1);\n- key->type = KEY_VALUE_KIND_NUMBER;\n- key->u.number.data = num;\n- qemu_input_event_send_key(src, key, down);\n+ QKeyCode code = qemu_input_key_number_to_qcode(num);\n+ qemu_input_event_send_key_qcode(src, code, down);\n }\n \n void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode q, bool down)\n","prefixes":["v5","03/12"]}