{"id":812584,"url":"http://patchwork.ozlabs.org/api/patches/812584/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1505160270-10650-6-git-send-email-philipp.tomsich@theobroma-systems.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505160270-10650-6-git-send-email-philipp.tomsich@theobroma-systems.com>","list_archive_url":null,"date":"2017-09-11T20:04:13","name":"[U-Boot,v3,05/19] net: designware: Convert to livetree","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"670876f4790d4b5f7bbe8475645ce1487fe36f81","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/?format=json","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"delegate":{"id":69486,"url":"http://patchwork.ozlabs.org/api/users/69486/?format=json","username":"ptomsich","first_name":"Philipp","last_name":"Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1505160270-10650-6-git-send-email-philipp.tomsich@theobroma-systems.com/mbox/","series":[{"id":2559,"url":"http://patchwork.ozlabs.org/api/series/2559/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=2559","date":"2017-09-11T20:04:11","name":"rockchip: convert the RK3368 to OF_LIVE and validate on the RK3368-uQ7","version":3,"mbox":"http://patchwork.ozlabs.org/series/2559/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812584/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812584/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrfBh2zDcz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 06:08:44 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 0DC4BC21F9E; Mon, 11 Sep 2017 20:06:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1B0D7C21F9F;\n\tMon, 11 Sep 2017 20:04:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9BDE8C21E31; Mon, 11 Sep 2017 20:04:43 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 54FCFC21E4B\n\tfor ; Mon, 11 Sep 2017 20:04:43 +0000 (UTC)","from [86.59.122.178] (port=59228 helo=android.lan)\n\tby mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:RSA_AES_128_CBC_SHA256:128)\n\t(Exim 4.80) (envelope-from )\n\tid 1drUwi-0003kn-HJ; Mon, 11 Sep 2017 22:04:40 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","From":"Philipp Tomsich ","To":"u-boot@lists.denx.de","Date":"Mon, 11 Sep 2017 22:04:13 +0200","Message-Id":"<1505160270-10650-6-git-send-email-philipp.tomsich@theobroma-systems.com>","X-Mailer":"git-send-email 2.1.4","In-Reply-To":"<1505160270-10650-1-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1505160270-10650-1-git-send-email-philipp.tomsich@theobroma-systems.com>","Cc":"Joe Hershberger ,\n\tKlaus Goger ","Subject":"[U-Boot] [PATCH v3 05/19] net: designware: Convert to livetree","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"Update the Designware Ethernet MAC driver to support a live device\ntree.\n\nSigned-off-by: Philipp Tomsich \nAcked-by: Joe Hershberger \n\n---\n\nChanges in v3:\n- added Joe's Acked-by: tag (which I had lost)\n\nChanges in v2: None\n\n drivers/net/designware.c | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/net/designware.c b/drivers/net/designware.c\nindex 521e4dd..036d231 100644\n--- a/drivers/net/designware.c\n+++ b/drivers/net/designware.c\n@@ -737,16 +737,14 @@ int designware_eth_ofdata_to_platdata(struct udevice *dev)\n #endif\n \tstruct eth_pdata *pdata = &dw_pdata->eth_pdata;\n \tconst char *phy_mode;\n-\tconst fdt32_t *cell;\n #ifdef CONFIG_DM_GPIO\n \tint reset_flags = GPIOD_IS_OUT;\n #endif\n \tint ret = 0;\n \n-\tpdata->iobase = devfdt_get_addr(dev);\n+\tpdata->iobase = dev_read_addr(dev);\n \tpdata->phy_interface = -1;\n-\tphy_mode = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), \"phy-mode\",\n-\t\t\t NULL);\n+\tphy_mode = dev_read_string(dev, \"phy-mode\");\n \tif (phy_mode)\n \t\tpdata->phy_interface = phy_get_interface_by_name(phy_mode);\n \tif (pdata->phy_interface == -1) {\n@@ -754,10 +752,7 @@ int designware_eth_ofdata_to_platdata(struct udevice *dev)\n \t\treturn -EINVAL;\n \t}\n \n-\tpdata->max_speed = 0;\n-\tcell = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), \"max-speed\", NULL);\n-\tif (cell)\n-\t\tpdata->max_speed = fdt32_to_cpu(*cell);\n+\tpdata->max_speed = dev_read_u32_default(dev, \"max-speed\", 0);\n \n #ifdef CONFIG_DM_GPIO\n \tif (dev_read_bool(dev, \"snps,reset-active-low\"))\n","prefixes":["U-Boot","v3","05/19"]}