{"id":812550,"url":"http://patchwork.ozlabs.org/api/patches/812550/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA335C94@CHN-SV-EXMX03.mchp-main.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-11T18:52:21","name":"[v2,net,2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"d34d84fc66ce637bd53313f34315ccd88cbab366","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/?format=json","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA335C94@CHN-SV-EXMX03.mchp-main.com/mbox/","series":[{"id":2544,"url":"http://patchwork.ozlabs.org/api/series/2544/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2544","date":"2017-09-11T18:51:30","name":"lan78xx: Fixes to lan78xx driver","version":2,"mbox":"http://patchwork.ozlabs.org/series/2544/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812550/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812550/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrcWV1366z9s7f\n\tfor ;\n\tTue, 12 Sep 2017 04:53:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751289AbdIKSxI convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 11 Sep 2017 14:53:08 -0400","from esa2.microchip.iphmx.com ([68.232.149.84]:20081 \"EHLO\n\tesa2.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751029AbdIKSxH (ORCPT\n\t); Mon, 11 Sep 2017 14:53:07 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t11 Sep 2017 11:52:23 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH04.mchp-main.com ([fe80::6150:8a42:4945:9b1b%16]) with\n\tmapi id 14.03.0352.000; Mon, 11 Sep 2017 11:52:22 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,379,1500966000\"; d=\"scan'208\";a=\"6898840\"","From":"","To":"","CC":", ","Subject":"[PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Topic":"[PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Index":"AdMrLHzJhj+t03S+RiumpCdOatvCpg==","Date":"Mon, 11 Sep 2017 18:52:21 +0000","Message-ID":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nisar Sayed \n\nAllow EEPROM write for less than MAX_EEPROM_SIZE\n\nFixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver\")\nSigned-off-by: Nisar Sayed \n---\n drivers/net/usb/lan78xx.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\nindex baf91c7..02d64f75 100644\n--- a/drivers/net/usb/lan78xx.c\n+++ b/drivers/net/usb/lan78xx.c\n@@ -1290,8 +1290,8 @@ static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n \n \t/* Allow entire eeprom update only */\n \tif ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n-\t (ee->offset == 0) &&\n-\t (ee->len == 512) &&\n+\t (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n+\t (ee->len > 0 && (ee->offset + ee->len) <= MAX_EEPROM_SIZE) &&\n \t (data[0] == EEPROM_INDICATOR))\n \t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n \telse if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n","prefixes":["v2","net","2/3"]}