{"id":812482,"url":"http://patchwork.ozlabs.org/api/patches/812482/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com/","date":"2017-09-11T17:32:14","name":"powerpc/perf: Fix for core/nest imc call trace on cpuhotplug","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"e679d1e4f9cd9fb094f7fecc3e4e9863a7551277","submitter":{"id":67491,"url":"http://patchwork.ozlabs.org/api/people/67491/?format=json","name":"Anju T Sudhakar","email":"anju@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com/mbox/","series":[{"id":2535,"url":"http://patchwork.ozlabs.org/api/series/2535/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=2535","date":"2017-09-11T17:32:14","name":"powerpc/perf: Fix for core/nest imc call trace on cpuhotplug","version":1,"mbox":"http://patchwork.ozlabs.org/series/2535/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812482/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812482/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrZm22kWLz9s81\n\tfor ;\n\tTue, 12 Sep 2017 03:33:54 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xrZm21ZkGzDrnd\n\tfor ;\n\tTue, 12 Sep 2017 03:33:54 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xrZkS0gSnzDrYV\n\tfor ;\n\tTue, 12 Sep 2017 03:32:31 +1000 (AEST)","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8BHTIsf040910\n\tfor ; Mon, 11 Sep 2017 13:32:29 -0400","from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cwx4gtvrd-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 11 Sep 2017 13:32:29 -0400","from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 12 Sep 2017 03:32:26 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 12 Sep 2017 03:32:19 +1000","from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8BHWI8F28377224\n\tfor ; Tue, 12 Sep 2017 03:32:18 +1000","from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8BHWIqM000897\n\tfor ; Tue, 12 Sep 2017 03:32:18 +1000","from xenial-xerus.in.ibm.com ([9.79.235.20])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8BHWFSd000811; Tue, 12 Sep 2017 03:32:16 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=anju@linux.vnet.ibm.com; receiver=)","From":"Anju T Sudhakar ","To":"mpe@ellerman.id.au","Subject":"[PATCH] powerpc/perf: Fix for core/nest imc call trace on cpuhotplug","Date":"Mon, 11 Sep 2017 23:02:14 +0530","X-Mailer":"git-send-email 2.7.4","X-TM-AS-MML":"disable","x-cbid":"17091117-1617-0000-0000-000001FF5F39","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091117-1618-0000-0000-0000484DBD3E","Message-Id":"<1505151134-26128-1-git-send-email-anju@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-11_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709110264","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hemant@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tanju@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Nest/core pmu units are enabled only when it is used. A reference count is\nmaintained for the events which uses the nest/core pmu units. Currently in\n*_imc_counters_release function a WARN() is used for notification of any\nunderflow of ref count. Replace WARN() with a pr_info since it is an overkill.\n\nSigned-off-by: Anju T Sudhakar \nAcked-by: Madhavan Srinivasan \n---\n arch/powerpc/perf/imc-pmu.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c\nindex 9ccac86..4d523d0 100644\n--- a/arch/powerpc/perf/imc-pmu.c\n+++ b/arch/powerpc/perf/imc-pmu.c\n@@ -409,7 +409,7 @@ static void nest_imc_counters_release(struct perf_event *event)\n \t\t\treturn;\n \t\t}\n \t} else if (ref->refc < 0) {\n-\t\tWARN(1, \"nest-imc: Invalid event reference count\\n\");\n+\t\tpr_info(\"nest-imc: Invalid event reference count\\n\");\n \t\tref->refc = 0;\n \t}\n \tmutex_unlock(&ref->lock);\n@@ -656,7 +656,7 @@ static void core_imc_counters_release(struct perf_event *event)\n \t\t\treturn;\n \t\t}\n \t} else if (ref->refc < 0) {\n-\t\tWARN(1, \"core-imc: Invalid event reference count\\n\");\n+\t\tpr_info(\"core-imc: Invalid event reference count\\n\");\n \t\tref->refc = 0;\n \t}\n \tmutex_unlock(&ref->lock);\n","prefixes":[]}