{"id":812476,"url":"http://patchwork.ozlabs.org/api/patches/812476/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911172022.4738-8-eblake@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911172022.4738-8-eblake@redhat.com>","list_archive_url":null,"date":"2017-09-11T17:19:51","name":"[v7,07/38] libqtest: Inline qtest_query_target_endianness()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"18de2ca8f8cd9f9632d5ce7bb353bfa50fd30582","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/?format=json","name":"Eric Blake","email":"eblake@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911172022.4738-8-eblake@redhat.com/mbox/","series":[{"id":2534,"url":"http://patchwork.ozlabs.org/api/series/2534/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2534","date":"2017-09-11T17:19:47","name":"Preliminary libqtest cleanups","version":7,"mbox":"http://patchwork.ozlabs.org/series/2534/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812476/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812476/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrZf00VTqz9s81\n\tfor ;\n\tTue, 12 Sep 2017 03:28:40 +1000 (AEST)","from localhost ([::1]:59350 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drSVi-0005lO-36\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 13:28:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38209)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drSO4-000727-K0\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:20:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drSNz-00010K-Kp\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:20:44 -0400","from mx1.redhat.com ([209.132.183.28]:35762)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drSNz-0000zp-68\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 13:20:39 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 51747C0C0567\n\tfor ; Mon, 11 Sep 2017 17:20:38 +0000 (UTC)","from red.redhat.com (ovpn-120-44.rdu2.redhat.com [10.10.120.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 731525D9CA;\n\tMon, 11 Sep 2017 17:20:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 51747C0C0567","From":"Eric Blake ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 12:19:51 -0500","Message-Id":"<20170911172022.4738-8-eblake@redhat.com>","In-Reply-To":"<20170911172022.4738-1-eblake@redhat.com>","References":"<20170911172022.4738-1-eblake@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 11 Sep 2017 17:20:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v7 07/38] libqtest: Inline\n\tqtest_query_target_endianness()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"There was only one caller; it's easier to inline things. (It\ntrades one forward declaration for two others, but it's not\nworth the additional churn of topological sorting, even though\nthat would be possible.)\n\nSigned-off-by: Eric Blake \n\n---\nv7: Drop the topological sorting\n---\n tests/libqtest.c | 26 +++++++++-----------------\n 1 file changed, 9 insertions(+), 17 deletions(-)","diff":"diff --git a/tests/libqtest.c b/tests/libqtest.c\nindex 95d4159b38..1710d63276 100644\n--- a/tests/libqtest.c\n+++ b/tests/libqtest.c\n@@ -49,7 +49,9 @@ static struct sigaction sigact_old;\n g_assert_cmpint(ret, !=, -1); \\\n } while (0)\n\n-static int qtest_query_target_endianness(QTestState *s);\n+static void qtest_sendf(QTestState *s, const char *fmt, ...)\n+ GCC_FMT_ATTR(2, 3);\n+static gchar **qtest_rsp(QTestState *s, int expected_args);\n\n static int init_socket(const char *socket_path)\n {\n@@ -158,6 +160,7 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n gchar *qmp_socket_path;\n gchar *command;\n const char *qemu_binary;\n+ gchar **args;\n\n qemu_binary = getenv(\"QTEST_QEMU_BINARY\");\n if (!qemu_binary) {\n@@ -221,8 +224,11 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n }\n\n /* ask endianness of the target */\n-\n- s->big_endian = qtest_query_target_endianness(s);\n+ qtest_sendf(s, \"endianness\\n\");\n+ args = qtest_rsp(s, 1);\n+ g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n+ s->big_endian = strcmp(args[1], \"big\") == 0;\n+ g_strfreev(args);\n\n return s;\n }\n@@ -367,20 +373,6 @@ redo:\n return words;\n }\n\n-static int qtest_query_target_endianness(QTestState *s)\n-{\n- gchar **args;\n- int big_endian;\n-\n- qtest_sendf(s, \"endianness\\n\");\n- args = qtest_rsp(s, 1);\n- g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n- big_endian = strcmp(args[1], \"big\") == 0;\n- g_strfreev(args);\n-\n- return big_endian;\n-}\n-\n typedef struct {\n JSONMessageParser parser;\n QDict *response;\n","prefixes":["v7","07/38"]}