{"id":812420,"url":"http://patchwork.ozlabs.org/api/patches/812420/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911152150.12535-10-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911152150.12535-10-david@redhat.com>","list_archive_url":null,"date":"2017-09-11T15:21:38","name":"[v4,09/21] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"637d015af1ba93e077de9d4334cf9ca72ffb7565","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911152150.12535-10-david@redhat.com/mbox/","series":[{"id":2516,"url":"http://patchwork.ozlabs.org/api/series/2516/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2516","date":"2017-09-11T15:21:29","name":"s390x cleanups and CPU hotplug via device_add","version":4,"mbox":"http://patchwork.ozlabs.org/series/2516/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812420/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812420/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrX0c6P7Nz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 01:29:36 +1000 (AEST)","from localhost ([::1]:58422 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drQeU-0001rk-T4\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 11:29:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49150)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1drQXs-0004X4-Qx\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:22:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1drQXn-0000m1-U4\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:22:44 -0400","from mx1.redhat.com ([209.132.183.28]:42658)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1drQXn-0000j5-OA\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:22:39 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D63BB1032B3;\n\tMon, 11 Sep 2017 15:22:38 +0000 (UTC)","from t460s.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B9EB66B272;\n\tMon, 11 Sep 2017 15:22:33 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D63BB1032B3","From":"David Hildenbrand <david@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 17:21:38 +0200","Message-Id":"<20170911152150.12535-10-david@redhat.com>","In-Reply-To":"<20170911152150.12535-1-david@redhat.com>","References":"<20170911152150.12535-1-david@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 11 Sep 2017 15:22:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v4 09/21] target/s390x: use\n\ttrigger_pgm_exception() in s390_cpu_handle_mmu_fault()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>,\n\tMarkus Armbruster <armbru@redhat.com>, borntraeger@de.ibm.com,\n\tPaolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"This looks cleaner. linux-user will not use the ilen field, so setting\nit doesn't do any harm.\n\nReviewed-by: Thomas Huth <thuth@redhat.com>\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/excp_helper.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c\nindex 361f970db3..14d3160e92 100644\n--- a/target/s390x/excp_helper.c\n+++ b/target/s390x/excp_helper.c\n@@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address,\n {\n     S390CPU *cpu = S390_CPU(cs);\n \n-    cs->exception_index = EXCP_PGM;\n-    cpu->env.int_pgm_code = PGM_ADDRESSING;\n+    trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO);\n     /* On real machines this value is dropped into LowMem.  Since this\n        is userland, simply put this someplace that cpu_loop can find it.  */\n     cpu->env.__excp_addr = address;\n","prefixes":["v4","09/21"]}