{"id":812398,"url":"http://patchwork.ozlabs.org/api/patches/812398/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911142056.15643-2-lvivier@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911142056.15643-2-lvivier@redhat.com>","list_archive_url":null,"date":"2017-09-11T14:20:54","name":"[v2,1/3] hmp: fix \"dump-quest-memory\" segfault (ppc)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c12c503d0ae6a243e508f50c57695705bcac501c","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/?format=json","name":"Laurent Vivier","email":"lvivier@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911142056.15643-2-lvivier@redhat.com/mbox/","series":[{"id":2509,"url":"http://patchwork.ozlabs.org/api/series/2509/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2509","date":"2017-09-11T14:20:53","name":"hmp: fix \"dump-quest-memory\" segfault","version":2,"mbox":"http://patchwork.ozlabs.org/series/2509/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812398/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812398/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrVYD6LGkz9s5L\n\tfor ;\n\tTue, 12 Sep 2017 00:24:16 +1000 (AEST)","from localhost ([::1]:58061 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drPdG-00018T-WF\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 10:24:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50831)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drPaO-0007ZJ-KK\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:21:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drPaN-0001q5-OZ\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:21:16 -0400","from mx1.redhat.com ([209.132.183.28]:43652)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drPaD-0001jm-2M; Mon, 11 Sep 2017 10:21:05 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0FF487B5B7;\n\tMon, 11 Sep 2017 14:21:04 +0000 (UTC)","from thinkpad.redhat.com (ovpn-116-239.ams2.redhat.com\n\t[10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id F4008649CC;\n\tMon, 11 Sep 2017 14:21:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0FF487B5B7","From":"Laurent Vivier ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 16:20:54 +0200","Message-Id":"<20170911142056.15643-2-lvivier@redhat.com>","In-Reply-To":"<20170911142056.15643-1-lvivier@redhat.com>","References":"<20170911142056.15643-1-lvivier@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 11 Sep 2017 14:21:04 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 1/3] hmp: fix \"dump-quest-memory\" segfault\n\t(ppc)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier ,\n\tPeter Maydell ,\n\tThomas Huth , Cornelia Huck ,\n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Commit fd5d23babf (hmp: fix \"dump-quest-memory\" segfault)\nfixes the problem for i386, do the same for ppc.\n\nRunning QEMU with\n qemu-system-ppc64 -M none -nographic -m 256\nand executing\n dump-guest-memory /dev/null 0 8192\nresults in segfault\n\nFix by checking if we have CPU.\n\nSigned-off-by: Laurent Vivier \nReviewed-by: Greg Kurz \n---\n target/ppc/arch_dump.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)","diff":"diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c\nindex 8e9397aa58..dcb7b19950 100644\n--- a/target/ppc/arch_dump.c\n+++ b/target/ppc/arch_dump.c\n@@ -224,17 +224,22 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;\n int cpu_get_dump_info(ArchDumpInfo *info,\n const struct GuestPhysBlockList *guest_phys_blocks)\n {\n- PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n- PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n-\n info->d_machine = PPC_ELF_MACHINE;\n info->d_class = ELFCLASS;\n \n- if ((*pcc->interrupts_big_endian)(cpu)) {\n- info->d_endian = ELFDATA2MSB;\n+ if (first_cpu) {\n+ PowerPCCPU *cpu = POWERPC_CPU(first_cpu);\n+ PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);\n+\n+ if ((*pcc->interrupts_big_endian)(cpu)) {\n+ info->d_endian = ELFDATA2MSB;\n+ } else {\n+ info->d_endian = ELFDATA2LSB;\n+ }\n } else {\n- info->d_endian = ELFDATA2LSB;\n+ info->d_endian = ELFDATA2MSB;\n }\n+\n /* 64KB is the max page size for pseries kernel */\n if (strncmp(object_get_typename(qdev_get_machine()),\n \"pseries-\", 8) == 0) {\n","prefixes":["v2","1/3"]}