{"id":812375,"url":"http://patchwork.ozlabs.org/api/patches/812375/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA335A6F@CHN-SV-EXMX03.mchp-main.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2017-09-11T12:32:10","name":"[v1,net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":true,"hash":"32734b206e002663b9fb7b17712a6f295ca4c477","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/?format=json","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA335A6F@CHN-SV-EXMX03.mchp-main.com/mbox/","series":[{"id":2489,"url":"http://patchwork.ozlabs.org/api/series/2489/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2489","date":"2017-09-11T12:32:10","name":"[v1,net] smsc95xx: Configure pause time to 0xffff when tx flow control enabled","version":1,"mbox":"http://patchwork.ozlabs.org/series/2489/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812375/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812375/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrS4F50YNz9s4q\n\tfor ;\n\tMon, 11 Sep 2017 22:32:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751908AbdIKMc1 convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 11 Sep 2017 08:32:27 -0400","from esa2.microchip.iphmx.com ([68.232.149.84]:48669 \"EHLO\n\tesa2.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751545AbdIKMc0 (ORCPT\n\t); Mon, 11 Sep 2017 08:32:26 -0400","from exsmtp02.microchip.com (HELO email.microchip.com)\n\t([198.175.253.38])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t11 Sep 2017 05:32:12 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH02.mchp-main.com ([::1]) with mapi id 14.03.0352.000;\n\tMon, 11 Sep 2017 05:32:11 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,377,1500966000\"; d=\"scan'208\";a=\"6887046\"","From":"","To":"","CC":", ,\n\t","Subject":"[PATCH v1 net] smsc95xx: Configure pause time to 0xffff when tx\n\tflow control enabled","Thread-Topic":"[PATCH v1 net] smsc95xx: Configure pause time to 0xffff when\n\ttx flow control enabled","Thread-Index":"AdMq77GJi6cy7gQHSOmBd4cH/HbXlQ==","Date":"Mon, 11 Sep 2017 12:32:10 +0000","Message-ID":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Nisar Sayed \n\nConfigure pause time to 0xffff when tx flow control enabled\n\nSet pause time to 0xffff in the pause frame to indicate the\npartner to stop sending the packets. When RX buffer frees up,\nthe device sends pause frame with pause time zero for partner to\nresume transmission.\n\nSigned-off-by: Nisar Sayed \n---\nv0 -> v1:\n * Added patch description in detail.\n---\n drivers/net/usb/smsc95xx.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c\nindex 340c134..309b88a 100644\n--- a/drivers/net/usb/smsc95xx.c\n+++ b/drivers/net/usb/smsc95xx.c\n@@ -526,7 +526,7 @@ static void smsc95xx_set_multicast(struct net_device *netdev)\n static int smsc95xx_phy_update_flowcontrol(struct usbnet *dev, u8 duplex,\n \t\t\t\t\t u16 lcladv, u16 rmtadv)\n {\n-\tu32 flow, afc_cfg = 0;\n+\tu32 flow = 0, afc_cfg;\n \n \tint ret = smsc95xx_read_reg(dev, AFC_CFG, &afc_cfg);\n \tif (ret < 0)\n@@ -537,20 +537,19 @@ static int smsc95xx_phy_update_flowcontrol(struct usbnet *dev, u8 duplex,\n \n \t\tif (cap & FLOW_CTRL_RX)\n \t\t\tflow = 0xFFFF0002;\n-\t\telse\n-\t\t\tflow = 0;\n \n-\t\tif (cap & FLOW_CTRL_TX)\n+\t\tif (cap & FLOW_CTRL_TX) {\n \t\t\tafc_cfg |= 0xF;\n-\t\telse\n+\t\t\tflow |= 0xFFFF0000;\n+\t\t} else {\n \t\t\tafc_cfg &= ~0xF;\n+\t\t}\n \n \t\tnetif_dbg(dev, link, dev->net, \"rx pause %s, tx pause %s\\n\",\n \t\t\t\t cap & FLOW_CTRL_RX ? \"enabled\" : \"disabled\",\n \t\t\t\t cap & FLOW_CTRL_TX ? \"enabled\" : \"disabled\");\n \t} else {\n \t\tnetif_dbg(dev, link, dev->net, \"half duplex\\n\");\n-\t\tflow = 0;\n \t\tafc_cfg |= 0xF;\n \t}\n \n","prefixes":["v1","net"]}