{"id":812361,"url":"http://patchwork.ozlabs.org/api/patches/812361/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-42-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911110623.24981-42-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-11T11:06:14","name":"[v3,41/50] qapi: add a 'unit' pragma","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"923e07f2fed8e05a36a0d78e58af1c01caed8e56","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-42-marcandre.lureau@redhat.com/mbox/","series":[{"id":2480,"url":"http://patchwork.ozlabs.org/api/series/2480/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2480","date":"2017-09-11T11:05:33","name":"Hi,","version":3,"mbox":"http://patchwork.ozlabs.org/series/2480/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812361/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812361/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrR690P6Nz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 21:49:05 +1000 (AEST)","from localhost ([::1]:56963 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1drND5-0007hu-6Z\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:49:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43657)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1drMZi-0006YU-Kw\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1drMZh-0007Dj-Jo\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:22 -0400","from mx1.redhat.com ([209.132.183.28]:56930)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1drMZh-0007Ch-DC\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:21 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8F4A01A2263;\n\tMon, 11 Sep 2017 11:08:20 +0000 (UTC)","from localhost (ovpn-112-47.ams2.redhat.com [10.36.112.47])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3530F5C548;\n\tMon, 11 Sep 2017 11:08:20 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8F4A01A2263","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 13:06:14 +0200","Message-Id":"<20170911110623.24981-42-marcandre.lureau@redhat.com>","In-Reply-To":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 11:08:20 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 41/50] qapi: add a 'unit' pragma","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\tarmbru@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Add a pragma that allows to tag the following expressions with a unit\nname. By default, an expression has no unit name.\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n scripts/qapi.py              | 9 ++++++++-\n docs/devel/qapi-code-gen.txt | 3 +++\n 2 files changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/scripts/qapi.py b/scripts/qapi.py\nindex eb4ffdc06d..1d0defd638 100644\n--- a/scripts/qapi.py\n+++ b/scripts/qapi.py\n@@ -279,10 +279,12 @@ class QAPISchemaParser(object):\n         self.docs = []\n         self.cur_doc = None\n         self.accept()\n+        self.unit = None\n \n         while self.tok is not None:\n             info = {'file': fname, 'line': self.line,\n-                    'parent': self.incl_info}\n+                    'parent': self.incl_info,\n+                    'unit': self.unit}\n             if self.tok == '#':\n                 self.reject_expr_doc()\n                 self.cur_doc = self.get_doc(info)\n@@ -371,6 +373,11 @@ class QAPISchemaParser(object):\n                                    \"Pragma name-case-whitelist must be\"\n                                    \" a list of strings\")\n             name_case_whitelist = value\n+        elif name == 'unit':\n+            if not isinstance(value, str):\n+                raise QAPISemError(info,\n+                                   \"Pragma 'unit' must be string\")\n+            self.unit = value\n         else:\n             raise QAPISemError(info, \"Unknown pragma '%s'\" % name)\n \ndiff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt\nindex 24fc6f74ee..37a27cd9d7 100644\n--- a/docs/devel/qapi-code-gen.txt\n+++ b/docs/devel/qapi-code-gen.txt\n@@ -326,6 +326,9 @@ violate the rules on permitted return types.  Default is none.\n Pragma 'name-case-whitelist' takes a list of names that may violate\n rules on use of upper- vs. lower-case letters.  Default is none.\n \n+Pragma 'unit' takes a string value. It will set the unit name for the\n+following expressions in the schema. Most code generator can filter\n+based on a unit name. Default is none.\n \n === Struct types ===\n \n","prefixes":["v3","41/50"]}