{"id":812355,"url":"http://patchwork.ozlabs.org/api/patches/812355/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-43-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911110623.24981-43-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-11T11:06:15","name":"[v3,42/50] qapi: add a -u/--unit option to specify which unit to visit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"45955d871efe6c1b60567c48261763b1b885c871","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-43-marcandre.lureau@redhat.com/mbox/","series":[{"id":2480,"url":"http://patchwork.ozlabs.org/api/series/2480/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2480","date":"2017-09-11T11:05:33","name":"Hi,","version":3,"mbox":"http://patchwork.ozlabs.org/series/2480/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812355/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812355/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQwk4bdWz9sBd\n\tfor ;\n\tMon, 11 Sep 2017 21:40:54 +1000 (AEST)","from localhost ([::1]:56916 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drN59-0001co-Nr\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:40:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43686)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMZm-0006bv-Ee\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMZl-0007HI-Cw\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:26 -0400","from mx1.redhat.com ([209.132.183.28]:41338)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drMZl-0007Gt-48\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:25 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4E924C0D8D46;\n\tMon, 11 Sep 2017 11:08:24 +0000 (UTC)","from localhost (ovpn-112-47.ams2.redhat.com [10.36.112.47])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 00E235DD60;\n\tMon, 11 Sep 2017 11:08:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4E924C0D8D46","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 13:06:15 +0200","Message-Id":"<20170911110623.24981-43-marcandre.lureau@redhat.com>","In-Reply-To":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 11 Sep 2017 11:08:24 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 42/50] qapi: add a -u/--unit option to\n\tspecify which unit to visit","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tarmbru@redhat.com, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Allow to filter expressions based on unit name.\n\nBy default, only default units are processed (unspecified pragma).\n\n'all' will include all units. Anything else will filter by unit name.\n\n(add a FIXME to make implicit array types use the element type unit,\nnot the unit of the first expression using that array type. This isn't\nnecessary for now, and I am not sure how to best do it yet)\n\nSigned-off-by: Marc-André Lureau \n---\n scripts/qapi.py | 14 ++++++++++++--\n scripts/qapi2texi.py | 1 +\n 2 files changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/scripts/qapi.py b/scripts/qapi.py\nindex 1d0defd638..7778585819 100644\n--- a/scripts/qapi.py\n+++ b/scripts/qapi.py\n@@ -47,6 +47,9 @@ returns_whitelist = []\n # Whitelist of entities allowed to violate case conventions\n name_case_whitelist = []\n \n+# Unit to consider for the visit, 'all' for all units\n+visit_unit = None\n+\n enum_types = {}\n struct_types = {}\n union_types = {}\n@@ -1796,6 +1799,10 @@ class QAPISchema(object):\n def visit(self, visitor):\n visitor.visit_begin(self)\n for (name, entity) in sorted(self._entity_dict.items()):\n+ # FIXME: implicit array types should use element type unit\n+ unit = entity.info and entity.info.get('unit')\n+ if visit_unit != 'all' and visit_unit != unit:\n+ continue\n if visitor.visit_needed(entity):\n entity.visit(visitor)\n visitor.visit_end()\n@@ -2103,13 +2110,14 @@ def parse_command_line(extra_options='', extra_long_options=[]):\n \n try:\n opts, args = getopt.gnu_getopt(sys.argv[1:],\n- 'chp:o:i:' + extra_options,\n+ 'chp:o:u:i:' + extra_options,\n ['source', 'header', 'prefix=', 'output-dir=',\n- 'include='] + extra_long_options)\n+ 'unit=', 'include='] + extra_long_options)\n except getopt.GetoptError as err:\n print >>sys.stderr, \"%s: %s\" % (sys.argv[0], str(err))\n sys.exit(1)\n \n+ global visit_unit\n output_dir = ''\n prefix = ''\n do_c = False\n@@ -2129,6 +2137,8 @@ def parse_command_line(extra_options='', extra_long_options=[]):\n prefix = a\n elif o in ('-o', '--output-dir'):\n output_dir = a + '/'\n+ elif o in ('-u', '--unit'):\n+ visit_unit = a\n elif o in ('-c', '--source'):\n do_c = True\n elif o in ('-h', '--header'):\ndiff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py\nindex 4e7b1cda87..6c856d4cb7 100755\n--- a/scripts/qapi2texi.py\n+++ b/scripts/qapi2texi.py\n@@ -293,6 +293,7 @@ def main(argv):\n print >>sys.stderr, \"%s: need exactly 1 argument: SCHEMA\" % argv[0]\n sys.exit(1)\n \n+ qapi.visit_unit = 'all'\n schema = qapi.QAPISchema(argv[1])\n if not qapi.doc_required:\n print >>sys.stderr, (\"%s: need pragma 'doc-required' \"\n","prefixes":["v3","42/50"]}