{"id":812338,"url":"http://patchwork.ozlabs.org/api/patches/812338/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-40-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911110623.24981-40-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-11T11:06:12","name":"[v3,39/50] qapi-commands: don't initialize command list in qmp_init_marshall()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2ff3ad9188d51bcdd27aa4de6ce034fd35438fce","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-40-marcandre.lureau@redhat.com/mbox/","series":[{"id":2480,"url":"http://patchwork.ozlabs.org/api/series/2480/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2480","date":"2017-09-11T11:05:33","name":"Hi,","version":3,"mbox":"http://patchwork.ozlabs.org/series/2480/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812338/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812338/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQZL4TKvz9sBd\n\tfor ;\n\tMon, 11 Sep 2017 21:24:58 +1000 (AEST)","from localhost ([::1]:56814 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drMpk-0003Vh-L0\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:24:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43631)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMZg-0006Vt-75\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMZe-00079a-Gg\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:20 -0400","from mx1.redhat.com ([209.132.183.28]:37758)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drMZe-00078z-Ah\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:08:18 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6798254F53;\n\tMon, 11 Sep 2017 11:08:17 +0000 (UTC)","from localhost (ovpn-112-47.ams2.redhat.com [10.36.112.47])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 65E006A740;\n\tMon, 11 Sep 2017 11:08:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6798254F53","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 13:06:12 +0200","Message-Id":"<20170911110623.24981-40-marcandre.lureau@redhat.com>","In-Reply-To":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 11 Sep 2017 11:08:17 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 39/50] qapi-commands: don't initialize\n\tcommand list in qmp_init_marshall()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lu?=\n\t=?utf-8?q?reau?= , armbru@redhat.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This will let the caller add several list of commands.\n\nSigned-off-by: Marc-André Lureau \n---\n scripts/qapi-commands.py | 2 --\n monitor.c | 1 +\n qga/main.c | 1 +\n tests/test-qmp-commands.c | 1 +\n 4 files changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py\nindex 8af8d913b9..7455d2b8bb 100644\n--- a/scripts/qapi-commands.py\n+++ b/scripts/qapi-commands.py\n@@ -211,8 +211,6 @@ def gen_registry(registry):\n \n void %(c_prefix)sqmp_init_marshal(QmpCommandList *cmds)\n {\n- QTAILQ_INIT(cmds);\n-\n ''',\n c_prefix=c_name(prefix, protect=False))\n ret += registry\ndiff --git a/monitor.c b/monitor.c\nindex b5ddcf8c67..bf8a7685bf 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -1001,6 +1001,7 @@ void monitor_init_qmp_commands(void)\n * \"qmp_capabilities\", to enforce capability negotiation\n */\n \n+ QTAILQ_INIT(&qmp_commands);\n qmp_init_marshal(&qmp_commands);\n \n qmp_register_command(&qmp_commands, \"query-qmp-schema\",\ndiff --git a/qga/main.c b/qga/main.c\nindex 62a62755bd..b949b1ccb0 100644\n--- a/qga/main.c\n+++ b/qga/main.c\n@@ -1360,6 +1360,7 @@ int main(int argc, char **argv)\n \n config->log_level = G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL;\n \n+ QTAILQ_INIT(&ga_commands);\n qga_qmp_init_marshal(&ga_commands);\n \n init_dfl_pathnames();\ndiff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c\nindex ad7b6e4e1d..28ce88e012 100644\n--- a/tests/test-qmp-commands.c\n+++ b/tests/test-qmp-commands.c\n@@ -283,6 +283,7 @@ int main(int argc, char **argv)\n g_test_add_func(\"/0.15/dealloc_types\", test_dealloc_types);\n g_test_add_func(\"/0.15/dealloc_partial\", test_dealloc_partial);\n \n+ QTAILQ_INIT(&qmp_commands);\n test_qmp_init_marshal(&qmp_commands);\n g_test_run();\n \n","prefixes":["v3","39/50"]}