{"id":812319,"url":"http://patchwork.ozlabs.org/api/patches/812319/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-10-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911110623.24981-10-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-11T11:05:42","name":"[v3,09/50] qapi: add #if/#endif helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bc79195134673f2e0213a3010b762f62e7919627","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-10-marcandre.lureau@redhat.com/mbox/","series":[{"id":2480,"url":"http://patchwork.ozlabs.org/api/series/2480/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2480","date":"2017-09-11T11:05:33","name":"Hi,","version":3,"mbox":"http://patchwork.ozlabs.org/series/2480/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812319/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812319/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQJS1fDnz9s7G\n\tfor ;\n\tMon, 11 Sep 2017 21:12:56 +1000 (AEST)","from localhost ([::1]:56764 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drMe6-0001Qi-6m\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:12:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42815)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMYM-00057u-8J\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:07:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMYI-0006Ah-Ci\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:06:58 -0400","from mx1.redhat.com ([209.132.183.28]:58306)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drMYI-0006AY-6q\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:06:54 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5B6A11A2263;\n\tMon, 11 Sep 2017 11:06:53 +0000 (UTC)","from localhost (ovpn-112-47.ams2.redhat.com [10.36.112.47])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3AB755C684;\n\tMon, 11 Sep 2017 11:06:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5B6A11A2263","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 13:05:42 +0200","Message-Id":"<20170911110623.24981-10-marcandre.lureau@redhat.com>","In-Reply-To":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 11:06:53 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 09/50] qapi: add #if/#endif helpers","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tarmbru@redhat.com, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Add helpers to wrap generated code with #if/#endif lines.\n\nAdd a function decorator that will be used to wrap visitor methods.\nThe decorator will check if code was generated before adding #if/#endif\nlines. Used in the following patches.\n\nSigned-off-by: Marc-André Lureau \n---\n scripts/qapi.py | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)","diff":"diff --git a/scripts/qapi.py b/scripts/qapi.py\nindex 2a8e60e975..94b735d8d6 100644\n--- a/scripts/qapi.py\n+++ b/scripts/qapi.py\n@@ -1897,6 +1897,61 @@ def guardend(name):\n name=guardname(name))\n \n \n+def gen_if(ifcond):\n+ if not ifcond:\n+ return ''\n+ if isinstance(ifcond, str):\n+ ifcond = [ifcond]\n+ ret = ''\n+ for ifc in ifcond:\n+ ret += mcgen('''\n+#if %(cond)s\n+''', cond=ifc)\n+ return ret\n+\n+\n+def gen_endif(ifcond):\n+ if not ifcond:\n+ return ''\n+ if isinstance(ifcond, str):\n+ ifcond = [ifcond]\n+ ret = ''\n+ for ifc in reversed(ifcond):\n+ ret += mcgen('''\n+#endif /* %(cond)s */\n+''', cond=ifc)\n+ return ret\n+\n+\n+# Wrap a method to add #if / #endif to generated code, only if some\n+# code was generated. The method must have an 'ifcond' argument.\n+# self must have 'if_members' listing the attributes to wrap.\n+def ifcond_decorator(func):\n+\n+ def func_wrapper(self, *args, **kwargs):\n+ import inspect\n+ idx = inspect.getargspec(func).args.index('ifcond')\n+ ifcond = args[idx - 1]\n+ save = {}\n+ for mem in self.if_members:\n+ save[mem] = getattr(self, mem)\n+ func(self, *args, **kwargs)\n+ for mem, val in save.items():\n+ newval = getattr(self, mem)\n+ if newval != val:\n+ assert newval.startswith(val)\n+ newval = newval[len(val):]\n+ if newval[0] == '\\n':\n+ val += '\\n'\n+ newval = newval[1:]\n+ val += gen_if(ifcond)\n+ val += newval\n+ val += gen_endif(ifcond)\n+ setattr(self, mem, val)\n+\n+ return func_wrapper\n+\n+\n def gen_enum_lookup(name, values, prefix=None):\n ret = mcgen('''\n \n","prefixes":["v3","09/50"]}