{"id":812316,"url":"http://patchwork.ozlabs.org/api/patches/812316/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-6-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170911110623.24981-6-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-11T11:05:38","name":"[v3,05/50] qapi: add tests for invalid 'if'","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec61d49274f52f1c8d663a53aa5e3d6514b129bb","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170911110623.24981-6-marcandre.lureau@redhat.com/mbox/","series":[{"id":2480,"url":"http://patchwork.ozlabs.org/api/series/2480/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2480","date":"2017-09-11T11:05:33","name":"Hi,","version":3,"mbox":"http://patchwork.ozlabs.org/series/2480/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812316/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812316/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQFP6vd9z9s7G\n\tfor ;\n\tMon, 11 Sep 2017 21:10:17 +1000 (AEST)","from localhost ([::1]:56749 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drMbY-0007Xo-1U\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:10:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42652)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMY9-0004vh-P4\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:06:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMY5-00062w-QO\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:06:45 -0400","from mx1.redhat.com ([209.132.183.28]:34726)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drMY5-00062j-HX\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:06:41 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9F5D754F53;\n\tMon, 11 Sep 2017 11:06:40 +0000 (UTC)","from localhost (ovpn-112-47.ams2.redhat.com [10.36.112.47])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 360AC5C269;\n\tMon, 11 Sep 2017 11:06:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9F5D754F53","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Mon, 11 Sep 2017 13:05:38 +0200","Message-Id":"<20170911110623.24981-6-marcandre.lureau@redhat.com>","In-Reply-To":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 11 Sep 2017 11:06:40 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 05/50] qapi: add tests for invalid 'if'","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tarmbru@redhat.com, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Marc-André Lureau \n---\n tests/Makefile.include | 3 +++\n tests/qapi-schema/bad-if-empty-list.err | 1 +\n tests/qapi-schema/bad-if-empty-list.exit | 1 +\n tests/qapi-schema/bad-if-empty-list.json | 3 +++\n tests/qapi-schema/bad-if-empty-list.out | 0\n tests/qapi-schema/bad-if-empty.err | 1 +\n tests/qapi-schema/bad-if-empty.exit | 1 +\n tests/qapi-schema/bad-if-empty.json | 3 +++\n tests/qapi-schema/bad-if-empty.out | 0\n tests/qapi-schema/bad-if.err | 1 +\n tests/qapi-schema/bad-if.exit | 1 +\n tests/qapi-schema/bad-if.json | 3 +++\n tests/qapi-schema/bad-if.out | 0\n 13 files changed, 18 insertions(+)\n create mode 100644 tests/qapi-schema/bad-if-empty-list.err\n create mode 100644 tests/qapi-schema/bad-if-empty-list.exit\n create mode 100644 tests/qapi-schema/bad-if-empty-list.json\n create mode 100644 tests/qapi-schema/bad-if-empty-list.out\n create mode 100644 tests/qapi-schema/bad-if-empty.err\n create mode 100644 tests/qapi-schema/bad-if-empty.exit\n create mode 100644 tests/qapi-schema/bad-if-empty.json\n create mode 100644 tests/qapi-schema/bad-if-empty.out\n create mode 100644 tests/qapi-schema/bad-if.err\n create mode 100644 tests/qapi-schema/bad-if.exit\n create mode 100644 tests/qapi-schema/bad-if.json\n create mode 100644 tests/qapi-schema/bad-if.out\n\ndiff --git a/tests/qapi-schema/bad-if.out b/tests/qapi-schema/bad-if.out\nnew file mode 100644\nindex 0000000000..e69de29bb2","diff":"diff --git a/tests/Makefile.include b/tests/Makefile.include\nindex fae5715e9c..8dac7c9083 100644\n--- a/tests/Makefile.include\n+++ b/tests/Makefile.include\n@@ -402,6 +402,9 @@ qapi-schema += args-unknown.json\n qapi-schema += bad-base.json\n qapi-schema += bad-data.json\n qapi-schema += bad-ident.json\n+qapi-schema += bad-if.json\n+qapi-schema += bad-if-empty.json\n+qapi-schema += bad-if-empty-list.json\n qapi-schema += bad-type-bool.json\n qapi-schema += bad-type-dict.json\n qapi-schema += bad-type-int.json\ndiff --git a/tests/qapi-schema/bad-if-empty-list.err b/tests/qapi-schema/bad-if-empty-list.err\nnew file mode 100644\nindex 0000000000..75fe6497bc\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty-list.err\n@@ -0,0 +1 @@\n+tests/qapi-schema/bad-if-empty-list.json:2: 'if' condition [] is useless\ndiff --git a/tests/qapi-schema/bad-if-empty-list.exit b/tests/qapi-schema/bad-if-empty-list.exit\nnew file mode 100644\nindex 0000000000..d00491fd7e\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty-list.exit\n@@ -0,0 +1 @@\n+1\ndiff --git a/tests/qapi-schema/bad-if-empty-list.json b/tests/qapi-schema/bad-if-empty-list.json\nnew file mode 100644\nindex 0000000000..94f2eb8670\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty-list.json\n@@ -0,0 +1,3 @@\n+# check empty 'if' list\n+{ 'struct': 'TestIfStruct', 'data': { 'foo': 'int' },\n+ 'if': [] }\ndiff --git a/tests/qapi-schema/bad-if-empty-list.out b/tests/qapi-schema/bad-if-empty-list.out\nnew file mode 100644\nindex 0000000000..e69de29bb2\ndiff --git a/tests/qapi-schema/bad-if-empty.err b/tests/qapi-schema/bad-if-empty.err\nnew file mode 100644\nindex 0000000000..358bdc3e51\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty.err\n@@ -0,0 +1 @@\n+tests/qapi-schema/bad-if-empty.json:2: 'if' condition '' makes no sense\ndiff --git a/tests/qapi-schema/bad-if-empty.exit b/tests/qapi-schema/bad-if-empty.exit\nnew file mode 100644\nindex 0000000000..d00491fd7e\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty.exit\n@@ -0,0 +1 @@\n+1\ndiff --git a/tests/qapi-schema/bad-if-empty.json b/tests/qapi-schema/bad-if-empty.json\nnew file mode 100644\nindex 0000000000..fe1dd4eca6\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if-empty.json\n@@ -0,0 +1,3 @@\n+# check empty 'if'\n+{ 'struct': 'TestIfStruct', 'data': { 'foo': 'int' },\n+ 'if': '' }\ndiff --git a/tests/qapi-schema/bad-if-empty.out b/tests/qapi-schema/bad-if-empty.out\nnew file mode 100644\nindex 0000000000..e69de29bb2\ndiff --git a/tests/qapi-schema/bad-if.err b/tests/qapi-schema/bad-if.err\nnew file mode 100644\nindex 0000000000..c2e3f5f44c\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if.err\n@@ -0,0 +1 @@\n+tests/qapi-schema/bad-if.json:2: 'if' condition must be a string or a list of strings\ndiff --git a/tests/qapi-schema/bad-if.exit b/tests/qapi-schema/bad-if.exit\nnew file mode 100644\nindex 0000000000..d00491fd7e\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if.exit\n@@ -0,0 +1 @@\n+1\ndiff --git a/tests/qapi-schema/bad-if.json b/tests/qapi-schema/bad-if.json\nnew file mode 100644\nindex 0000000000..3edd1a0bf2\n--- /dev/null\n+++ b/tests/qapi-schema/bad-if.json\n@@ -0,0 +1,3 @@\n+# check invalid 'if' type\n+{ 'struct': 'TestIfStruct', 'data': { 'foo': 'int' },\n+ 'if': { 'value': 'defined(TEST_IF_STRUCT)' } }\n","prefixes":["v3","05/50"]}