{"id":812288,"url":"http://patchwork.ozlabs.org/api/patches/812288/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505122921-5534-9-git-send-email-bmeng.cn@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505122921-5534-9-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-09-11T09:41:58","name":"[v2,08/10] spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5cf5fa40a4cce2c3dfa848b73d265076f624405a","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":63396,"url":"http://patchwork.ozlabs.org/api/users/63396/?format=json","username":"cpitchen","first_name":"Cyrille","last_name":"Pitchen","email":"cyrille.pitchen@atmel.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505122921-5534-9-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":2464,"url":"http://patchwork.ozlabs.org/api/series/2464/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2464","date":"2017-09-11T09:41:50","name":"spi-nor: intel-spi: Various fixes and enhancements","version":2,"mbox":"http://patchwork.ozlabs.org/series/2464/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812288/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812288/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"YaNajHzq\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"que0Xu5M\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrNGr1n32z9s7G\n\tfor ;\n\tMon, 11 Sep 2017 19:41:24 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drLDU-0001Of-0Q; Mon, 11 Sep 2017 09:41:20 +0000","from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drLAV-0006CF-H1\n\tfor linux-mtd@lists.infradead.org; Mon, 11 Sep 2017 09:38:18 +0000","by mail-it0-x243.google.com with SMTP id z81so3847006itb.5\n\tfor ;\n\tMon, 11 Sep 2017 02:37:55 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\ts2sm4121069ioa.2.2017.09.11.02.37.52\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 11 Sep 2017 02:37:53 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=VPmaXaRXD47E5J8A/6asFz6DfjloSawkGP9mmVjFt34=;\n\tb=YaNajHzqnl1VRM935ZOu0PsnXo\n\tQPmLYvEhE5wl09WQa4rLLm4h/yGphjVXpVfIYNYtnFC+ajwZ36qL2b6l4tWWT3FWNSRajx7j4ZFaS\n\tAViN56zwUOj5Il8Pz+VCvzBqBsd1i/ew6gE5y8NOYBM/6xIg3DSTYzCeTsedNq8uoECh2rF3OAJEk\n\tKlJCpp6m8Bl1gIiNZ9h3e6HwyktXKpTxITKK3VkBpI3Q501AWhjojcxo1Hbt46wkmj+pbcIBbxHom\n\tj25Uf3ODlhwjO5Ju6KIyipQeb7+nIQ7XR273zhH8qy0e5wqU18eUZS9QslhgJdEHzJ0LweOwsGeO1\n\tTZCFUhNA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=y0AEb1unnm+O6sNEjmj4Ph9LgEuSqsa07gLISdJZT8I=;\n\tb=que0Xu5MmPvsxZ7LIYRKTCkjE592ePnrhBEbh9ym5qQ6bOgvSfdEnoUL5dzUyZIM3t\n\trBCdUNSFLOp0hv8hcY75ogRUUtbPWDDgRud9+osEJ/CoF4Y4Dw0POu//DLuZvSPXa/kr\n\tubwXEe8BsQ7fH03T4qxG2W5bLyPBz+/zUtjv09km6F0RjWttzAzutXhH4OcZhVuEdT8x\n\troLv17rRIpP87LR2PN36IYvQycMDuzZN42JJr69BwQ2/JRV++HOjuRlNeX97Cx+ve0+5\n\tNekjAUMuXUUlHYXS8R/qvwI58jXKNqe3e+1o5EbuYi77tLTUmzKLkbAKPRBv3Dwq6OfD\n\tMDlg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=y0AEb1unnm+O6sNEjmj4Ph9LgEuSqsa07gLISdJZT8I=;\n\tb=XVBKFjwj6JKZFYDb0TYSdQjj298S3CcisoGKop9y0RqjWCuYig74iODhw74sbsQCl5\n\tYXcY++YNh+/w9lPFPT8Pv4sx8xSmvrmqgZ0BLJgbJ4o7obT46ZtLkjE7LEQs3ewgo04g\n\t4Yq4HyJ+xeLqWr0ESw9xD6NRcRwM/rS9pL3ReqqZpzvpiqFMeQQGpw5V8Mx+WPToTMBF\n\tIZNScw4yr6G3Vu84xHUX3xmIi6HaC4BHQniS8HHODyo1rA9G74IhwOGH6JTPTfpOeK5z\n\tBeKv/PWJ1HqOYn8n8Aa7lcB13j/f3C8mmANNTmK1BYRf1J0t5Dq5ikYEZ3kHz2aZO1Nm\n\thWmg==","X-Gm-Message-State":"AHPjjUh8+W4ZcvLKEFXymqSqv/XdbzvswGkSO2fwK6KvvzSFZOzggX3O\n\t0nDC+AT+nFmIlQ==","X-Google-Smtp-Source":"ADKCNb4r7guKrTOUGtF06yciJaoL/yr6EjMVXjsFxFmCC/b8Wdm7OzvibZWdIAupS0WhvEyOj1zdqw==","X-Received":"by 10.36.194.196 with SMTP id\n\ti187mr13786807itg.103.1505122674614; \n\tMon, 11 Sep 2017 02:37:54 -0700 (PDT)","From":"Bin Meng ","To":"Mika Westerberg ,\n\tCyrille Pitchen ,\n\tMarek Vasut ,\n\tBoris Brezillon ,\n\tBrian Norris ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tlinux-mtd ,\n\tlinux-kernel ","Subject":"[PATCH v2 08/10] spi-nor: intel-spi: Remove the unnecessary HSFSTS\n\tregister RW","Date":"Mon, 11 Sep 2017 02:41:58 -0700","Message-Id":"<1505122921-5534-9-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1505122921-5534-1-git-send-email-bmeng.cn@gmail.com>","References":"<1505122921-5534-1-git-send-email-bmeng.cn@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170911_023815_744913_A6D253D3 ","X-CRM114-Status":"GOOD ( 10.49 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:4001:c0b:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (bmeng.cn[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Roese ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"There is no code that alters the HSFSTS register content in between\nin intel_spi_write(). Remove the unnecessary RW to save some cycles.\n\nSigned-off-by: Bin Meng \nAcked-by: Mika Westerberg \n---\n\nChanges in v2: None\n\n drivers/mtd/spi-nor/intel-spi.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c\nindex 07146ab..91ceef7 100644\n--- a/drivers/mtd/spi-nor/intel-spi.c\n+++ b/drivers/mtd/spi-nor/intel-spi.c\n@@ -611,7 +611,6 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len,\n \t\tval |= HSFSTS_CTL_AEL | HSFSTS_CTL_FCERR | HSFSTS_CTL_FDONE;\n \t\tval |= (block_size - 1) << HSFSTS_CTL_FDBC_SHIFT;\n \t\tval |= HSFSTS_CTL_FCYCLE_WRITE;\n-\t\twritel(val, ispi->base + HSFSTS_CTL);\n \n \t\tret = intel_spi_write_block(ispi, write_buf, block_size);\n \t\tif (ret) {\n@@ -620,8 +619,8 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len,\n \t\t}\n \n \t\t/* Start the write now */\n-\t\tval = readl(ispi->base + HSFSTS_CTL);\n-\t\twritel(val | HSFSTS_CTL_FGO, ispi->base + HSFSTS_CTL);\n+\t\tval |= HSFSTS_CTL_FGO;\n+\t\twritel(val, ispi->base + HSFSTS_CTL);\n \n \t\tret = intel_spi_wait_hw_busy(ispi);\n \t\tif (ret) {\n","prefixes":["v2","08/10"]}