{"id":812283,"url":"http://patchwork.ozlabs.org/api/patches/812283/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505122921-5534-3-git-send-email-bmeng.cn@gmail.com/","project":{"id":3,"url":"http://patchwork.ozlabs.org/api/projects/3/?format=json","name":"Linux MTD development","link_name":"linux-mtd","list_id":"linux-mtd.lists.infradead.org","list_email":"linux-mtd@lists.infradead.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505122921-5534-3-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-09-11T09:41:52","name":"[v2,02/10] spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d2864ee34effa023b99a3d5196494b347e4ac2d6","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":63396,"url":"http://patchwork.ozlabs.org/api/users/63396/?format=json","username":"cpitchen","first_name":"Cyrille","last_name":"Pitchen","email":"cyrille.pitchen@atmel.com"},"mbox":"http://patchwork.ozlabs.org/project/linux-mtd/patch/1505122921-5534-3-git-send-email-bmeng.cn@gmail.com/mbox/","series":[{"id":2464,"url":"http://patchwork.ozlabs.org/api/series/2464/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-mtd/list/?series=2464","date":"2017-09-11T09:41:50","name":"spi-nor: intel-spi: Various fixes and enhancements","version":2,"mbox":"http://patchwork.ozlabs.org/series/2464/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812283/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812283/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"H74866iF\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rfB814Nr\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrNDh2ptNz9s7G\n\tfor ;\n\tMon, 11 Sep 2017 19:39:32 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drLBc-00072U-5R; Mon, 11 Sep 2017 09:39:24 +0000","from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drLAJ-000692-Ih\n\tfor linux-mtd@lists.infradead.org; Mon, 11 Sep 2017 09:38:05 +0000","by mail-it0-x242.google.com with SMTP id b76so3843407itb.2\n\tfor ;\n\tMon, 11 Sep 2017 02:37:43 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\ts2sm4121069ioa.2.2017.09.11.02.37.40\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 11 Sep 2017 02:37:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References:\n\tIn-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=fOOG1sBQaEftHArQDuSSiE6VqUWgDCSwlk+MLoaARkg=;\n\tb=H74866iFUeHJow52Gckrc29593\n\tE7xLaUlMuuwRVdnxPv78GacxrFJbesFp7aDFd6PXm1gHfY9RAftMloI4z2beTBt7ANi1e5nZGwpU0\n\tFxznRXMFp4TvT9Khg8InSy6xpLZ/KxWoS9e2BKHtEut4HkgqB8VZSG0LGCrYyiGR7g0GWs10y/wxV\n\tCn+a54YBxfljR1NrkvAWFHVKCLDceoZH8Ib+++pkKo10dmANOptmm2g9rcl8gB0TKXZ3rz+wXa948\n\tZHMKTtxHGgawU+0Jv3XtzhRB2CWZFHDPbdjGrToCvv9FFREgnOSztbo0FaH1bQ8wPcf9IpUBBB6xb\n\tF6tIaypA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=p06Bbt8PWUBC5WuvFJvoEHCgJFg+vtYCcVHsjAWE5Xg=;\n\tb=rfB814NrrA/sG1Sd/zkHv30g0+R7FqcwzKZh9yBwvrFShyYTLbZQlnsvPKkfGj8OVh\n\tVkFGa5kZfDkoodntmwudDcalGZHpAHZNlUQ02D8s9tCSzXZUjotXqtaX9Ns0h2IUTRZs\n\t+32xfvhXyoqRH2ghUG4ADcZxysaOTYWIVcEmWJHxSTgZWYZKsNc0nG9/rt4bWOawQQDi\n\tQb2SaVUR/vQHAL9jHjTbgeIdPwhe9GYJKtlv6yjb4bq7HAMXTLhhR0QsHs1T4Mdytx1l\n\tTrPou7gtxNu/UNk44g3lc5CibxzFDtMqDI48j/4FGGi01l9VYLS1Uq5tH+/2me7ChAAZ\n\tYtmw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=p06Bbt8PWUBC5WuvFJvoEHCgJFg+vtYCcVHsjAWE5Xg=;\n\tb=Zp78TJ2ETPZvT1DKc6sHNfQj5Gb5BDmiZLzY1a7HBOVGct0x2Eg0FdUHutfGpelZM8\n\tNfAO8CS5nUaR4U0Vw3YQ22Bv0Etv59jPtJ2Rw3P5+whZClioj2AyhT/N2LnhYK0gc6DO\n\t5eXl3ABjo6x49i3A9TbI6qvncXScoqavKlyJ8+LV2+EdxlbpyNzyrF6TT5CwQwqPE93F\n\toIqeFwNvH3piMXIggWYoDsnGi/nQRJznv5nCxsyY95PS5HwgZLYGBNQ9mY32T/Rqg/V9\n\tZsodHryvGYpfUDu2cpCHgx+oZQIneIO4E6S6f37jOP3bMg3j1Z0jvakYHEAM/OW7YOYf\n\tDkoQ==","X-Gm-Message-State":"AHPjjUiSpCItcANDRzgH+4fTgMqfJup6vgb7rmFzVVgdPz0gjBNQX78Z\n\tNIhZh98SucSdsZMwTajTeqw=","X-Google-Smtp-Source":"AOwi7QDSmVVLAKcnMnDmFuNovizlO9GBoXbWgqNpPATSlVl+8gmv1K0iJ9s53SX0hJpH+vuGCRpIGQ==","X-Received":"by 10.36.172.6 with SMTP id s6mr3651506ite.113.1505122662666;\n\tMon, 11 Sep 2017 02:37:42 -0700 (PDT)","From":"Bin Meng ","To":"Mika Westerberg ,\n\tCyrille Pitchen ,\n\tMarek Vasut ,\n\tBoris Brezillon ,\n\tBrian Norris ,\n\tRichard Weinberger ,\n\tDavid Woodhouse , \n\tlinux-mtd ,\n\tlinux-kernel ","Subject":"[PATCH v2 02/10] spi-nor: intel-spi: Remove useless 'buf' parameter\n\tin the HW/SW cycle","Date":"Mon, 11 Sep 2017 02:41:52 -0700","Message-Id":"<1505122921-5534-3-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1505122921-5534-1-git-send-email-bmeng.cn@gmail.com>","References":"<1505122921-5534-1-git-send-email-bmeng.cn@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170911_023803_670172_2E41BF73 ","X-CRM114-Status":"GOOD ( 10.13 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:4001:c0b:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (bmeng.cn[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Roese ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"intel_spi_hw_cycle() and intel_spi_sw_cycle() don't use the parameter\n'buf' at all. Remove it.\n\nSigned-off-by: Bin Meng \nAcked-by: Mika Westerberg \n---\n\nChanges in v2: None\n\n drivers/mtd/spi-nor/intel-spi.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c\nindex e5b52e8..07626ca 100644\n--- a/drivers/mtd/spi-nor/intel-spi.c\n+++ b/drivers/mtd/spi-nor/intel-spi.c\n@@ -377,8 +377,7 @@ static int intel_spi_opcode_index(struct intel_spi *ispi, u8 opcode)\n \treturn -EINVAL;\n }\n \n-static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n-\t\t\t int len)\n+static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, int len)\n {\n \tu32 val, status;\n \tint ret;\n@@ -418,8 +417,7 @@ static int intel_spi_hw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n \treturn 0;\n }\n \n-static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, u8 *buf,\n-\t\t\t int len)\n+static int intel_spi_sw_cycle(struct intel_spi *ispi, u8 opcode, int len)\n {\n \tu32 val, status;\n \tint ret;\n@@ -456,9 +454,9 @@ static int intel_spi_read_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)\n \twritel(0, ispi->base + FADDR);\n \n \tif (ispi->swseq)\n-\t\tret = intel_spi_sw_cycle(ispi, opcode, buf, len);\n+\t\tret = intel_spi_sw_cycle(ispi, opcode, len);\n \telse\n-\t\tret = intel_spi_hw_cycle(ispi, opcode, buf, len);\n+\t\tret = intel_spi_hw_cycle(ispi, opcode, len);\n \n \tif (ret)\n \t\treturn ret;\n@@ -486,8 +484,8 @@ static int intel_spi_write_reg(struct spi_nor *nor, u8 opcode, u8 *buf, int len)\n \t\treturn ret;\n \n \tif (ispi->swseq)\n-\t\treturn intel_spi_sw_cycle(ispi, opcode, buf, len);\n-\treturn intel_spi_hw_cycle(ispi, opcode, buf, len);\n+\t\treturn intel_spi_sw_cycle(ispi, opcode, len);\n+\treturn intel_spi_hw_cycle(ispi, opcode, len);\n }\n \n static ssize_t intel_spi_read(struct spi_nor *nor, loff_t from, size_t len,\n","prefixes":["v2","02/10"]}