{"id":812193,"url":"http://patchwork.ozlabs.org/api/patches/812193/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505091651-55964-2-git-send-email-xiangxia.m.yue@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505091651-55964-2-git-send-email-xiangxia.m.yue@gmail.com>","list_archive_url":null,"date":"2017-09-11T01:00:50","name":"[ovs-dev,1/2] datapath: Optimize updating for OvS flow_stats.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"50f9d1da6229da1bdfa60475a1bca6e75f0ffaf2","submitter":{"id":71877,"url":"http://patchwork.ozlabs.org/api/people/71877/?format=json","name":"Tonghao Zhang","email":"xiangxia.m.yue@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1505091651-55964-2-git-send-email-xiangxia.m.yue@gmail.com/mbox/","series":[{"id":2423,"url":"http://patchwork.ozlabs.org/api/series/2423/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2423","date":"2017-09-11T01:00:49","name":"datapath: Optimize operations for OvS flow_stats.","version":1,"mbox":"http://patchwork.ozlabs.org/series/2423/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812193/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812193/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"J12DpP2X\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xr8lR0HfMz9rvt\n\tfor ;\n\tMon, 11 Sep 2017 11:01:55 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 1FAC693C;\n\tMon, 11 Sep 2017 01:01:19 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E58B48FF\n\tfor ; Mon, 11 Sep 2017 01:01:15 +0000 (UTC)","from mail-pf0-f196.google.com (mail-pf0-f196.google.com\n\t[209.85.192.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 61D5DE0\n\tfor ; Mon, 11 Sep 2017 01:01:15 +0000 (UTC)","by mail-pf0-f196.google.com with SMTP id q76so4244156pfq.5\n\tfor ; Sun, 10 Sep 2017 18:01:15 -0700 (PDT)","from local.opencloud.tech.localdomain ([106.120.127.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tx28sm13380831pgc.91.2017.09.10.18.01.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 18:01:14 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Te8ucIimEvZUJugIK7q+p/8tAQxMvaNPljvoOzX58y4=;\n\tb=J12DpP2XT8vANJ05G/E9CxAODvRUpKzZemiUpypSJ7pvdDF94DJPq8stBKoQVmq9Bw\n\tNn9/Q3gSdQsWBGlO6h7YzHLyMuwgDCDfzi1RbrwGbahtHmZNXmkTvdaBLtIYa5seZAQ3\n\t7B2wO/1QQkiOsPXnbp3eZn8/Iig/CUfitm+lld5PgOQ0c2as0epk/B/Tg8uUJn8M233t\n\tt+ZpH0B85H87GPYHJ0Z6MQlbTwA8KKwLA3MPNboRiW+/hhYV+YeOZZwIwTAJ+8ccret7\n\t9HaA6yVlJCR/TW6fqd3YBB+4XtrhGZPWeme/PXiQn7J4Uhp+TnfmEnxRlZXHnKyowRUW\n\tURYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Te8ucIimEvZUJugIK7q+p/8tAQxMvaNPljvoOzX58y4=;\n\tb=a7UZtcb6CTLp/18klEqozl0XQ6y99URwDQd6dOn5s+qVhp5QS3Osg8R67hTU/kxqc+\n\tX+9xrZV+YqzBTMBtUl7PypIgozkUMBytha8SCwuhtkVsILZTD4lNCT+uWC3beH2nHPkc\n\tyMqMAOzWZstvYFhqcywIw7HPMWWa59STfjkqA8ZNz6uFA9ClLzC0CgnL8ITqiTJjKnS+\n\tMmktTrCwqvVBrHpm2bpbp4X3t74M4ODmu3sb4wbkWhcAdsX/qBy9yFefFn0hD5KGpL9a\n\tDJRT6WO9nPcWyTdx78ndFKClV7cz/J0iAvneZ7AVoadYWIhnHNHO4Dn/T5MFdN2b6Het\n\t9z2g==","X-Gm-Message-State":"AHPjjUiLfPBByjDfiKi8xxPL/x+LHnDKY4tLkQqAmgROma2LkZFR5RE6\n\tmJZRKQ1TqtP8uGcKwFg=","X-Google-Smtp-Source":"ADKCNb7Ij/tMLysjZeho+8trBpAkPV1l1IZkKCOTz2HSFvPexE5oKHmfvGM96i5z+ik1V+XnwbM2Cg==","X-Received":"by 10.98.196.26 with SMTP id y26mr10490826pff.106.1505091674738; \n\tSun, 10 Sep 2017 18:01:14 -0700 (PDT)","From":"Tonghao Zhang ","To":"dev@openvswitch.org","Date":"Sun, 10 Sep 2017 18:00:50 -0700","Message-Id":"<1505091651-55964-2-git-send-email-xiangxia.m.yue@gmail.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1505091651-55964-1-git-send-email-xiangxia.m.yue@gmail.com>","References":"<1505091651-55964-1-git-send-email-xiangxia.m.yue@gmail.com>","X-Spam-Status":"No, score=0.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 1/2] datapath: Optimize updating for OvS\n\tflow_stats.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"Upstream commit:\n\tcommit c57c054eb5b1ccf230c49f736f7a018fcbc3e952\n\tAuthor: Tonghao Zhang \n\tDate: Mon Jul 17 23:28:05 2017 -0700\n\n\topenvswitch: Optimize updating for OvS flow_stats.\n\n\tIn the ovs_flow_stats_update(), we only use the node\n\tvar to alloc flow_stats struct. But this is not a\n\tcommon case, it is unnecessary to call the numa_node_id()\n\teverytime. This patch is not a bugfix, but there maybe\n\ta small increase.\n\n\tSigned-off-by: Tonghao Zhang \n\tSigned-off-by: David S. Miller \n\nSigned-off-by: Tonghao Zhang \n---\n datapath/flow.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/datapath/flow.c b/datapath/flow.c\nindex c4f63b0..20582df 100644\n--- a/datapath/flow.c\n+++ b/datapath/flow.c\n@@ -71,7 +71,6 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags,\n \t\t\t const struct sk_buff *skb)\n {\n \tstruct flow_stats *stats;\n-\tint node = numa_node_id();\n \tint cpu = smp_processor_id();\n \tint len = skb->len + (skb_vlan_tag_present(skb) ? VLAN_HLEN : 0);\n \n@@ -107,7 +106,7 @@ void ovs_flow_stats_update(struct sw_flow *flow, __be16 tcp_flags,\n __GFP_THISNODE |\n __GFP_NOWARN |\n \t\t\t\t\t\t\t __GFP_NOMEMALLOC,\n-\t\t\t\t\t\t\t node);\n+\t\t\t\t\t\t\t numa_node_id());\n \t\t\t\tif (likely(new_stats)) {\n \t\t\t\t\tnew_stats->used = jiffies;\n \t\t\t\t\tnew_stats->packet_count = 1;\n","prefixes":["ovs-dev","1/2"]}