{"id":812163,"url":"http://patchwork.ozlabs.org/api/patches/812163/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150506059354.19604.5050182852156612042.stgit@frigg.lan/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150506059354.19604.5050182852156612042.stgit@frigg.lan>","list_archive_url":null,"date":"2017-09-10T16:23:13","name":"[3/7] trace: Add event \"guest_inst_info_before\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2981a9f8ceb22b9b36727da642192377f21ec67e","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/?format=json","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150506059354.19604.5050182852156612042.stgit@frigg.lan/mbox/","series":[{"id":2406,"url":"http://patchwork.ozlabs.org/api/series/2406/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2406","date":"2017-09-10T16:11:07","name":"trace: Add guest code events","version":1,"mbox":"http://patchwork.ozlabs.org/series/2406/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812163/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812163/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqxFb66sgz9rxm\n\tfor ;\n\tMon, 11 Sep 2017 02:23:47 +1000 (AEST)","from localhost ([::1]:53561 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dr51N-00075F-Jr\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 12:23:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41423)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dr513-00074o-MM\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 12:23:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dr50z-0003wf-N7\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 12:23:25 -0400","from roura.ac.upc.es ([147.83.33.10]:57795)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dr50z-0003wR-C1\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 12:23:21 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8AGNKNV020412;\n\tSun, 10 Sep 2017 18:23:20 +0200","from localhost (unknown [132.68.137.153])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id D1E531683;\n\tSun, 10 Sep 2017 18:23:14 +0200 (CEST)"],"From":"=?utf-8?b?TGx1w61z?= Vilanova ","To":"qemu-devel@nongnu.org","Date":"Sun, 10 Sep 2017 19:23:13 +0300","Message-Id":"<150506059354.19604.5050182852156612042.stgit@frigg.lan>","X-Mailer":"git-send-email 2.14.1","In-Reply-To":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>","User-Agent":"StGit/0.18","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by roura.ac.upc.es id\n\tv8AGNKNV020412","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"[Qemu-devel] [PATCH 3/7] trace: Add event \"guest_inst_info_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , Richard Henderson ,\n\tStefan Hajnoczi ,\n\tPeter Crosthwaite ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Signed-off-by: Lluís Vilanova \n---\n accel/tcg/translator.c | 18 ++++++++++++++++++\n trace-events | 9 +++++++++\n 2 files changed, 27 insertions(+)","diff":"diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c\nindex 287d27b4f7..6598931171 100644\n--- a/accel/tcg/translator.c\n+++ b/accel/tcg/translator.c\n@@ -70,6 +70,8 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n \n while (true) {\n target_ulong pc_insn = db->pc_next;\n+ TCGv_i32 insn_size_tcg = 0;\n+ int insn_size_opcode_idx;\n \n db->num_insns++;\n ops->insn_start(db, cpu);\n@@ -99,6 +101,16 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n trace_guest_bbl_before_tcg(cpu, tcg_ctx.tcg_env, db->pc_first);\n }\n trace_guest_inst_before_tcg(cpu, tcg_ctx.tcg_env, pc_insn);\n+ if (TRACE_GUEST_INST_INFO_BEFORE_EXEC_ENABLED) {\n+ insn_size_tcg = tcg_temp_new_i32();\n+ insn_size_opcode_idx = tcg_op_buf_count();\n+ tcg_gen_movi_i32(insn_size_tcg, 0xdeadbeef);\n+\n+ trace_guest_inst_info_before_tcg(\n+ cpu, tcg_ctx.tcg_env, pc_insn, insn_size_tcg);\n+\n+ tcg_temp_free_i32(insn_size_tcg);\n+ }\n \n /* Disassemble one instruction. The translate_insn hook should\n update db->pc_next and db->is_jmp to indicate what should be\n@@ -113,6 +125,12 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n ops->translate_insn(db, cpu);\n }\n \n+ /* Tracing after (patched values) */\n+ if (TRACE_GUEST_INST_INFO_BEFORE_EXEC_ENABLED) {\n+ unsigned int insn_size = db->pc_next - pc_insn;\n+ tcg_set_insn_param(insn_size_opcode_idx, 1, insn_size);\n+ }\n+\n /* Stop translation if translate_insn so indicated. */\n if (db->is_jmp != DISAS_NEXT) {\n break;\ndiff --git a/trace-events b/trace-events\nindex 46457c6158..4e61697297 100644\n--- a/trace-events\n+++ b/trace-events\n@@ -107,6 +107,15 @@ vcpu tcg guest_bbl_before(uint64_t vaddr) \"vaddr=0x%016\"PRIx64, \"vaddr=0x%016\"PR\n # Targets: TCG(all)\n vcpu tcg guest_inst_before(uint64_t vaddr) \"vaddr=0x%016\"PRIx64, \"vaddr=0x%016\"PRIx64\n \n+# @vaddr: Instruction's virtual address\n+# @size: Instruction's size in bytes\n+#\n+# Same as 'guest_inst_before', with additional information.\n+#\n+# Mode: user, softmmu\n+# Targets: TCG(all)\n+disable vcpu tcg guest_inst_info_before(uint64_t vaddr, TCGv_i32 size) \"vaddr=0x%016\"PRIx64, \"vaddr=0x%016\"PRIx64\" size=%d\"\n+\n # @vaddr: Access' virtual address.\n # @info : Access' information (see below).\n #\n","prefixes":["3/7"]}