{"id":812136,"url":"http://patchwork.ozlabs.org/api/patches/812136/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20170910132201.15576-1-dav.lebrun@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170910132201.15576-1-dav.lebrun@gmail.com>","list_archive_url":null,"date":"2017-09-10T13:22:01","name":"[net] ipv6: sr: remove duplicate routing header type check","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"f97a64e2715969aa6752693361f11141dac82d53","submitter":{"id":72342,"url":"http://patchwork.ozlabs.org/api/people/72342/?format=json","name":"David Lebrun","email":"dav.lebrun@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20170910132201.15576-1-dav.lebrun@gmail.com/mbox/","series":[{"id":2400,"url":"http://patchwork.ozlabs.org/api/series/2400/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2400","date":"2017-09-10T13:22:01","name":"[net] ipv6: sr: remove duplicate routing header type check","version":1,"mbox":"http://patchwork.ozlabs.org/series/2400/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812136/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812136/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cteNbna2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqsCH1TYJz9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 10 Sep 2017 23:21:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751634AbdIJNV2 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 10 Sep 2017 09:21:28 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:35333 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751482AbdIJNV1 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 10 Sep 2017 09:21:27 -0400","by mail-wr0-f194.google.com with SMTP id n64so3240550wrb.2\n\tfor <netdev@vger.kernel.org>; Sun, 10 Sep 2017 06:21:26 -0700 (PDT)","from localhost.localdomain (shingan.ethylix.be. [194.110.69.82])\n\tby smtp.gmail.com with ESMTPSA id\n\tr16sm11085591wrb.43.2017.09.10.06.21.25\n\tfor <netdev@vger.kernel.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 10 Sep 2017 06:21:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id;\n\tbh=mOnde4wYREWsCAPU8OewpPkA7Tdrw6l62Nd2B4x2eVA=;\n\tb=cteNbna2utYJX4E3zig/5NpdixNIahqIni3Qn8Kwzh1FnJGgi+FMvu8APKRTdUuP1T\n\tYtBzoWXUp2vA7PrZcyhCLpVV6yydVY8HY19Kb3l/o2pErbFRJyNuvBR8csRxnwaC1PQ9\n\tLMUrUI3U7ailQ2i7HCCvtb6eE+kuxJi0S0uOe/V9dzevPWsoDavJNeGGG9YMoxiJeaGE\n\tME6XwwIoND65vnzI3U+fpPRzu5gaOlvp9F6jayjSv+JGFJqV5WXU/iEqteqK0C7o88b7\n\tSwrVSIblqFTsUo+9A3jLalGWFZXKuWtHMDJUcVzeDuOPZBMwnfIiacn5zgxjLQFDN24n\n\tHqmQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id;\n\tbh=mOnde4wYREWsCAPU8OewpPkA7Tdrw6l62Nd2B4x2eVA=;\n\tb=QI8ufnADLXWShM8Ejio6Wmv5To4G9GiWQPjaUStkBR4U76AOQnH92v3Hm9Ed/I3PlE\n\tCxk4JuKFJ7oiAOOxXCCMEMvYa48UP6qz5jNMb9DX6lFphAKouaIW4xUdMABBK9aMtXqc\n\td0h/w6TLur2JltWzca11Xj0Rw2kfPjBtFJhAkqyg7RGtzR8xjC/aat6LLFUuOvmxsBmc\n\t2Br/6TDMmG+0TA3e5cFXp+bvwDfSBleAIuk9cBIw8iIaV/4zvVajqYaCdkoCLmTBHc0O\n\tJqQ3qp78CM877aRvLwxh1iaFxVzFbsPEpQByxw+1xie3k8A5kdbVYB8wiNeaJiJ0nXan\n\tEkPQ==","X-Gm-Message-State":"AHPjjUgJetVGaenrORDKuBwqY1izUe8AjCiNk1ayrWQDZlKIDoL20YjF\n\tiZUv7oReeUOvlPSWjIY=","X-Google-Smtp-Source":"ADKCNb4A/5gGMXJLOb2HyxRQ6W9mbSwAc2OoneRoi9tA26ZRyFjxf54+SaEzGe7BjuBkPifDnumneQ==","X-Received":"by 10.223.151.157 with SMTP id s29mr5679724wrb.168.1505049685986;\n\tSun, 10 Sep 2017 06:21:25 -0700 (PDT)","From":"David Lebrun <dav.lebrun@gmail.com>","To":"netdev@vger.kernel.org","Subject":"[PATCH net] ipv6: sr: remove duplicate routing header type check","Date":"Sun, 10 Sep 2017 14:22:01 +0100","Message-Id":"<20170910132201.15576-1-dav.lebrun@gmail.com>","X-Mailer":"git-send-email 2.10.2","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: David Lebrun <dlebrun@google.com>\n\nAs seg6_validate_srh() already checks that the Routing Header type is\ncorrect, it is not necessary to do it again in get_srh().\n\nFixes: 5829d70b (\"ipv6: sr: fix get_srh() to comply with IPv6 standard \"RFC 8200\")\nSigned-off-by: David Lebrun <dlebrun@google.com>\n---\n net/ipv6/seg6_local.c | 4 ----\n 1 file changed, 4 deletions(-)","diff":"diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c\nindex 7ff54db..825b8e0 100644\n--- a/net/ipv6/seg6_local.c\n+++ b/net/ipv6/seg6_local.c\n@@ -72,10 +72,6 @@ static struct ipv6_sr_hdr *get_srh(struct sk_buff *skb)\n \n \tsrh = (struct ipv6_sr_hdr *)(skb->data + srhoff);\n \n-\t/* make sure it's a Segment Routing header (Routing Type 4) */\n-\tif (srh->type != IPV6_SRCRT_TYPE_4)\n-\t\treturn NULL;\n-\n \tlen = (srh->hdrlen + 1) << 3;\n \n \tif (!pskb_may_pull(skb, srhoff + len))\n","prefixes":["net"]}