{"id":812103,"url":"http://patchwork.ozlabs.org/api/patches/812103/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170910112149.21358-18-robdclark@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170910112149.21358-18-robdclark@gmail.com>","list_archive_url":null,"date":"2017-09-10T11:21:34","name":"[U-Boot,v2,09/21] efi_loader: use proper device-paths for net","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"978db1ca584e4cb11b58d82600d5f602c5c50056","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/?format=json","name":"Rob Clark","email":"robdclark@gmail.com"},"delegate":{"id":3400,"url":"http://patchwork.ozlabs.org/api/users/3400/?format=json","username":"agraf","first_name":"Alexander","last_name":"Graf","email":"agraf@suse.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170910112149.21358-18-robdclark@gmail.com/mbox/","series":[{"id":2383,"url":"http://patchwork.ozlabs.org/api/series/2383/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=2383","date":"2017-09-10T11:21:17","name":"efi_loader: enough UEFI for standard distro boot","version":2,"mbox":"http://patchwork.ozlabs.org/series/2383/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/812103/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/812103/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tT1fSq/F\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqphW4Zcbz9sDB\n\tfor ;\n\tSun, 10 Sep 2017 21:28:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5D399C21DDF; Sun, 10 Sep 2017 11:25:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8B161C21EA8;\n\tSun, 10 Sep 2017 11:23:38 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6501DC21EA8; Sun, 10 Sep 2017 11:23:12 +0000 (UTC)","from mail-qt0-f193.google.com (mail-qt0-f193.google.com\n\t[209.85.216.193])\n\tby lists.denx.de (Postfix) with ESMTPS id 28D37C21E3C\n\tfor ; Sun, 10 Sep 2017 11:23:06 +0000 (UTC)","by mail-qt0-f193.google.com with SMTP id q8so4090087qtb.1\n\tfor ; Sun, 10 Sep 2017 04:23:06 -0700 (PDT)","from localhost ([2601:184:4780:aac0:25f8:dd96:a084:785a])\n\tby smtp.gmail.com with ESMTPSA id\n\ta12sm4366604qta.3.2017.09.10.04.23.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 10 Sep 2017 04:23:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=q0Qolx1SkIrEQb3hYqzrxMkSkrB0yBal+ZscwQZLcmY=;\n\tb=tT1fSq/FDkqcK4ELUNEXlBhtpzTFkynWc3bL1mrvNrWLtHVtXwZK9iuvV+jdxdciAs\n\t7I+5JuTH/jY9I3mp5F2bpa4RaCcOEndTJaXQndvj8qCS4Q1xSf0N6bhSL9gT3Bb0V609\n\tsN1E4MYzOvqkqBOcJXGTmwVLcVvleAQVZZiSsil7MNQOgzyxAwZFpUSyahtt+EpQ57qG\n\ty2hXQIlUfSy0kY5Nc3fpaIyL+92a42i2uqVnYuFyBrJGII1yYDe3bxuWrPJ/Z5jR10Jq\n\tNsYAIzJ4/69o2k6M/srfYO6hD6YlK5w9X+3h7+0o46Fz+nVSwCWLjXvqKu15GzK4rkSa\n\th84A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=q0Qolx1SkIrEQb3hYqzrxMkSkrB0yBal+ZscwQZLcmY=;\n\tb=nghfU//d5L/tS+5XFgMof1JKhuBoc0eqV9YUSmdVH5CoZGm5pkopDNDQ66YAeime5l\n\tUxnAqzhqSY9ZAWFlTLfMgFq+qR0JsF5lIgZGJohlnnqGUMhUPr0rJ7itHB/zL+zapsY4\n\tsS0tq/jjZOmmn5wGYQOqiWxGj6ivngx2aE4mfdQM+fGBQaDOROwTLk0PQezMXmy1SPqu\n\t3X3UMELik4uFfTm5yJX73Tzv7wkHZF/QophngXwcVvNwP3J63gC+1dQ5BFFgZpDaffIR\n\t1Im8hstFZp0cjSX9Jlu/LA9CGDd8GRFHtwqaly6YwmwBIzFU1FmZCHeFOYjMxJI3WU3A\n\tRUzQ==","X-Gm-Message-State":"AHPjjUhf8dXJnfYNGWrwFHH2GpV+bfcL4QDA0uKaKBsFx3FMw1vuIvMs\n\tVZ8a7SQcjYreU+mnRYc=","X-Google-Smtp-Source":"AOwi7QA3lIYJLcewfedlpgddVabOXgJUnHnt8dhPstCFxNpxM7e1VjRvWQQMjInmrtLgz3+lt+mBEA==","X-Received":"by 10.237.36.205 with SMTP id u13mr12543745qtc.75.1505042584901; \n\tSun, 10 Sep 2017 04:23:04 -0700 (PDT)","From":"Rob Clark ","To":"U-Boot Mailing List ","Date":"Sun, 10 Sep 2017 07:21:34 -0400","Message-Id":"<20170910112149.21358-18-robdclark@gmail.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170910112149.21358-1-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>","Cc":"Heinrich Schuchardt ","Subject":"[U-Boot] [PATCH v2 09/21] efi_loader: use proper device-paths for\n\tnet","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"Signed-off-by: Rob Clark \n---\n lib/efi_loader/efi_net.c | 19 ++-----------------\n 1 file changed, 2 insertions(+), 17 deletions(-)","diff":"diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c\nindex 0b949d86e8..aa0618fd3a 100644\n--- a/lib/efi_loader/efi_net.c\n+++ b/lib/efi_loader/efi_net.c\n@@ -26,9 +26,6 @@ struct efi_net_obj {\n \t/* EFI Interface callback struct for network */\n \tstruct efi_simple_network net;\n \tstruct efi_simple_network_mode net_mode;\n-\t/* Device path to the network adapter */\n-\tstruct efi_device_path_mac_addr dp_mac;\n-\tstruct efi_device_path_file_path dp_end;\n \t/* PXE struct to transmit dhcp data */\n \tstruct efi_pxe pxe;\n \tstruct efi_pxe_mode pxe_mode;\n@@ -213,16 +210,6 @@ void efi_net_set_dhcp_ack(void *pkt, int len)\n int efi_net_register(void **handle)\n {\n \tstruct efi_net_obj *netobj;\n-\tstruct efi_device_path_mac_addr dp_net = {\n-\t\t.dp.type = DEVICE_PATH_TYPE_MESSAGING_DEVICE,\n-\t\t.dp.sub_type = DEVICE_PATH_SUB_TYPE_MSG_MAC_ADDR,\n-\t\t.dp.length = sizeof(dp_net),\n-\t};\n-\tstruct efi_device_path_file_path dp_end = {\n-\t\t.dp.type = DEVICE_PATH_TYPE_END,\n-\t\t.dp.sub_type = DEVICE_PATH_SUB_TYPE_END,\n-\t\t.dp.length = sizeof(dp_end),\n-\t};\n \n \tif (!eth_get_dev()) {\n \t\t/* No eth device active, don't expose any */\n@@ -236,7 +223,8 @@ int efi_net_register(void **handle)\n \tnetobj->parent.protocols[0].guid = &efi_net_guid;\n \tnetobj->parent.protocols[0].protocol_interface = &netobj->net;\n \tnetobj->parent.protocols[1].guid = &efi_guid_device_path;\n-\tnetobj->parent.protocols[1].protocol_interface = &netobj->dp_mac;\n+\tnetobj->parent.protocols[1].protocol_interface =\n+\t\tefi_dp_from_eth();\n \tnetobj->parent.protocols[2].guid = &efi_pxe_guid;\n \tnetobj->parent.protocols[2].protocol_interface = &netobj->pxe;\n \tnetobj->parent.handle = &netobj->net;\n@@ -255,9 +243,6 @@ int efi_net_register(void **handle)\n \tnetobj->net.receive = efi_net_receive;\n \tnetobj->net.mode = &netobj->net_mode;\n \tnetobj->net_mode.state = EFI_NETWORK_STARTED;\n-\tnetobj->dp_mac = dp_net;\n-\tnetobj->dp_end = dp_end;\n-\tmemcpy(netobj->dp_mac.mac.addr, eth_get_ethaddr(), 6);\n \tmemcpy(netobj->net_mode.current_address.mac_addr, eth_get_ethaddr(), 6);\n \tnetobj->net_mode.max_packet_size = PKTSIZE;\n \n","prefixes":["U-Boot","v2","09/21"]}