{"id":811962,"url":"http://patchwork.ozlabs.org/api/patches/811962/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150496957019.9654.12729412560336508445.stgit@bahia/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150496957019.9654.12729412560336508445.stgit@bahia>","list_archive_url":null,"date":"2017-09-09T15:06:10","name":"[2/5] spapr_pci: drop useless check in spapr_populate_pci_child_dt()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0c1dc3c9186f47433e4294d12d6941d317d19a00","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/?format=json","name":"Greg Kurz","email":"groug@kaod.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/150496957019.9654.12729412560336508445.stgit@bahia/mbox/","series":[{"id":2354,"url":"http://patchwork.ozlabs.org/api/series/2354/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2354","date":"2017-09-09T15:05:46","name":"spapr_pci: various cleanups and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/2354/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811962/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811962/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqHbV1WjRz9s7F\n\tfor ;\n\tSun, 10 Sep 2017 01:07:02 +1000 (AEST)","from localhost ([::1]:49876 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqhLY-0007m2-8x\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 11:07:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50803)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqhKt-0007kp-AU\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqhKo-00062T-KF\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:19 -0400","from 6.mo177.mail-out.ovh.net ([46.105.51.249]:60202)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqhKo-00061G-A1\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 11:06:14 -0400","from player714.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id 02768716A6\n\tfor ; Sat, 9 Sep 2017 17:06:12 +0200 (CEST)","from [192.168.0.243] (gar31-1-82-66-74-139.fbx.proxad.net\n\t[82.66.74.139]) (Authenticated sender: groug@kaod.org)\n\tby player714.ha.ovh.net (Postfix) with ESMTPA id C64FB3C0073;\n\tSat, 9 Sep 2017 17:06:10 +0200 (CEST)"],"From":"Greg Kurz ","To":"qemu-devel@nongnu.org","Date":"Sat, 09 Sep 2017 17:06:10 +0200","Message-ID":"<150496957019.9654.12729412560336508445.stgit@bahia>","In-Reply-To":"<150496954641.9654.1998704077006846521.stgit@bahia>","References":"<150496954641.9654.1998704077006846521.stgit@bahia>","User-Agent":"StGit/0.17.1-46-g6855-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Ovh-Tracer-Id":"244320282850466131","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrfeeigdekjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.51.249","Subject":"[Qemu-devel] [PATCH 2/5] spapr_pci: drop useless check in\n\tspapr_populate_pci_child_dt()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"spapr_phb_get_loc_code() either returns a non-null pointer, either\naborts if g_strdup_printf() failed to allocate memory.\n\nSigned-off-by: Greg Kurz \n---\n hw/ppc/spapr_pci.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c\nindex ef982f2ef370..cd8efb181223 100644\n--- a/hw/ppc/spapr_pci.c\n+++ b/hw/ppc/spapr_pci.c\n@@ -1282,12 +1282,8 @@ static int spapr_populate_pci_child_dt(PCIDevice *dev, void *fdt, int offset,\n pci_find_device_name((ccode >> 16) & 0xff,\n (ccode >> 8) & 0xff,\n ccode & 0xff)));\n- buf = spapr_phb_get_loc_code(sphb, dev);\n- if (!buf) {\n- error_report(\"Failed setting the ibm,loc-code\");\n- return -1;\n- }\n \n+ buf = spapr_phb_get_loc_code(sphb, dev);\n err = fdt_setprop_string(fdt, offset, \"ibm,loc-code\", buf);\n g_free(buf);\n if (err < 0) {\n","prefixes":["2/5"]}