{"id":811884,"url":"http://patchwork.ozlabs.org/api/patches/811884/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504910713-7094-27-git-send-email-linuxram@us.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<1504910713-7094-27-git-send-email-linuxram@us.ibm.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/1504910713-7094-27-git-send-email-linuxram@us.ibm.com/","date":"2017-09-08T22:45:06","name":"[18/25] powerpc: check key protection for user page access","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"5374a0bd40d957348b7cbc137a7103a98f7c7a24","submitter":{"id":2667,"url":"http://patchwork.ozlabs.org/api/people/2667/?format=json","name":"Ram Pai","email":"linuxram@us.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504910713-7094-27-git-send-email-linuxram@us.ibm.com/mbox/","series":[{"id":2303,"url":"http://patchwork.ozlabs.org/api/series/2303/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=2303","date":"2017-09-08T22:44:40","name":"powerpc: Free up RPAGE_RSV bits","version":1,"mbox":"http://patchwork.ozlabs.org/series/2303/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811884/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811884/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xptyQ2KSDz9sBW\n\tfor ;\n\tSat, 9 Sep 2017 09:37:02 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xptyQ11SmzDrVZ\n\tfor ;\n\tSat, 9 Sep 2017 09:37:02 +1000 (AEST)","from mail-qt0-x243.google.com (mail-qt0-x243.google.com\n\t[IPv6:2607:f8b0:400d:c0d::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpsrz1Nr2zDrd6\n\tfor ;\n\tSat, 9 Sep 2017 08:47:15 +1000 (AEST)","by mail-qt0-x243.google.com with SMTP id h21so2358391qth.4\n\tfor ;\n\tFri, 08 Sep 2017 15:47:15 -0700 (PDT)","from localhost.localdomain (50-39-103-96.bvtn.or.frontiernet.net.\n\t[50.39.103.96]) by smtp.gmail.com with ESMTPSA id\n\tx124sm2033726qka.85.2017.09.08.15.47.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 15:47:13 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m8cvrghI\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m8cvrghI\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400d:c0d::243; helo=mail-qt0-x243.google.com;\n\tenvelope-from=ram.n.pai@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m8cvrghI\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=yNZJPQ2cwn5BQXYY40Nf77WRnTtHQN2hJ7VIC/03yTk=;\n\tb=m8cvrghIRUu3KBsYDB3N35GJ8P+KHWJZBoDVVmY6hzl1s/6R1fQ2oA209Onz8IydpX\n\tIwG0ggIWnw7HdgWyuiu2HDi7PpTvbOz+WsWpQsD1zQMr6PSRpNL3uu7SIY1wkZkF7Lr4\n\tGpmwvzlhRfXYJWyPn/n1WwXOBHfx96MJT+mpDpsaPc+ugkJpUJEdOPOO8E0Ar24RwZjn\n\tAHQzYeQA+GSmkRfVFzQbLiMu9b5+D25c4UFbkXUCZOvhsZ1jKPCcb4M9kS1vK42b9PBS\n\tA+hZle0u0Gb6VFrgV23A6wHOonGVBgD0hPGQpaQUGRShjEW32vmwOIxSkMioA6WLpdre\n\tEE6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=yNZJPQ2cwn5BQXYY40Nf77WRnTtHQN2hJ7VIC/03yTk=;\n\tb=IxebW29GmmJdKcC4+Y4m15JVuU4biJQBCeibQZcraQ+04ltda2v0/mwHW5djHYBBtx\n\tpGydwuRN/JUKGiI46NNAXdVwpieSC7RTn/rJHTie/cPifpxWoeCUhTKgmjZPtu2IchYh\n\tRm6wBs8ZtMVzCSshia2bqmYG5mrHLluNJtWLxq+vvcNkHXfws1EzekVF1N6Lu2xhZD50\n\tPnm0fyfU2TlfWlPakGaxX7wLEcGx/GTv3W9Gwp3Vqmfkz4rHmVieguPgTuTFVOztUG8/\n\thNwdh7PPla3F4+jB3MI4JVwpvarmgiq7N2j3YGOu6nKCCPNDutEdkYZyEiMIp/3Tal3T\n\ta6pw==","X-Gm-Message-State":"AHPjjUiFTZ98rxqglygaz2nfWX6frM6uw81xTEPdi15TmsMSm8cyMFWJ\n\t+aTDaaeOt3NoYQ==","X-Google-Smtp-Source":"AOwi7QC8CTerpQgE1qU+1DxZ1EcezJgZx8rOq22DUntZWqepLkCkd0qpuDam1wFC0OBbvLXXcSWbSA==","X-Received":"by 10.237.59.221 with SMTP id s29mr6657665qte.27.1504910833324; \n\tFri, 08 Sep 2017 15:47:13 -0700 (PDT)","From":"Ram Pai ","To":"mpe@ellerman.id.au,\n\tlinuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 18/25] powerpc: check key protection for user page access","Date":"Fri, 8 Sep 2017 15:45:06 -0700","Message-Id":"<1504910713-7094-27-git-send-email-linuxram@us.ibm.com>","X-Mailer":"git-send-email 1.7.1","In-Reply-To":"<1504910713-7094-1-git-send-email-linuxram@us.ibm.com>","References":"<1504910713-7094-1-git-send-email-linuxram@us.ibm.com>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ebiederm@xmission.com, linuxram@us.ibm.com, mhocko@kernel.org,\n\tpaulus@samba.org, aneesh.kumar@linux.vnet.ibm.com,\n\tbauerman@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"Make sure that the kernel does not access user pages without\nchecking their key-protection.\n\nSigned-off-by: Ram Pai \n---\n arch/powerpc/include/asm/book3s/64/pgtable.h | 14 ++++++++++++++\n 1 files changed, 14 insertions(+), 0 deletions(-)","diff":"diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h\nindex bd244b3..d22bb4d 100644\n--- a/arch/powerpc/include/asm/book3s/64/pgtable.h\n+++ b/arch/powerpc/include/asm/book3s/64/pgtable.h\n@@ -494,6 +494,20 @@ static inline void write_uamor(u64 value)\n \n #ifdef CONFIG_PPC64_MEMORY_PROTECTION_KEYS\n extern bool arch_pte_access_permitted(u64 pte, bool write, bool execute);\n+\n+#define pte_access_permitted(pte, write) \\\n+\t(pte_present(pte) && \\\n+\t ((!(write) || pte_write(pte)) && \\\n+\t arch_pte_access_permitted(pte_val(pte), !!write, 0)))\n+\n+/*\n+ * We store key in pmd for huge tlb pages. So need\n+ * to check for key protection.\n+ */\n+#define pmd_access_permitted(pmd, write) \\\n+\t(pmd_present(pmd) && \\\n+\t ((!(write) || pmd_write(pmd)) && \\\n+\t arch_pte_access_permitted(pmd_val(pmd), !!write, 0)))\n #endif /* CONFIG_PPC64_MEMORY_PROTECTION_KEYS */\n \n #define __HAVE_ARCH_PTEP_GET_AND_CLEAR\n","prefixes":["18/25"]}