{"id":811833,"url":"http://patchwork.ozlabs.org/api/patches/811833/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360>","list_archive_url":null,"date":"2017-09-08T21:01:10","name":"[net,3/3] bpf: devmap, use cond_resched instead of cpu_relax","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"69d4046166e87a9d33457b9393fe59f304f34a97","submitter":{"id":20028,"url":"http://patchwork.ozlabs.org/api/people/20028/?format=json","name":"John Fastabend","email":"john.fastabend@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360/mbox/","series":[{"id":2291,"url":"http://patchwork.ozlabs.org/api/series/2291/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=2291","date":"2017-09-08T21:00:05","name":"Fixes for XDP/BPF","version":1,"mbox":"http://patchwork.ozlabs.org/series/2291/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811833/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811833/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Hj4pmsJW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpqVt4W8pz9s75\n\tfor ;\n\tSat, 9 Sep 2017 07:01:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932621AbdIHVBY (ORCPT );\n\tFri, 8 Sep 2017 17:01:24 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:37990 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932400AbdIHVBX (ORCPT\n\t); Fri, 8 Sep 2017 17:01:23 -0400","by mail-pf0-f196.google.com with SMTP id q76so1924447pfq.5\n\tfor ; Fri, 08 Sep 2017 14:01:23 -0700 (PDT)","from [127.0.1.1] ([72.168.144.71])\n\tby smtp.gmail.com with ESMTPSA id\n\ta75sm5174671pfe.48.2017.09.08.14.01.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 14:01:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=2A7mgnJVnLLfaOr+4zNLF3IHH4nOiHY0a0Nph/UTLos=;\n\tb=Hj4pmsJWENylph7PJ4Da7Ch041DCaJ+QekG1R1coEi2nMaxS5xAOdV6RhpfYJk5KyS\n\ttUQ2bcG6D5n2PJEnW07/JWFBskgY926tueWh7oa45W8rH4B094fxocM/sGYBc1iIOEEs\n\tM9ErqQKFDwBvNAMSo2eUR8q5rD3BnvMrUen32pQ9P1K8yMEK+8O87OdtM46zVQv5zmBp\n\t/Ca1i6NOjcrz9lNnuAeo0Gsn4O4FeeHCbDt6IBAcC3JuARf7LFdfHoYyn15mUrX/Xm3d\n\t79cVK3+tvIgmBp32AC72i0pl4YXDty+ltPPg5vV2LwtlsNT3Im4c91Lp7BdnwZtcIzXF\n\t70wA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=2A7mgnJVnLLfaOr+4zNLF3IHH4nOiHY0a0Nph/UTLos=;\n\tb=AopAiMSEThv8KhTOa1cZ+lz8V3QOLZkF21OO+9ehFZ/Yuk4CvgkhtK1dZR0xAoKIDG\n\teyVvnxwlB8xa+yFNFG5Zln8m3F5j/Il0kR74BKpo6Zu3RAhxg+/odONVXSCD58CYO65R\n\tyS0Z0TkR7Gp42GGQRh4L6LvV4mO/WdY/qVujyjiejQmm9IDD45j6iDRfyZphvQTJ4nTC\n\t1OWpyFj/INNBvnlUDndelPFM5SfkF7GPv1PhoTDUQpFiHubouqJvFNCY+FsjOHt8Jw4I\n\tW2yXsBpcCIY1GMlfCRUjvHv1au9zgli0KTVbWPMVgBN5Xm/jX0q4Olo+0WQqLtGFIvlz\n\tUnTA==","X-Gm-Message-State":"AHPjjUg2MlUTfHY9juCsKAee5vSm/kpfyZIXa/Kj27URGKvdniT7Nee/\n\tsqMOSPDK5RMu98Nj","X-Google-Smtp-Source":"ADKCNb7uZDPc9repJNZnmkPSy+jmkmtT2BFiC/lUxhXo7Uo+9mzinydFNXYe3pFxP7SbJbk4yebxXg==","X-Received":"by 10.98.18.199 with SMTP id 68mr4411600pfs.94.1504904482891;\n\tFri, 08 Sep 2017 14:01:22 -0700 (PDT)","Subject":"[net PATCH 3/3] bpf: devmap, use cond_resched instead of cpu_relax","From":"John Fastabend ","To":"davem@davemloft.net","Cc":"netdev@vger.kernel.org, john.fastabend@gmail.com,\n\tdaniel@iogearbox.net, ast@fb.com","Date":"Fri, 08 Sep 2017 14:01:10 -0700","Message-ID":"<150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360>","In-Reply-To":"<150490397545.11590.1409723973253492363.stgit@john-XPS-13-9360>","References":"<150490397545.11590.1409723973253492363.stgit@john-XPS-13-9360>","User-Agent":"StGit/0.17.1-dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Be a bit more friendly about waiting for flush bits to complete.\nReplace the cpu_relax() with a cond_resched().\n\nSuggested-by: Daniel Borkmann \nAcked-by: Daniel Borkmann \nSigned-off-by: John Fastabend \n---\n kernel/bpf/devmap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c\nindex ecf9f99..959c9a0 100644\n--- a/kernel/bpf/devmap.c\n+++ b/kernel/bpf/devmap.c\n@@ -159,7 +159,7 @@ static void dev_map_free(struct bpf_map *map)\n \t\tunsigned long *bitmap = per_cpu_ptr(dtab->flush_needed, cpu);\n \n \t\twhile (!bitmap_empty(bitmap, dtab->map.max_entries))\n-\t\t\tcpu_relax();\n+\t\t\tcond_resched();\n \t}\n \n \tfor (i = 0; i < dtab->map.max_entries; i++) {\n","prefixes":["net","3/3"]}