{"id":811829,"url":"http://patchwork.ozlabs.org/api/patches/811829/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/b6e0b987-8e45-77f1-c627-0df38979369a@linux.vnet.ibm.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"","list_archive_url":"https://lore.kernel.org/linuxppc-dev/b6e0b987-8e45-77f1-c627-0df38979369a@linux.vnet.ibm.com/","date":"2017-09-08T20:47:56","name":"[V14,4/4] powerpc/vphn: Fix numa update end-loop bug","commit_ref":"8bc931495d4bfcde6bb242a478ddd1186ae29301","pull_url":null,"state":"accepted","archived":false,"hash":"c8b26ac8e9f5bae9812950317f39679f10005a4c","submitter":{"id":65104,"url":"http://patchwork.ozlabs.org/api/people/65104/?format=json","name":"Michael Bringmann","email":"mwb@linux.vnet.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/b6e0b987-8e45-77f1-c627-0df38979369a@linux.vnet.ibm.com/mbox/","series":[{"id":2289,"url":"http://patchwork.ozlabs.org/api/series/2289/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=2289","date":"2017-09-08T20:47:01","name":"powerpc/vphn: Update CPU topology when VPHN enabled","version":14,"mbox":"http://patchwork.ozlabs.org/series/2289/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811829/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811829/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpqPN2CYkz9s7f\n\tfor ;\n\tSat, 9 Sep 2017 06:56:40 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpqPN1NfZzDrmw\n\tfor ;\n\tSat, 9 Sep 2017 06:56:40 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpqCS1tDxzDrcT\n\tfor ;\n\tSat, 9 Sep 2017 06:48:04 +1000 (AEST)","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv88KiTUu145077\n\tfor ; Fri, 8 Sep 2017 16:48:02 -0400","from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cv0tgmaym-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 08 Sep 2017 16:48:01 -0400","from localhost\n\tby e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 8 Sep 2017 14:48:01 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 8 Sep 2017 14:47:58 -0600","from b03ledav002.gho.boulder.ibm.com\n\t(b03ledav002.gho.boulder.ibm.com [9.17.130.233])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v88Klwcn32047288; Fri, 8 Sep 2017 13:47:58 -0700","from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3CCDD136044;\n\tFri, 8 Sep 2017 14:47:58 -0600 (MDT)","from oc1554177480.ibm.com (unknown [9.80.201.155])\n\tby b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP id\n\t0CF9C136046; Fri, 8 Sep 2017 14:47:56 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=mwb@linux.vnet.ibm.com; receiver=)","To":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","In-Reply-To":"<74fb879c-19bf-3abf-4491-1f0db162e7d8@linux.vnet.ibm.com>","From":"Michael Bringmann ","Subject":"[PATCH V14 4/4] powerpc/vphn: Fix numa update end-loop bug","Organization":"IBM Linux Technology Center","Date":"Fri, 8 Sep 2017 15:47:56 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090820-0012-0000-0000-000014FAD412","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007691; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00914193; UDB=6.00458905;\n\tIPR=6.00694451; \n\tBA=6.00005576; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017073;\n\tXFM=3.00000015; UTC=2017-09-08 20:48:00","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090820-0013-0000-0000-00004F6952B3","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_13:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709080310","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Nathan Fontenot ,\n\tMichael Bringmann ,\n\tJohn Allen ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"powerpc/vphn: On Power systems with shared configurations of CPUs\nand memory, there are some issues with the association of additional\nCPUs and memory to nodes when hot-adding resources. This patch\nfixes an end-of-updates processing problem observed occasionally\nin numa_update_cpu_topology().\n\nSigned-off-by: Michael Bringmann \n---\nChanges in V14:\n -- More code cleanup\n---\n arch/powerpc/mm/numa.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\nindex 32f5f8d..ec098b3 100644\n--- a/arch/powerpc/mm/numa.c\n+++ b/arch/powerpc/mm/numa.c\n@@ -1401,16 +1401,22 @@ int numa_update_cpu_topology(bool cpus_locked)\n \n \t\tfor_each_cpu(sibling, cpu_sibling_mask(cpu)) {\n \t\t\tud = &updates[i++];\n+\t\t\tud->next = &updates[i];\n \t\t\tud->cpu = sibling;\n \t\t\tud->new_nid = new_nid;\n \t\t\tud->old_nid = numa_cpu_lookup_table[sibling];\n \t\t\tcpumask_set_cpu(sibling, &updated_cpus);\n-\t\t\tif (i < weight)\n-\t\t\t\tud->next = &updates[i];\n \t\t}\n \t\tcpu = cpu_last_thread_sibling(cpu);\n \t}\n \n+\t/*\n+\t * Prevent processing of 'updates' from overflowing array\n+\t * where last entry filled in a 'next' pointer.\n+\t */\n+\tif (i)\n+\t\tupdates[i-1].next = NULL;\n+\n \tpr_debug(\"Topology update for the following CPUs:\\n\");\n \tif (cpumask_weight(&updated_cpus)) {\n \t\tfor (ud = &updates[0]; ud; ud = ud->next) {\n","prefixes":["V14","4/4"]}