{"id":811780,"url":"http://patchwork.ozlabs.org/api/patches/811780/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com>","list_archive_url":null,"date":"2017-09-08T17:59:23","name":"[ovs-dev,11/13] ofproto: Reorder elements in ofproto_bundle_settings structure.","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"d0b6fd86afb6b1f51480b245a38dad0f176d7af6","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/?format=json","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/","series":[{"id":2268,"url":"http://patchwork.ozlabs.org/api/series/2268/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2268","date":"2017-09-08T17:59:12","name":"Rearrange structure members for memory efficiency.","version":1,"mbox":"http://patchwork.ozlabs.org/series/2268/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811780/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811780/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xplqX0wKWz9ryk\n\tfor ;\n\tSat, 9 Sep 2017 04:15:36 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 88D9CCA6;\n\tFri, 8 Sep 2017 18:09:20 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 93EFDC90\n\tfor ; Fri, 8 Sep 2017 18:09:16 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 30C50420\n\tfor ; Fri, 8 Sep 2017 18:09:16 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 11:09:16 -0700","from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 11:09:13 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,362,1500966000\"; d=\"scan'208\";\n\ta=\"1216435682\"","From":"Bhanuprakash Bodireddy ","To":"dev@openvswitch.org","Date":"Fri, 8 Sep 2017 18:59:23 +0100","Message-Id":"<1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Mailer":"git-send-email 2.4.11","In-Reply-To":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 11/13] ofproto: Reorder elements in\n\tofproto_bundle_settings structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"By reordering elements in ofproto_bundle_settings structure, sum holes\nand pad bytes can be reduced.\n\nBefore: structure size: 96, sum holes: 13, pad bytes: 7, cachelines:2\nAfter : structure size: 80, sum holes: 4, pad bytes: 0, cachelines:2\n\nSigned-off-by: Bhanuprakash Bodireddy \n---\n ofproto/ofproto.h | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h\nindex 9e35327..2a7c1f3 100644\n--- a/ofproto/ofproto.h\n+++ b/ofproto/ofproto.h\n@@ -403,18 +403,17 @@ struct ofproto_bundle_settings {\n size_t n_slaves;\n \n enum port_vlan_mode vlan_mode; /* Selects mode for vlan and trunks */\n+ bool protected; /* Protected port mode */\n+ bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */\n uint16_t qinq_ethtype;\n int vlan; /* VLAN VID, except for PORT_VLAN_TRUNK. */\n unsigned long *trunks; /* vlan_bitmap, except for PORT_VLAN_ACCESS. */\n unsigned long *cvlans;\n- bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */\n \n struct bond_settings *bond; /* Must be nonnull iff if n_slaves > 1. */\n \n struct lacp_settings *lacp; /* Nonnull to enable LACP. */\n struct lacp_slave_settings *lacp_slaves; /* Array of n_slaves elements. */\n-\n- bool protected; /* Protected port mode */\n };\n \n int ofproto_bundle_register(struct ofproto *, void *aux,\n","prefixes":["ovs-dev","11/13"]}