{"id":811767,"url":"http://patchwork.ozlabs.org/api/patches/811767/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-2-git-send-email-bhanuprakash.bodireddy@intel.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504893565-110166-2-git-send-email-bhanuprakash.bodireddy@intel.com>","list_archive_url":null,"date":"2017-09-08T17:59:13","name":"[ovs-dev,01/13] bond: Reorder elements in bond_slave structure.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0220570f595f9dfc847ffe1c817ba3ba0ecf02c1","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/?format=json","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504893565-110166-2-git-send-email-bhanuprakash.bodireddy@intel.com/mbox/","series":[{"id":2268,"url":"http://patchwork.ozlabs.org/api/series/2268/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2268","date":"2017-09-08T17:59:12","name":"Rearrange structure members for memory efficiency.","version":1,"mbox":"http://patchwork.ozlabs.org/series/2268/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811767/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811767/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xplhk4SNYz9sDB\n\tfor ;\n\tSat, 9 Sep 2017 04:09:42 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id D8773C0C;\n\tFri, 8 Sep 2017 18:09:08 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 322DDBFA\n\tfor ; Fri, 8 Sep 2017 18:09:06 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B0AE6E5\n\tfor ; Fri, 8 Sep 2017 18:09:05 +0000 (UTC)","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 08 Sep 2017 11:09:05 -0700","from silpixa00393942.ir.intel.com (HELO\n\tsilpixa00393942.ger.corp.intel.com) ([10.237.223.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Sep 2017 11:09:04 -0700"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,362,1500966000\"; d=\"scan'208\";\n\ta=\"1216435630\"","From":"Bhanuprakash Bodireddy ","To":"dev@openvswitch.org","Date":"Fri, 8 Sep 2017 18:59:13 +0100","Message-Id":"<1504893565-110166-2-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Mailer":"git-send-email 2.4.11","In-Reply-To":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH 01/13] bond: Reorder elements in bond_slave\n\tstructure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"By reordering elements in bond_slave structure, holes can be removed and\nsaves a cache line.\n\nBefore: structure size: 136, sum holes: 10, cachelines:3\nAfter : structure size: 128, sum holes: 2, cachelines:2\n\nSigned-off-by: Bhanuprakash Bodireddy \n---\n ofproto/bond.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/ofproto/bond.c b/ofproto/bond.c\nindex 365a3ca..a656226 100644\n--- a/ofproto/bond.c\n+++ b/ofproto/bond.c\n@@ -88,13 +88,13 @@ struct bond_slave {\n \n struct netdev *netdev; /* Network device, owned by the client. */\n uint64_t change_seq; /* Tracks changes in 'netdev'. */\n- ofp_port_t ofp_port; /* OpenFlow port number. */\n char *name; /* Name (a copy of netdev_get_name(netdev)). */\n+ ofp_port_t ofp_port; /* OpenFlow port number. */\n \n /* Link status. */\n- long long delay_expires; /* Time after which 'enabled' may change. */\n bool enabled; /* May be chosen for flows? */\n bool may_enable; /* Client considers this slave bondable. */\n+ long long delay_expires; /* Time after which 'enabled' may change. */\n \n /* Rebalancing info. Used only by bond_rebalance(). */\n struct ovs_list bal_node; /* In bond_rebalance()'s 'bals' list. */\n","prefixes":["ovs-dev","01/13"]}