{"id":811666,"url":"http://patchwork.ozlabs.org/api/patches/811666/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170908153604.28383-6-romain.izard.pro@gmail.com/","project":{"id":38,"url":"http://patchwork.ozlabs.org/api/projects/38/?format=json","name":"Linux PWM development","link_name":"linux-pwm","list_id":"linux-pwm.vger.kernel.org","list_email":"linux-pwm@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908153604.28383-6-romain.izard.pro@gmail.com>","list_archive_url":null,"date":"2017-09-08T15:35:59","name":"[v1,05/10] mtd: nand: atmel: Report PMECC failures as errors","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6e55509c1e4579dc3e4fb3dd7803ca05eb9665af","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/?format=json","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pwm/patch/20170908153604.28383-6-romain.izard.pro@gmail.com/mbox/","series":[{"id":2238,"url":"http://patchwork.ozlabs.org/api/series/2238/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pwm/list/?series=2238","date":"2017-09-08T15:35:55","name":"Various patches for SAMA5D2 backup mode","version":1,"mbox":"http://patchwork.ozlabs.org/series/2238/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811666/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811666/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P02uprjG\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xphX92nnYz9t3F\n\tfor ;\n\tSat, 9 Sep 2017 01:47:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932120AbdIHPih (ORCPT );\n\tFri, 8 Sep 2017 11:38:37 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:32879 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932354AbdIHPgX (ORCPT\n\t); Fri, 8 Sep 2017 11:36:23 -0400","by mail-wm0-f65.google.com with SMTP id 187so1997765wmn.0;\n\tFri, 08 Sep 2017 08:36:22 -0700 (PDT)","from localhost.localdomain (146.187.3.109.rev.sfr.net.\n\t[109.3.187.146]) by smtp.gmail.com with ESMTPSA id\n\tp199sm1689224wmb.28.2017.09.08.08.36.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 08:36:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=P02uprjGGualMUPxI36GJhMM39AqQfDqCX1oWwcrmnrnYNmjaloAOSgZ9LlHq7Fkz/\n\tJp4YUtYpo8dhnG/PfSXn35InrHc17S5yRXHcHSQlxuCpl3uIxnKZ8ngozXXYcn6zoEAh\n\tkBIw2mhk3khGTsO1Bbpo3GU1UzSBZc1Lg6ZlalVau29gPjphnW1AALuNHrBfmpHq+jg3\n\tDlw+AhJ0bpZQsdDqc1vKTBw/XsqHCOELUJrVhhixVH+cJreMPDGb2FQTgun0G9D4YV9c\n\t8jiXqhbNqwyKnbpdiwF4A77ioGA03FAkPsC+dG0R3qv9qEfDhGW1OR7/+NQTYX0iuZ3H\n\t8isw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=aaNnsNahYIjh+1Ks16UeHfn5wML1ytVR6uApSlam0ak=;\n\tb=jxbsIpWNBfPl5fvOg5Mycfp9Re2yDT4bjZQfyQQUTgJl9+xsT4TNsQtGg9ljXxrFwb\n\tJsEcuVJJQIWlBi9+wRpk+KasMIc+Qrh9IVmN/ZEU/OLBzd6BIuX+8q4zMu+ULz1SyxmV\n\tqyHf1QUP5OLY+4EsRHodgVU5zgUkUfT0QoImh9yX2CKiEGlsYk1U8W1x9nue+MOeEO4h\n\tXII5dpvCCTDCmSxq37rYN7TxcCSf1Ed98TYsasUEXjYI5xXf8vI52SrMGqX3tlmri32v\n\t66Hd+HuOfzKMX4d8VNNIxZ/xKbprFkQKSv/TQVZojqtS47zO0nLDyNmenCk3gdym5GT7\n\tbbHQ==","X-Gm-Message-State":"AHPjjUjFJ2EF1UKUQpdvpFZMsQgxHjjtpZIRiLpXQ8S4dPZcxzxWXmlj\n\tZATVaS0CfZvmUQ==","X-Google-Smtp-Source":"AOwi7QAPmTBwCM2ylwBS1zB/di7sfuTkXBL3yv9TVmHEUUtM7a0C/wcHzMOvnLgQB8Nsst69REa9ag==","X-Received":"by 10.28.70.130 with SMTP id t124mr1935806wma.145.1504884981816; \n\tFri, 08 Sep 2017 08:36:21 -0700 (PDT)","From":"Romain Izard ","To":"Nicolas Ferre ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tJonathan Cameron , Wenyou Yang ,\n\tJosh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ","Cc":"linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-iio@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRomain Izard ","Subject":"[PATCH v1 05/10] mtd: nand: atmel: Report PMECC failures as errors","Date":"Fri, 8 Sep 2017 17:35:59 +0200","Message-Id":"<20170908153604.28383-6-romain.izard.pro@gmail.com>","X-Mailer":"git-send-email 2.11.0","In-Reply-To":"<20170908153604.28383-1-romain.izard.pro@gmail.com>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"},"content":"It is not normal for the PMECC to fail when trying to fix ECC errors.\nReport these cases as errors.\n\nSigned-off-by: Romain Izard \n---\n drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\nindex 8d1208f38025..2a23f1ff945f 100644\n--- a/drivers/mtd/nand/atmel/pmecc.c\n+++ b/drivers/mtd/nand/atmel/pmecc.c\n@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n \t * Number of roots does not match the degree of smu\n \t * unable to correct error.\n \t */\n+\tdev_err(pmecc->dev,\n+\t\t\"PMECC: Impossible to calculate error location.\\n\");\n \treturn -EBADMSG;\n }\n \n@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n \t\t\tptr = ecc + byte - sectorsize;\n \t\t\tarea = \"ECC\";\n \t\t} else {\n-\t\t\tdev_dbg(pmecc->dev,\n+\t\t\tdev_err(pmecc->dev,\n \t\t\t\t\"Invalid errpos value (%d, max is %d)\\n\",\n \t\t\t\terrpos, (sectorsize + eccbytes) * 8);\n \t\t\treturn -EINVAL;\n","prefixes":["v1","05/10"]}