{"id":811541,"url":"http://patchwork.ozlabs.org/api/patches/811541/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908111217.21985-2-kraxel@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908111217.21985-2-kraxel@redhat.com>","list_archive_url":null,"date":"2017-09-08T11:12:16","name":"[1/2] usb: drop HOST_USB","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fff00c1fb808baf3efde7bc3785fbbf53101d797","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/?format=json","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908111217.21985-2-kraxel@redhat.com/mbox/","series":[{"id":2183,"url":"http://patchwork.ozlabs.org/api/series/2183/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2183","date":"2017-09-08T11:12:15","name":"usb-host: cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/2183/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811541/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811541/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZlF6Bw0z9s83\n\tfor ;\n\tFri, 8 Sep 2017 21:26:17 +1000 (AEST)","from localhost ([::1]:44750 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqHQN-0006FA-Iq\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 07:26:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45404)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqHD1-0000sq-3H\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:12:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqHCw-0007wP-B8\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:12:27 -0400","from mx1.redhat.com ([209.132.183.28]:56206)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqHCw-0007vi-54\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 07:12:22 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 552ED4A6E5\n\tfor ; Fri, 8 Sep 2017 11:12:21 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-117-175.ams2.redhat.com\n\t[10.36.117.175])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D8E0A53C2E;\n\tFri, 8 Sep 2017 11:12:18 +0000 (UTC)","by sirius.home.kraxel.org (Postfix, from userid 1000)\n\tid 7DCF43F102; Fri, 8 Sep 2017 13:12:17 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 552ED4A6E5","From":"Gerd Hoffmann ","To":"qemu-devel@nongnu.org","Date":"Fri, 8 Sep 2017 13:12:16 +0200","Message-Id":"<20170908111217.21985-2-kraxel@redhat.com>","In-Reply-To":"<20170908111217.21985-1-kraxel@redhat.com>","References":"<20170908111217.21985-1-kraxel@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 08 Sep 2017 11:12:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH 1/2] usb: drop HOST_USB","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth , Gerd Hoffmann ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Nowdays we use libusb for usb-host, so we don't have different code\nfor linux vs. bsd any more. So there is little reason to have the\nHOST_USB variable, we can just write things directly into the Makefile\nand avoid a pointless indirection.\n\nSigned-off-by: Gerd Hoffmann \n---\n configure | 7 -------\n hw/usb/Makefile.objs | 6 +++++-\n 2 files changed, 5 insertions(+), 8 deletions(-)","diff":"diff --git a/configure b/configure\nindex a541aadebc..ec93234f47 100755\n--- a/configure\n+++ b/configure\n@@ -5978,13 +5978,6 @@ if test \"$live_block_migration\" = \"yes\" ; then\n echo \"CONFIG_LIVE_BLOCK_MIGRATION=y\" >> $config_host_mak\n fi\n \n-# USB host support\n-if test \"$libusb\" = \"yes\"; then\n- echo \"HOST_USB=libusb legacy\" >> $config_host_mak\n-else\n- echo \"HOST_USB=stub\" >> $config_host_mak\n-fi\n-\n # TPM passthrough support?\n if test \"$tpm\" = \"yes\"; then\n echo 'CONFIG_TPM=$(CONFIG_SOFTMMU)' >> $config_host_mak\ndiff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs\nindex 97f1c4561a..a43ebbc17f 100644\n--- a/hw/usb/Makefile.objs\n+++ b/hw/usb/Makefile.objs\n@@ -38,7 +38,11 @@ endif\n common-obj-$(CONFIG_USB_REDIR) += redirect.o quirks.o\n \n # usb pass-through\n-common-obj-y += $(patsubst %,host-%.o,$(HOST_USB))\n+ifeq ($(CONFIG_LIBUSB),y)\n+common-obj-y += host-libusb.o host-legacy.o\n+else\n+common-obj-y += host-stub.o\n+endif\n \n ifeq ($(CONFIG_USB_LIBUSB),y)\n common-obj-$(CONFIG_XEN) += xen-usb.o\n","prefixes":["1/2"]}