{"id":811524,"url":"http://patchwork.ozlabs.org/api/patches/811524/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-38-david@gibson.dropbear.id.au/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908103558.31632-38-david@gibson.dropbear.id.au>","list_archive_url":null,"date":"2017-09-08T10:35:55","name":"[PULL,37/40] ppc: simplify cpu model lookup by PVR","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5f8ef02558f133f20886d5b1230d7ba4b5c1aeff","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/?format=json","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-38-david@gibson.dropbear.id.au/mbox/","series":[{"id":2179,"url":"http://patchwork.ozlabs.org/api/series/2179/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179","date":"2017-09-08T10:35:20","name":"[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev","version":1,"mbox":"http://patchwork.ozlabs.org/series/2179/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811524/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811524/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"aUYRodSF\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpZ7L5hcWz9s7G\n\tfor ;\n\tFri, 8 Sep 2017 20:58:38 +1000 (AEST)","from localhost ([::1]:44555 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqGzc-0004na-IH\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:58:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58938)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqGeG-0002Id-G8\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqGe7-0003OV-Ta\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:32 -0400","from ozlabs.org ([2401:3900:2:1::2]:34133)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqGe7-0003LQ-J9; Fri, 08 Sep 2017 06:36:23 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdQ2sWLz9tXB; Fri, 8 Sep 2017 20:36:09 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866970;\n\tbh=fgZogPR/pDLgbPL3bn4Jo610bi+dHegRzyhj32K5ey8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aUYRodSF3L4V0tpUVgUFjKaLxR8as2EtNNzUJ0Qw0GF6/FB3OavZqAZZGvYOTVuSo\n\tqtSaHqkvetpE8Fhbp+jlXXCOL1nKT1Pt8LW0ANbh43c7kJQbWayE0fJTL9a2H/Meww\n\tmOe56yTED12T/FNskVmiPZRY7Wd+XoWpr/w6H6yg=","From":"David Gibson ","To":"peter.maydell@linaro.org","Date":"Fri, 8 Sep 2017 20:35:55 +1000","Message-Id":"<20170908103558.31632-38-david@gibson.dropbear.id.au>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170908103558.31632-1-david@gibson.dropbear.id.au>","References":"<20170908103558.31632-1-david@gibson.dropbear.id.au>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"[Qemu-devel] [PULL 37/40] ppc: simplify cpu model lookup by PVR","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,\n\timammedo@redhat.com, sam.bobroff@au1.ibm.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Igor Mammedov \n\nSigned-off-by: Igor Mammedov \nSigned-off-by: David Gibson \n---\n target/ppc/translate_init.c | 27 +++++++++++----------------\n 1 file changed, 11 insertions(+), 16 deletions(-)","diff":"diff --git a/target/ppc/translate_init.c b/target/ppc/translate_init.c\nindex 4092310c83..7c1d83b489 100644\n--- a/target/ppc/translate_init.c\n+++ b/target/ppc/translate_init.c\n@@ -34,6 +34,7 @@\n #include \"hw/ppc/ppc.h\"\n #include \"mmu-book3s-v3.h\"\n #include \"sysemu/qtest.h\"\n+#include \"qemu/cutils.h\"\n \n //#define PPC_DUMP_CPU\n //#define PPC_DEBUG_SPR\n@@ -10279,22 +10280,16 @@ static ObjectClass *ppc_cpu_class_by_name(const char *name)\n char *cpu_model, *typename;\n ObjectClass *oc;\n const char *p;\n- int i, len;\n-\n- /* Check if the given name is a PVR */\n- len = strlen(name);\n- if (len == 10 && name[0] == '0' && name[1] == 'x') {\n- p = name + 2;\n- goto check_pvr;\n- } else if (len == 8) {\n- p = name;\n- check_pvr:\n- for (i = 0; i < 8; i++) {\n- if (!qemu_isxdigit(*p++))\n- break;\n- }\n- if (i == 8) {\n- return OBJECT_CLASS(ppc_cpu_class_by_pvr(strtoul(name, NULL, 16)));\n+ unsigned long pvr;\n+\n+ /* Lookup by PVR if cpu_model is valid 8 digit hex number\n+ * (excl: 0x prefix if present)\n+ */\n+ if (!qemu_strtoul(name, &p, 16, &pvr)) {\n+ int len = p - name;\n+ len = (len == 10) && (name[1] == 'x') ? len - 2 : len;\n+ if ((len == 8) && (*p == '\\0')) {\n+ return OBJECT_CLASS(ppc_cpu_class_by_pvr(pvr));\n }\n }\n \n","prefixes":["PULL","37/40"]}