{"id":811513,"url":"http://patchwork.ozlabs.org/api/patches/811513/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-7-david@gibson.dropbear.id.au/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908103558.31632-7-david@gibson.dropbear.id.au>","list_archive_url":null,"date":"2017-09-08T10:35:24","name":"[PULL,06/40] spapr_drc: use g_strdup_printf() instead of snprintf()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7bf555b23e3e994844879166715d3be0aede347a","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/?format=json","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908103558.31632-7-david@gibson.dropbear.id.au/mbox/","series":[{"id":2179,"url":"http://patchwork.ozlabs.org/api/series/2179/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2179","date":"2017-09-08T10:35:20","name":"[PULL,01/40] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev","version":1,"mbox":"http://patchwork.ozlabs.org/series/2179/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811513/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811513/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"f30qOJDn\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYxk1jpLz9ryv\n\tfor ;\n\tFri, 8 Sep 2017 20:50:18 +1000 (AEST)","from localhost ([::1]:44509 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqGrY-0006Ki-9a\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:50:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58712)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqGe7-0002AG-2Y\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqGdx-0003AD-4s\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 06:36:23 -0400","from ozlabs.org ([2401:3900:2:1::2]:34305)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqGdw-000385-Qz; Fri, 08 Sep 2017 06:36:13 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xpYdJ1zlQz9t16; Fri, 8 Sep 2017 20:36:03 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1504866964;\n\tbh=dulp9xhCXh/F5i9mI+/NWugEB3u077Zpa1DLEDRAtv8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=f30qOJDnRBaNy+NPn4ZanrvF4ZIhgfNBLo7ETn8lkYP/i3Z3CsVCcxn5shXFjjZ73\n\tFsud3Rxj2sKd+bxlzjP89xIjfQqw88f2koyirlZLhwufXf1rSQoltiJtSQ33kTpN5B\n\tdj9rNo5JTD7AR93xuUGjChXe4mJ7xmoHR6sWBhHU=","From":"David Gibson ","To":"peter.maydell@linaro.org","Date":"Fri, 8 Sep 2017 20:35:24 +1000","Message-Id":"<20170908103558.31632-7-david@gibson.dropbear.id.au>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170908103558.31632-1-david@gibson.dropbear.id.au>","References":"<20170908103558.31632-1-david@gibson.dropbear.id.au>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"[Qemu-devel] [PULL 06/40] spapr_drc: use g_strdup_printf() instead\n\tof snprintf()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, aik@ozlabs.ru, agraf@suse.de,\n\tmdroth@linux.vnet.ibm.com, Greg Kurz ,\n\tqemu-ppc@nongnu.org, imammedo@redhat.com, sam.bobroff@au1.ibm.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: Greg Kurz \n\nPassing a stack allocated buffer of arbitrary length to snprintf()\nwithout checking the return value can cause the resultant strings\nto be silently truncated.\n\nSigned-off-by: Greg Kurz \nSigned-off-by: David Gibson \n---\n hw/ppc/spapr_drc.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)","diff":"diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c\nindex 85c999d9cb..644a6fffaf 100644\n--- a/hw/ppc/spapr_drc.c\n+++ b/hw/ppc/spapr_drc.c\n@@ -492,7 +492,7 @@ static void realize(DeviceState *d, Error **errp)\n {\n sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(d);\n Object *root_container;\n- char link_name[256];\n+ gchar *link_name;\n gchar *child_name;\n Error *err = NULL;\n \n@@ -505,12 +505,13 @@ static void realize(DeviceState *d, Error **errp)\n * existing in the composition tree\n */\n root_container = container_get(object_get_root(), DRC_CONTAINER_PATH);\n- snprintf(link_name, sizeof(link_name), \"%x\", spapr_drc_index(drc));\n+ link_name = g_strdup_printf(\"%x\", spapr_drc_index(drc));\n child_name = object_get_canonical_path_component(OBJECT(drc));\n trace_spapr_drc_realize_child(spapr_drc_index(drc), child_name);\n object_property_add_alias(root_container, link_name,\n drc->owner, child_name, &err);\n g_free(child_name);\n+ g_free(link_name);\n if (err) {\n error_propagate(errp, err);\n return;\n@@ -525,14 +526,15 @@ static void unrealize(DeviceState *d, Error **errp)\n {\n sPAPRDRConnector *drc = SPAPR_DR_CONNECTOR(d);\n Object *root_container;\n- char name[256];\n+ gchar *name;\n \n trace_spapr_drc_unrealize(spapr_drc_index(drc));\n qemu_unregister_reset(drc_reset, drc);\n vmstate_unregister(DEVICE(drc), &vmstate_spapr_drc, drc);\n root_container = container_get(object_get_root(), DRC_CONTAINER_PATH);\n- snprintf(name, sizeof(name), \"%x\", spapr_drc_index(drc));\n+ name = g_strdup_printf(\"%x\", spapr_drc_index(drc));\n object_property_del(root_container, name, errp);\n+ g_free(name);\n }\n \n sPAPRDRConnector *spapr_dr_connector_new(Object *owner, const char *type,\n@@ -730,10 +732,11 @@ static const TypeInfo spapr_drc_lmb_info = {\n sPAPRDRConnector *spapr_drc_by_index(uint32_t index)\n {\n Object *obj;\n- char name[256];\n+ gchar *name;\n \n- snprintf(name, sizeof(name), \"%s/%x\", DRC_CONTAINER_PATH, index);\n+ name = g_strdup_printf(\"%s/%x\", DRC_CONTAINER_PATH, index);\n obj = object_resolve_path(name, NULL);\n+ g_free(name);\n \n return !obj ? NULL : SPAPR_DR_CONNECTOR(obj);\n }\n","prefixes":["PULL","06/40"]}