{"id":811487,"url":"http://patchwork.ozlabs.org/api/patches/811487/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-35-famz@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908095506.13594-35-famz@redhat.com>","list_archive_url":null,"date":"2017-09-08T09:55:02","name":"[PULL,34/38] buildsys: Move libcacard cflags/libs to per object","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ee6a7ac9efdc54e9a5a0831c0e2e119f83524fa4","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/?format=json","name":"Fam Zheng","email":"famz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-35-famz@redhat.com/mbox/","series":[{"id":2164,"url":"http://patchwork.ozlabs.org/api/series/2164/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2164","date":"2017-09-08T09:54:28","name":"[PULL,01/38] docker: ensure NOUSER for travis images","version":1,"mbox":"http://patchwork.ozlabs.org/series/2164/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811487/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811487/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYPX6Yhbz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 20:25:52 +1000 (AEST)","from localhost ([::1]:44375 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGTv-00018h-0E\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:25:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42194)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqG1N-00005U-Sd\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqG1J-0005BH-80\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:21 -0400","from mx1.redhat.com ([209.132.183.28]:59804)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dqG1J-0005Ac-20\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:17 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1A2FF7E42A;\n\tFri,  8 Sep 2017 09:56:16 +0000 (UTC)","from lemon.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D45ED60E3A;\n\tFri,  8 Sep 2017 09:56:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1A2FF7E42A","From":"Fam Zheng <famz@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Fri,  8 Sep 2017 17:55:02 +0800","Message-Id":"<20170908095506.13594-35-famz@redhat.com>","In-Reply-To":"<20170908095506.13594-1-famz@redhat.com>","References":"<20170908095506.13594-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 08 Sep 2017 09:56:16 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 34/38] buildsys: Move libcacard cflags/libs to\n\tper object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Signed-off-by: Fam Zheng <famz@redhat.com>\nMessage-Id: <20170907082918.7299-8-famz@redhat.com>\nReviewed-by: Gerd Hoffmann <kraxel@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: Fam Zheng <famz@redhat.com>\n---\n configure            | 4 ++--\n hw/usb/Makefile.objs | 6 ++++--\n 2 files changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/configure b/configure\nindex 385ed51a18..e430df0582 100755\n--- a/configure\n+++ b/configure\n@@ -4241,8 +4241,6 @@ if test \"$smartcard\" != \"no\"; then\n     if $pkg_config libcacard; then\n         libcacard_cflags=$($pkg_config --cflags libcacard)\n         libcacard_libs=$($pkg_config --libs libcacard)\n-        QEMU_CFLAGS=\"$QEMU_CFLAGS $libcacard_cflags\"\n-        libs_softmmu=\"$libs_softmmu $libcacard_libs\"\n         smartcard=\"yes\"\n     else\n         if test \"$smartcard\" = \"yes\"; then\n@@ -5830,6 +5828,8 @@ fi\n \n if test \"$smartcard\" = \"yes\" ; then\n   echo \"CONFIG_SMARTCARD=y\" >> $config_host_mak\n+  echo \"SMARTCARD_CFLAGS=$libcacard_cflags\" >> $config_host_mak\n+  echo \"SMARTCARD_LIBS=$libcacard_libs\" >> $config_host_mak\n fi\n \n if test \"$libusb\" = \"yes\" ; then\ndiff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs\nindex 97f1c4561a..795ff25a5e 100644\n--- a/hw/usb/Makefile.objs\n+++ b/hw/usb/Makefile.objs\n@@ -26,8 +26,10 @@ common-obj-$(CONFIG_USB_BLUETOOTH)    += dev-bluetooth.o\n \n ifeq ($(CONFIG_USB_SMARTCARD),y)\n common-obj-y                          += dev-smartcard-reader.o\n-common-obj-$(CONFIG_SMARTCARD)        += ccid-card-passthru.o\n-common-obj-$(CONFIG_SMARTCARD)        += ccid-card-emulated.o\n+common-obj-$(CONFIG_SMARTCARD)        += smartcard.mo\n+smartcard.mo-objs := ccid-card-passthru.o ccid-card-emulated.o\n+smartcard.mo-cflags := $(SMARTCARD_CFLAGS)\n+smartcard.mo-libs := $(SMARTCARD_LIBS)\n endif\n \n ifeq ($(CONFIG_POSIX),y)\n","prefixes":["PULL","34/38"]}