{"id":811483,"url":"http://patchwork.ozlabs.org/api/patches/811483/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-34-famz@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908095506.13594-34-famz@redhat.com>","list_archive_url":null,"date":"2017-09-08T09:55:01","name":"[PULL,33/38] buildsys: Move opengl cflags to per object","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"17dab8c4497c35056a0ebb4068419e9c75bd48b9","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/?format=json","name":"Fam Zheng","email":"famz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-34-famz@redhat.com/mbox/","series":[{"id":2164,"url":"http://patchwork.ozlabs.org/api/series/2164/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2164","date":"2017-09-08T09:54:28","name":"[PULL,01/38] docker: ensure NOUSER for travis images","version":1,"mbox":"http://patchwork.ozlabs.org/series/2164/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811483/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811483/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpYKp07lxz9s3T\n\tfor ;\n\tFri, 8 Sep 2017 20:22:38 +1000 (AEST)","from localhost ([::1]:44358 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqGQm-0006TJ-3A\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:22:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42164)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqG1M-0008VR-3J\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqG1H-00059p-Fy\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:20 -0400","from mx1.redhat.com ([209.132.183.28]:49014)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqG1H-000591-9i\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:56:15 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 41B9BBDE3;\n\tFri, 8 Sep 2017 09:56:14 +0000 (UTC)","from lemon.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E7CF160E3A;\n\tFri, 8 Sep 2017 09:56:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 41B9BBDE3","From":"Fam Zheng ","To":"qemu-devel@nongnu.org","Date":"Fri, 8 Sep 2017 17:55:01 +0800","Message-Id":"<20170908095506.13594-34-famz@redhat.com>","In-Reply-To":"<20170908095506.13594-1-famz@redhat.com>","References":"<20170908095506.13594-1-famz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 08 Sep 2017 09:56:14 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 33/38] buildsys: Move opengl cflags to per object","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Opengl libs are already moved to per object, do so for the cflags as\nwell.\n\nSigned-off-by: Fam Zheng \nMessage-Id: <20170907082918.7299-7-famz@redhat.com>\nReviewed-by: Gerd Hoffmann \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Fam Zheng \n---\n configure | 2 +-\n ui/Makefile.objs | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/configure b/configure\nindex df22b14259..385ed51a18 100755\n--- a/configure\n+++ b/configure\n@@ -3627,7 +3627,6 @@ if test \"$opengl\" != \"no\" ; then\n if test \"$gtk\" = \"yes\" && $pkg_config --exists \"$gtkpackage >= 3.16\"; then\n gtk_gl=\"yes\"\n fi\n- QEMU_CFLAGS=\"$QEMU_CFLAGS $opengl_cflags\"\n else\n if test \"$opengl\" = \"yes\" ; then\n feature_not_found \"opengl\" \"Please install opengl (mesa) devel pkgs: $opengl_pkgs\"\n@@ -5843,6 +5842,7 @@ fi\n \n if test \"$opengl\" = \"yes\" ; then\n echo \"CONFIG_OPENGL=y\" >> $config_host_mak\n+ echo \"OPENGL_CFLAGS=$opengl_cflags\" >> $config_host_mak\n echo \"OPENGL_LIBS=$opengl_libs\" >> $config_host_mak\n if test \"$opengl_dmabuf\" = \"yes\" ; then\n echo \"CONFIG_OPENGL_DMABUF=y\" >> $config_host_mak\ndiff --git a/ui/Makefile.objs b/ui/Makefile.objs\nindex e3403b698b..95943d9c33 100644\n--- a/ui/Makefile.objs\n+++ b/ui/Makefile.objs\n@@ -53,10 +53,10 @@ gtk.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n gtk-egl.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n gtk-gl-area.o-libs := $(GTK_LIBS) $(VTE_LIBS)\n \n-gtk-egl.o-libs += $(OPENGL_LIBS)\n-shader.o-libs += $(OPENGL_LIBS)\n-console-gl.o-libs += $(OPENGL_LIBS)\n-egl-helpers.o-libs += $(OPENGL_LIBS)\n+$(foreach x, gtk-egl shader console egl-helpers, \\\n+\t$(eval $x.o-libs += $(OPENGL_LIBS)) \\\n+\t$(eval $x.o-cflags += $(OPENGL_CFLAGS)) \\\n+)\n \n curses.o-cflags := $(CURSES_CFLAGS)\n curses.o-libs := $(CURSES_LIBS)\n","prefixes":["PULL","33/38"]}