{"id":811458,"url":"http://patchwork.ozlabs.org/api/patches/811458/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-21-famz@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908095506.13594-21-famz@redhat.com>","list_archive_url":null,"date":"2017-09-08T09:54:48","name":"[PULL,20/38] docker: Fix return code of build_qemu()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9d8dffcba5b0d606911ea5a5a8ac8589ab35a27f","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/?format=json","name":"Fam Zheng","email":"famz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908095506.13594-21-famz@redhat.com/mbox/","series":[{"id":2164,"url":"http://patchwork.ozlabs.org/api/series/2164/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2164","date":"2017-09-08T09:54:28","name":"[PULL,01/38] docker: ensure NOUSER for travis images","version":1,"mbox":"http://patchwork.ozlabs.org/series/2164/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811458/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811458/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpXzl6yvCz9rxj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 20:06:59 +1000 (AEST)","from localhost ([::1]:44287 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqGBd-0000eV-Qm\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 06:06:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41837)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqG0w-00086P-Gu\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:55:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqG0r-0004ny-Vv\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:55:54 -0400","from mx1.redhat.com ([209.132.183.28]:38712)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dqG0r-0004nS-PJ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:55:49 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C1D46883A0;\n\tFri,  8 Sep 2017 09:55:48 +0000 (UTC)","from lemon.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7F2AF60E3A;\n\tFri,  8 Sep 2017 09:55:47 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C1D46883A0","From":"Fam Zheng <famz@redhat.com>","To":"qemu-devel@nongnu.org","Date":"Fri,  8 Sep 2017 17:54:48 +0800","Message-Id":"<20170908095506.13594-21-famz@redhat.com>","In-Reply-To":"<20170908095506.13594-1-famz@redhat.com>","References":"<20170908095506.13594-1-famz@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 08 Sep 2017 09:55:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PULL 20/38] docker: Fix return code of build_qemu()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"Without \"set -e\", the \"&&\" makes sure that the return code reflects the\nresult status, and that make only runs if configure succeeds.\n\nSigned-off-by: Fam Zheng <famz@redhat.com>\nMessage-Id: <20170905025614.579-2-famz@redhat.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nBased-on: 20170905021201.25684-1-famz@redhat.com\n---\n tests/docker/common.rc | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/tests/docker/common.rc b/tests/docker/common.rc\nindex 64b36ba2d0..3b45eb91c6 100755\n--- a/tests/docker/common.rc\n+++ b/tests/docker/common.rc\n@@ -30,6 +30,5 @@ build_qemu()\n                  $@\"\n     echo \"Configure options:\"\n     echo $config_opts\n-    $QEMU_SRC/configure $config_opts\n-    make $MAKEFLAGS\n+    $QEMU_SRC/configure $config_opts && make $MAKEFLAGS\n }\n","prefixes":["PULL","20/38"]}