{"id":811281,"url":"http://patchwork.ozlabs.org/api/patches/811281/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/CALttK1RuvV138kNT4w+EbAbji=U6Bn16BZVQ5nOjf7dV6stWnA@mail.gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<CALttK1RuvV138kNT4w+EbAbji=U6Bn16BZVQ5nOjf7dV6stWnA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-08T01:51:38","name":"[ovs-dev] put bundle_lookup ahead to simplify the code","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7163c4a85e4b39fc864d0356d684e5d994eca0da","submitter":{"id":15370,"url":"http://patchwork.ozlabs.org/api/people/15370/?format=json","name":"duanjiong","email":"djduanjiong@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/CALttK1RuvV138kNT4w+EbAbji=U6Bn16BZVQ5nOjf7dV6stWnA@mail.gmail.com/mbox/","series":[{"id":2086,"url":"http://patchwork.ozlabs.org/api/series/2086/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=2086","date":"2017-09-08T01:51:38","name":"[ovs-dev] put bundle_lookup ahead to simplify the code","version":1,"mbox":"http://patchwork.ozlabs.org/series/2086/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811281/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811281/checks/","tags":{},"related":[],"headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ojIqTBRQ\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpL0L2xn3z9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 11:51:46 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 3DE8BABC;\n\tFri,  8 Sep 2017 01:51:43 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id A3589486\n\tfor <dev@openvswitch.org>; Fri,  8 Sep 2017 01:51:41 +0000 (UTC)","from mail-lf0-f65.google.com (mail-lf0-f65.google.com\n\t[209.85.215.65])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 17C40E0\n\tfor <dev@openvswitch.org>; Fri,  8 Sep 2017 01:51:41 +0000 (UTC)","by mail-lf0-f65.google.com with SMTP id q132so516748lfe.4\n\tfor <dev@openvswitch.org>; Thu, 07 Sep 2017 18:51:40 -0700 (PDT)","by 10.46.92.198 with HTTP; Thu, 7 Sep 2017 18:51:38 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:from:date:message-id:subject:to;\n\tbh=pGp63nAnXDw6eWvtnYiq8LFyT8jJN63aKsKD/2+QPRM=;\n\tb=ojIqTBRQQ+71lJY8lbc0uiBz2HXsJmh/8LCuXTRZ3mKqFn0Zoj9uiYPINFCQE8G5Tp\n\tkY3Ig3CAgqIeILr8GClKmcjQkrgYTQuQDDA/VzQRLbb9C6jCqL8w0IAG/9xkYyp4uZSj\n\tDcTp5wfZxFmDLek6YTH6f7iz3feD0tixw4Fv19tyMerZgZXuF/j7W1cqj+FIu2OE6dSA\n\tLrvW2829cBXKHls0kruIZTcHMcy4sJcv1BDFcqyzFF2GXBhhELZGcNiiyAIcQsKcAgRN\n\tMr2XJKW9xYjTzoiQocZ0JHuXytBafDEMY0VEvouDz2edA8Wmz7Ay1OQ5e1ykNq2RSCRL\n\tVtTQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:from:date:message-id:subject:to;\n\tbh=pGp63nAnXDw6eWvtnYiq8LFyT8jJN63aKsKD/2+QPRM=;\n\tb=ILmlFWwDA7u1OIuJd8xnuPtH1XL99sSZIZbYMzEXu3gsh4V3PNU9l1JwzcjF/mmRXE\n\tDGhXZi/GX1+KDz3CD4JP9XtQxU7xYk9YEXHRUk1hx72kT1PWAYvMBCDEh18vV3K6V3L2\n\tubVHEgAhU/FakuG7JOIUKeQaocoPyMirmx4R1A6gZao/w+VXn+LQLpK2wadjiSA17g0s\n\t+2ru/560lnhWYDjUeMri2rHeav4PkeICCMOY4w3gR3ebcKOx1HHZFBbpePCAGIxVwl+L\n\tlxunh7ON61o/kllgXqLBIKzXGpr4NhLO2T0EIUXVi/IgbNhyNe3WhtBFxK34zjO4ZA5G\n\tXteg==","X-Gm-Message-State":"AHPjjUgO46TMpCc7CO10I5HWY2/IKYC4lXJlNuTOFX4Rz0tJsQvQ3GOs\n\t7Wes+1vM6B0rdJa5IkKmyJ47IjNqf5tm","X-Google-Smtp-Source":"ADKCNb5L2MWeGJu+0XD9/iQeQpeiu6mwNsXTaZf97vJswgHdF9+bVdJlzR6jR3RASoIYkZ8FpF7Ef/Mdv4NBud0iR9s=","X-Received":"by 10.46.9.81 with SMTP id 78mr370781ljj.175.1504835499322; Thu,\n\t07 Sep 2017 18:51:39 -0700 (PDT)","MIME-Version":"1.0","From":"Duan Jiong <djduanjiong@gmail.com>","Date":"Fri, 8 Sep 2017 09:51:38 +0800","Message-ID":"<CALttK1RuvV138kNT4w+EbAbji=U6Bn16BZVQ5nOjf7dV6stWnA@mail.gmail.com>","To":"dev@openvswitch.org","X-Spam-Status":"No, score=0.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"[ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"From ba48275f8bb30ed2888c16426726ee9cb3407cd1 Mon Sep 17 00:00:00 2001\nFrom: Duan Jiong <djduanjiong@gmail.com>\nDate: Fri, 8 Sep 2017 09:48:59 +0800\nSubject: [PATCH] put bundle_lookup ahead to simplify the code\n\nSigned-off-by: Duan Jiong <djduanjiong@gmail.com>\n---\n ofproto/ofproto-dpif.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c\nindex 1a8e829..293780f 100644\n--- a/ofproto/ofproto-dpif.c\n+++ b/ofproto/ofproto-dpif.c\n@@ -3011,15 +3011,16 @@ bundle_set(struct ofproto *ofproto_, void *aux,\n     size_t i;\n     bool ok;\n\n+    bundle = bundle_lookup(ofproto, aux);\n+\n     if (!s) {\n-        bundle_destroy(bundle_lookup(ofproto, aux));\n+        bundle_destroy(bundle);\n         return 0;\n     }\n\n     ovs_assert(s->n_slaves == 1 || s->bond != NULL);\n     ovs_assert((s->lacp != NULL) == (s->lacp_slaves != NULL));\n\n-    bundle = bundle_lookup(ofproto, aux);\n     if (!bundle) {\n         bundle = xmalloc(sizeof *bundle);\n\n","prefixes":["ovs-dev"]}