{"id":811280,"url":"http://patchwork.ozlabs.org/api/patches/811280/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/20170908014202.1465-1-aweits@rit.edu/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170908014202.1465-1-aweits@rit.edu>","list_archive_url":null,"date":"2017-09-08T01:42:02","name":"PMKSA: fix use-after-free in pmksa_cache_clone_entry()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fd3978cce3878e8cebc7b4ba69b66b233d107116","submitter":{"id":72326,"url":"http://patchwork.ozlabs.org/api/people/72326/?format=json","name":"Andrew Elble","email":"aweits@rit.edu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/20170908014202.1465-1-aweits@rit.edu/mbox/","series":[{"id":2085,"url":"http://patchwork.ozlabs.org/api/series/2085/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/list/?series=2085","date":"2017-09-08T01:42:02","name":"PMKSA: fix use-after-free in pmksa_cache_clone_entry()","version":1,"mbox":"http://patchwork.ozlabs.org/series/2085/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/811280/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/811280/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"QyjbUb5K\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpKq93Mfvz9sBZ\n\tfor ;\n\tFri, 8 Sep 2017 11:43:49 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq8KG-0008Ty-IA; Fri, 08 Sep 2017 01:43:20 +0000","from discipline.rit.edu ([129.21.6.207])\n\tby bombadil.infradead.org with smtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq8Jr-0008PR-RE\n\tfor hostap@lists.infradead.org; Fri, 08 Sep 2017 01:42:57 +0000","(qmail 2633 invoked by uid 501); 8 Sep 2017 01:42:33 -0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=kzSXx56yUXtQwQVpjdaJiR9tZk60kPE+hA0E+Rd8FdI=;\n\tb=Qyj\n\tbUb5KlBZBVzqHqFI89N5ZSVADfNi5vNmm2JeouW4LgC4cEKkrC6kG+VqVQT2MDOL+JlStOUp/CaMh\n\tDVXWM1wghZjzAYB8Kt92zZ55itIr8KhhBSmakcJfqEJ++KE7w8A8LCDG+vQyiUYWO2qd/2k4mfa7l\n\tAu7xfFdKsRuPbgCRTA5l6VW0FMr8Y13H5NAUXgubXaitp3KHtLb4toEN8zxMwpReHanvALIxqOsKa\n\trIzXXtbTCQpWU/szFbug7FUdKUKalp3xlCJIE8ucrea8QN9A9Uj75AZ3nAPJFLRdz9zJqZE2XolZT\n\tsfEGUWpCLOWvMYEdtm3OV0q3zacQ3DA==;","From":"Andrew Elble ","To":"hostap@lists.infradead.org","Subject":"[PATCH] PMKSA: fix use-after-free in pmksa_cache_clone_entry()","Date":"Thu, 7 Sep 2017 21:42:02 -0400","Message-Id":"<20170908014202.1465-1-aweits@rit.edu>","X-Mailer":"git-send-email 2.10.1","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170907_184256_080540_002A91FE ","X-CRM114-Status":"UNSURE ( 6.83 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Elble ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"pmksa_cache_add_entry() may actually free old_entry if the pmksa cache\nis full. This can result in the pmksa cache containing entries with\ncorrupt expiration times.\n\nSigned-off-by: Andrew Elble \n---\n src/rsn_supp/pmksa_cache.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/rsn_supp/pmksa_cache.c b/src/rsn_supp/pmksa_cache.c\nindex e1cfa146a3d1..a353404c22b4 100644\n--- a/src/rsn_supp/pmksa_cache.c\n+++ b/src/rsn_supp/pmksa_cache.c\n@@ -367,6 +367,7 @@ pmksa_cache_clone_entry(struct rsn_pmksa_cache *pmksa,\n \t\t\tconst u8 *aa)\n {\n \tstruct rsn_pmksa_cache_entry *new_entry;\n+\tos_time_t old_expiration = old_entry->expiration;\n \n \tnew_entry = pmksa_cache_add(pmksa, old_entry->pmk, old_entry->pmk_len,\n \t\t\t\t NULL, NULL, 0,\n@@ -378,7 +379,7 @@ pmksa_cache_clone_entry(struct rsn_pmksa_cache *pmksa,\n \t\treturn NULL;\n \n \t/* TODO: reorder entries based on expiration time? */\n-\tnew_entry->expiration = old_entry->expiration;\n+\tnew_entry->expiration = old_expiration;\n \tnew_entry->opportunistic = 1;\n \n \treturn new_entry;\n","prefixes":[]}